On Wed, 2007-03-07 at 19:07 +0100, Bram - Smartelectronix wrote:
> Malcolm Tredinnick wrote:
> > On Wed, 2007-03-07 at 02:34 +0100, Bram - Smartelectronix wrote:
> >> Malcolm Tredinnick wrote:
> >>> (2) This is the sort of thing that should come with a test to ensure we
> >>> don't introduce the s
Bram - Smartelectronix wrote:
>
>
> Any hints?
looks like SmileyChris got ahead of me and did all the fix'n, but i
guess i'd still like to know so i can prepare future patches better.
- bram
--~--~-~--~~~---~--~~
You received this message because you are s
Malcolm Tredinnick wrote:
> On Wed, 2007-03-07 at 02:34 +0100, Bram - Smartelectronix wrote:
>> Malcolm Tredinnick wrote:
>>> (2) This is the sort of thing that should come with a test to ensure we
>>> don't introduce the same mistake again. Have a look in
>>> tests/regressiontests/templates/tests
On Wed, 2007-03-07 at 02:25 +0100, Bram - Smartelectronix wrote:
> > (1) When you create a patch, best to do it from the top of the Django
> > source tree (the directory just about django/). Then we can tell which
> > file you are patching. There are many files called __init__.py in our
> > source
On Wed, 2007-03-07 at 02:34 +0100, Bram - Smartelectronix wrote:
> Malcolm Tredinnick wrote:
> > (2) This is the sort of thing that should come with a test to ensure we
> > don't introduce the same mistake again. Have a look in
> > tests/regressiontests/templates/tests.py for related tests and add
Malcolm Tredinnick wrote:
> (2) This is the sort of thing that should come with a test to ensure we
> don't introduce the same mistake again. Have a look in
> tests/regressiontests/templates/tests.py for related tests and add a
> couple of options in there.
i forgot to ask: should additions to th
> (1) When you create a patch, best to do it from the top of the Django
> source tree (the directory just about django/). Then we can tell which
> file you are patching. There are many files called __init__.py in our
> source tree and we really need to know *which one* is the right one to
> patch.
Hi Bram,
On Wed, 2007-03-07 at 01:37 +0100, Bram - Smartelectronix wrote:
> as it's the first patch i do, perhaps someone can tell me if i did well ;-)
>
> http://code.djangoproject.com/ticket/3670
Happy to provide feedback. A couple of things that jump out at me from
reading this patch:
(1) W
as it's the first patch i do, perhaps someone can tell me if i did well ;-)
http://code.djangoproject.com/ticket/3670
- bram
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Django users" group.
To post to this g
9 matches
Mail list logo
