Re: Channels - logout not resetting message.user value on new WebSocket connections

2017-03-27 Thread Andrew Godwin
To follow up on this - I have updated the spec ( http://channels.readthedocs.io/en/latest/asgi/www.html) to clarify exactly how accept works, added accept: False as an allowed value, and patched Daphne to work with that as of next release. Andrew On Mon, Mar 27, 2017 at 9:52 AM, Andrew Godwin wr

Re: Channels - logout not resetting message.user value on new WebSocket connections

2017-03-27 Thread Andrew Godwin
Or make "accept": False do the same as "close": True. The reason that close is a separate argument is that you can pass a WebSocket close code, optionally (we have a default if you don't, but that's probably enough for most people) Andrew On Mon, Mar 27, 2017 at 6:37 AM, Melvyn Sopacua wrote: >

Re: Channels - logout not resetting message.user value on new WebSocket connections

2017-03-27 Thread Melvyn Sopacua
On Sunday 26 March 2017 15:40:28 Andrew Godwin wrote: > - The way to reject a socket connection is "close": True, not > "accept": False; try changing to that If there is no use case for 'accept': False, then it makes more sense to change the API to reply_channel.accept() and reply_channel.rejec

Re: Channels - logout not resetting message.user value on new WebSocket connections

2017-03-26 Thread Andrew Godwin
This isn't a known issue, but I'll need more debugging info to know if it's Channels or not. Couple of checks: - The way to reject a socket connection is "close": True, not "accept": False; try changing to that - What is the value of message.user and message.reply_channel on each of a a) correct