Re: Possible bug with django.contrib.auth.forms

2013-05-06 Thread Russell Keith-Magee
Actually…. I take this back. I went digging into the form logic, and discovered that I was incorrect about the empty tag -- there's already logic in place to suppress the if there's no label content. So - I'd say you're correct - the check in AuthenticationForm *should* be an "is None" check to

Re: Possible bug with django.contrib.auth.forms

2013-05-06 Thread Russell Keith-Magee
Hi Zhenghao Huang, I'm not sure I agree that this is a bug. >From a purely logical perspective, I agree the an "is None" check would be more rigorous. However, allowing the field label to the empty string isn't really a good idea. It won't prevent the markup from being rendered, it will just me

Possible bug with django.contrib.auth.forms

2013-05-06 Thread Zhenghao Huang
Hi Fellas, Just wanted to throw this out there to see if this is a bug. In line 173 of django.contrib.auth.forms: https://github.com/zhenghao1/django/blob/master/django/contrib/auth/forms.py#L173 I feel this boolean test is too generic. If I were to deliberately set the username field's lab