Re: Nullable ChoiceField on ModelForm - has_changed always True

2016-01-20 Thread James Schneider
On Tue, Jan 19, 2016 at 4:45 PM, steve byerly wrote: > Also of note, I recently upgraded to Django 1.9 from Django 1.7 where this > was working fine. It looks like this commit is the cause of my problem: > > https://github.com/django/django/commit/ff077cd6496b6f82195e2dc040f70e19e7c206c9 > > Is t

Re: Nullable ChoiceField on ModelForm - has_changed always True

2016-01-20 Thread steve byerly
It actually looks like the commit fixed the regression and was in 1.9.1. Didn't realize it had been released. On Tuesday, January 19, 2016 at 4:45:52 PM UTC-8, steve byerly wrote: > > Also of note, I recently upgraded to Django 1.9 from Django 1.7 where this > was working fine. It looks like thi

Re: Nullable ChoiceField on ModelForm - has_changed always True

2016-01-19 Thread steve byerly
Also of note, I recently upgraded to Django 1.9 from Django 1.7 where this was working fine. It looks like this commit is the cause of my problem: https://github.com/django/django/commit/ff077cd6496b6f82195e2dc040f70e19e7c206c9 On Tuesday, January 19, 2016 at 4:23:00 PM UTC-8, steve byerly wrote:

Nullable ChoiceField on ModelForm - has_changed always True

2016-01-19 Thread steve byerly
I have a model with a nullable field (PositiveSmallIntegerField) with defined choices. When I make a ModelForm for the model and do not select a value for this field, the field always comes back in the changed data. The reason is that the empty choice value, the data_value, is an empty string,