Thanks Jeff, that looks good from my perspective.
On Fri, 6 Aug 2021 at 03:44, Jeff Long wrote:
> Draft PR for this: https://github.com/gnuradio/gnuradio/pull/4982
>
> On Thu, Aug 5, 2021 at 8:58 AM Boris Marjanovic
> wrote:
>
>> In our case the difference logging level was set to ERROR. There
Draft PR for this: https://github.com/gnuradio/gnuradio/pull/4982
On Thu, Aug 5, 2021 at 8:58 AM Boris Marjanovic
wrote:
> In our case the difference logging level was set to ERROR. There were no
> lines logged. I ran a valgrind with no special settings
> - log4cpp was approximately 5% of total
In our case the difference logging level was set to ERROR. There were no
lines logged. I ran a valgrind with no special settings
- log4cpp was approximately 5% of total running time
- after modifying logging macros, it was 0.02%
The effect would depend on how one does logging. If the logging state
How badly is this affecting performance? I could see adding something like
a GR_CHECK_LEVEL() to all the logging macros if the call to log4cpp's
getPriority() is cheaper than executing the (msg) code. It probably is.
On Wed, Aug 4, 2021 at 2:28 PM Marcus Müller wrote:
> Hi Boris,
>
> I honestly
Hi Boris,
I honestly thought, up to last week, the same as you. So, this is not intended,
and we'll
fix it, but sadly probably not on 3.9.
Best regards,
Marcus
On 29.07.21 07:39, Boris Marjanovic wrote:
> Hi,
>
> I've been profiling the flowgraph I've been working on and discovered that
> the
Hi,
I've been profiling the flowgraph I've been working on and discovered that
there is a lot of time spent in logging infrastructure even when logging
levels were not enabled.
The logging statements are not simple strings but a call to the formatting
library in my case. I used the fmt library. So
