Re: [Discuss-gnuradio] Bug in gr_pll_carriertracking.cc

2011-11-24 Thread Robert McGwier
The last time I did this I had written the routine ;-) Bob On Nov 23, 2011 11:18 AM, "Ben Hilburn" wrote: > Heh, sometimes you have to e-mail a public list before any of it makes > sense. Happens to me all the time =) > > Cheers, > Ben > > > On Wed, Nov 23, 2011 at 8:53 AM, Marcus M wro

Re: [Discuss-gnuradio] Bug in gr_pll_carriertracking.cc

2011-11-23 Thread Ben Hilburn
Heh, sometimes you have to e-mail a public list before any of it makes sense. Happens to me all the time =) Cheers, Ben On Wed, Nov 23, 2011 at 8:53 AM, Marcus M wrote: > > > On Wed, Nov 23, 2011 at 10:12 AM, Marcus M wrote: > >> Hi, >> I have the latest gnuradio release and I think the phas

Re: [Discuss-gnuradio] Bug in gr_pll_carriertracking.cc

2011-11-23 Thread Marcus M
On Wed, Nov 23, 2011 at 10:12 AM, Marcus M wrote: > Hi, > I have the latest gnuradio release and I think the phase error calculation > in gr_pll_carriertracking.cc might be wrong. > > In Line 107 the phase error is calculated as, > error = phase_detector(iptr[i],d_phase); > > whereas, I think it

[Discuss-gnuradio] Bug in gr_pll_carriertracking.cc

2011-11-23 Thread Marcus M
Hi, I have the latest gnuradio release and I think the phase error calculation in gr_pll_carriertracking.cc might be wrong. In Line 107 the phase error is calculated as, error = phase_detector(iptr[i],d_phase); whereas, I think it should be as shown below as the phase error is calculated from the