Re: [ovs-discuss] custom action help

2013-09-25 Thread Ben Pfaff
It's your custom code, do as you like. On Wed, Sep 25, 2013 at 06:17:35PM +0300, Andrei Andone wrote: > Yeah, I could use multiple `set_field` actions, but then the flow > would be really long (and for now I only need to change around 7 > fields and the flow start being pretty hard to read). > >

Re: [ovs-discuss] custom action help

2013-09-25 Thread Andrei Andone
Yeah, I could use multiple `set_field` actions, but then the flow would be really long (and for now I only need to change around 7 fields and the flow start being pretty hard to read). Example: ovs-ofctl add-flow my_bridge "in_port=1 actions=set_field:value->field1,set_field:value->field2,set_

Re: [ovs-discuss] custom action help

2013-09-25 Thread Ben Pfaff
On Wed, Sep 25, 2013 at 11:31:13AM +0300, Andrei Andone wrote: > What do you guys usually use or recommend regarding new complex > actions (complex as in it modifies more fields), is it better to > define the action similarly to the nicira extended actions or should > I just create an action for ea

Re: [ovs-discuss] custom action help

2013-09-25 Thread Andrei Andone
Hello Ben, This is more of a best practices question related to this action that I implemented. What do you guys usually use or recommend regarding new complex actions (complex as in it modifies more fields), is it better to define the action similarly to the nicira extended actions or should

Re: [ovs-discuss] custom action help

2013-09-23 Thread Andrei Andone
Hello Ben, Thank you for your answer. I hadn't added the action to the datapath but while I was writing this email and wanted to ask you where I should look for the entry point (thinking it should be somewhere in "odp-util.c") I found the entry point and added my action to the datapath. It n

Re: [ovs-discuss] custom action help

2013-09-20 Thread Ben Pfaff
On Fri, Sep 20, 2013 at 08:00:10PM +0300, Andrei Andone wrote: > I managed to follow the nicira extended actions and created one of my own. > I did stumble upon an issue that I can't find a solution to though. > The action I've made has to overwrite the packets arp body (amongst > other things). >

[ovs-discuss] custom action help

2013-09-20 Thread Andrei Andone
Hello guys, I managed to follow the nicira extended actions and created one of my own. I did stumble upon an issue that I can't find a solution to though. The action I've made has to overwrite the packets arp body (amongst other things). I managed to make my action compatible with openflow, an