Ok, excellent. Thanks for the clarification.
On Wed, Jan 21, 2015 at 4:24 PM, Ben Pfaff wrote:
> The updated definition of OFPERR_OFPBRC_IS_SLAVE will use the type and
> code for OFPBRC_EPERM in OpenFlow 1.0 and 1.1, and the type and code
> for OFPBRC_IS_SLAVE in OpenFlow 1.2+ without any specia
The updated definition of OFPERR_OFPBRC_IS_SLAVE will use the type and
code for OFPBRC_EPERM in OpenFlow 1.0 and 1.1, and the type and code
for OFPBRC_IS_SLAVE in OpenFlow 1.2+ without any special logic
elsewhere in the code. In other words, it does the same thing as what
you suggested elsewhere,
This is what I had in mind:
static enum ofperr
reject_slave_controller(struct ofconn *ofconn)
{
if (ofconn_get_type(ofconn) == OFCONN_PRIMARY
&& ofconn_get_role(ofconn) == OFPCR12_ROLE_SLAVE) {
if (ofputil_protocol_to_ofp_version(ofconn_get_protocol(ofconn)) >=
OFP12_VERSION) {
I am actually confused by the fix. OFPBRC_IS_SLAVE is an OpenFlow 1.2+
error message, correct? The comment in the header file is changed and it
appears that this is an OpenFlow 1.0+ error message and I am not sure if
that's right. Likewise OFPBRC_IS_SLAVE is returned while rejecting slave
controlle
I sent out a fix:
http://openvswitch.org/pipermail/dev/2015-January/050612.html
On Tue, Jan 20, 2015 at 03:01:27PM -0800, Ben Pfaff wrote:
> The OF1.2 feature was based on an Open vSwitch extension to OpenFlow
> first implemented for OF1.0. We need to continue supporting that
> extension.
The OF1.2 feature was based on an Open vSwitch extension to OpenFlow
first implemented for OF1.0. We need to continue supporting that
extension.
On Tue, Jan 20, 2015 at 05:12:30PM -0500, Anup Khadka wrote:
> Do OpenFlow versions prior to OF 1.2 even support the concept of slave
> controllers? I c
I can create a patch for this if you want me to.
Thank you,
Anup
On Tue, Jan 20, 2015 at 5:12 PM, Anup Khadka wrote:
> Do OpenFlow versions prior to OF 1.2 even support the concept of slave
> controllers? I couldn't find anything in the specs.
>
> On Tue, Jan 20, 2015 at 4:24 PM, Ben Pfaff wro
Do OpenFlow versions prior to OF 1.2 even support the concept of slave
controllers? I couldn't find anything in the specs.
On Tue, Jan 20, 2015 at 4:24 PM, Ben Pfaff wrote:
> On Tue, Jan 20, 2015 at 03:55:57PM -0500, Anup Khadka wrote:
> > I have noticed that OVS rejects flow-mod request from a
On Tue, Jan 20, 2015 at 03:55:57PM -0500, Anup Khadka wrote:
> I have noticed that OVS rejects flow-mod request from a slave-controller
> with an OFPBRC_EPERM request code. Isn't the more appropriate code here is:
> OFPBRC_IS_SLAVE?
>
> Same thing when a slave controller sends a packet out.
That
Hello,
I have noticed that OVS rejects flow-mod request from a slave-controller
with an OFPBRC_EPERM request code. Isn't the more appropriate code here is:
OFPBRC_IS_SLAVE?
Same thing when a slave controller sends a packet out.
Thanks,
Anup
___
discuss
10 matches
Mail list logo
