Re: [ovs-discuss] No check for memory allocation from malloc()

I sent a patch for review: http://openvswitch.org/pipermail/dev/2015-September/060110.html On Tue, Sep 15, 2015 at 12:33:03PM -0700, Neil McKee wrote: > In OVS a callback fn is given to the sFlow library for all allocation, but > the callback (ofproto/ofproto-dpif-sflow.c:sflow_agent_allo

Re: [ovs-discuss] No check for memory allocation from malloc()

In OVS a callback fn is given to the sFlow library for all allocation, but the callback (ofproto/ofproto-dpif-sflow.c:sflow_agent_alloc_cb()) just calls "calloc()" too. This should probably be changed to xcalloc() as defined in lib/util.c which does the right thing. Thanks for pointing this out

[ovs-discuss] No check for memory allocation from malloc()

Hi Team, I was looking a the code in sfow_agent.c file in sflAlloc( ) function. This funtion allocates memory via malloc but didn't check whether memory allocation is successful or not. I think there should be a check, in case malloc fails to allocate memory. Regards Neeraj __