Re: [ovs-discuss] Finding a rule

2016-08-12 Thread Ben Pfaff
find_match_wc() is the same as find_match() except that it also updates a 'wc' parameter to reflect the fields that had to be examined to find the match (or find no match). On Thu, Aug 11, 2016 at 10:53:25PM +0200, Amrane Ait Zeouay wrote: > Sorry for not explaining, I added the field and it's wor

Re: [ovs-discuss] Finding a rule

2016-08-11 Thread Amrane Ait Zeouay
Sorry for not explaining, I added the field and it's works really fine, but just I did some modification on classifier_lookup__() especially the function "find_match_wc()" and i just want to know how the OvS find the rules ? so if you could explain to me about the function "find_match_wc()" because

Re: [ovs-discuss] Finding a rule

2016-08-11 Thread Ben Pfaff
Now I'm confused. First, you said that you're adding a new field and found a problem. Now, you said that you're trying to explain how classifier_lookup__() works for a presentation. Which of these is really true? On Thu, Aug 11, 2016 at 08:27:43PM +0200, Amrane Ait Zeouay wrote: > I want just t

Re: [ovs-discuss] Finding a rule

2016-08-11 Thread Amrane Ait Zeouay
I want just to understand how the function classifier_lookup__() works. Because i have the presentation and i need to explain to them about it, and i read your documents but there is nothing how this function works. I found that if there is no wildcard then it will go from the first condition in th

Re: [ovs-discuss] Finding a rule

2016-08-11 Thread Ben Pfaff
You're doing something wrong. The classifier finds a matching rule. There's no need to "check" anything afterward. The classifier doesn't have any provision for finding a "different" rule. On Thu, Aug 11, 2016 at 05:51:40PM +0200, Amrane Ait Zeouay wrote: > No, I'm working with classifier to fin

Re: [ovs-discuss] Finding a rule

2016-08-11 Thread Amrane Ait Zeouay
No, I'm working with classifier to find the rule. So when the classifier found the rule I need to check that rule. But the problem is when i want the classifier to give me another rule different from the highest rule that matches the flow. Thank you. On 11 Aug 2016 5:45 pm, "Ben Pfaff" wrote: > O

Re: [ovs-discuss] Finding a rule

2016-08-11 Thread Ben Pfaff
On Thu, Aug 11, 2016 at 01:14:38PM +0200, Amrane Ait Zeouay wrote: > I'm working on Openvswitch version 2.5.0 for adding new fields, And I found > a problem with my implemntation in the function "find_match_wc()" file > lib/classifier.c, I want to know when the condition "OVS_UNLIKELY(!wc)" is > us

[ovs-discuss] Finding a rule

2016-08-11 Thread Amrane Ait Zeouay
Hey, I'm working on Openvswitch version 2.5.0 for adding new fields, And I found a problem with my implemntation in the function "find_match_wc()" file lib/classifier.c, I want to know when the condition "OVS_UNLIKELY(!wc)" is used, and this condition too "!cmap_node_next(inode)" and the last one