Re: [ovs-discuss] Rejecting flow-mod from a slave controller

2015-01-21 Thread Anup Khadka
thout any special logic > elsewhere in the code. In other words, it does the same thing as what > you suggested elsewhere, without having to write all that special-case > code. > > On Wed, Jan 21, 2015 at 01:08:40PM -0500, Anup Khadka wrote: > > I am actually confused by the fix.

Re: [ovs-discuss] Rejecting flow-mod from a slave controller

2015-01-21 Thread Anup Khadka
P12_VERSION) { return OFPERR_OFPBRC_IS_SLAVE; } else { return OFPERR_OFPBRC_EPERM; } } else { return 0; } } On Wed, Jan 21, 2015 at 1:08 PM, Anup Khadka wrote: > I am actually confused by the fix. OFPBRC_IS_SLAVE is an OpenFlow 1.2+ &

Re: [ovs-discuss] Rejecting flow-mod from a slave controller

2015-01-21 Thread Anup Khadka
1:27PM -0800, Ben Pfaff wrote: > > The OF1.2 feature was based on an Open vSwitch extension to OpenFlow > > first implemented for OF1.0. We need to continue supporting that > > extension. > > > > On Tue, Jan 20, 2015 at 05:12:30PM -0500, Anup Khadka wrote: > > &g

Re: [ovs-discuss] Rejecting flow-mod from a slave controller

2015-01-20 Thread Anup Khadka
I can create a patch for this if you want me to. Thank you, Anup On Tue, Jan 20, 2015 at 5:12 PM, Anup Khadka wrote: > Do OpenFlow versions prior to OF 1.2 even support the concept of slave > controllers? I couldn't find anything in the specs. > > On Tue, Jan 20, 2015 at 4

Re: [ovs-discuss] Rejecting flow-mod from a slave controller

2015-01-20 Thread Anup Khadka
Do OpenFlow versions prior to OF 1.2 even support the concept of slave controllers? I couldn't find anything in the specs. On Tue, Jan 20, 2015 at 4:24 PM, Ben Pfaff wrote: > On Tue, Jan 20, 2015 at 03:55:57PM -0500, Anup Khadka wrote: > > I have noticed that OVS rejects flow-mod

[ovs-discuss] Rejecting flow-mod from a slave controller

2015-01-20 Thread Anup Khadka
Hello, I have noticed that OVS rejects flow-mod request from a slave-controller with an OFPBRC_EPERM request code. Isn't the more appropriate code here is: OFPBRC_IS_SLAVE? Same thing when a slave controller sends a packet out. Thanks, Anup ___ discuss

[ovs-discuss] CHECK_OVERLAP and identical flows

2015-01-06 Thread Anup Khadka
Hi, during an add-flow request with CHECK_OVERLAP set, if an identical flow exists in the table, what should be the expected behavior? Should we reject it and send an error with OFPFMFC_OVERLAP code back to the controller? The current OVS code transforms add to modify if there is an existing iden

Re: [ovs-discuss] next OVS release?

2014-11-03 Thread Anup Khadka
Ben, please see inline. > On Mon, Nov 03, 2014 at 04:17:09PM -0500, Anup Khadka wrote: > > Is there a tentative timeline on the next official OVS release? > > I don't know what it was. > I wanted to ask if there were any plans to release an official OVS release anytime soon

[ovs-discuss] next OVS release?

2014-11-03 Thread Anup Khadka
Hi OVS team, Is there a tentative timeline on the next official OVS release? Looks like table features support (read-only) was added post 2.3 official release. The OVS FAQ page seems to indicate full support for OpenFlow 1.3 in OVS 2.3. Is that not correct? Thanks, Anup ___

Re: [ovs-discuss] group stats bit in capabilities inside OFPT_FEATURES_REPLY

2014-10-20 Thread Anup Khadka
: case OFP12_VERSION: case OFP13_VERSION: features.capabilities |= OFPUTIL_C_GROUP_STATS; default: break; } #endif On Mon, Oct 20, 2014 at 3:25 PM, Anup Khadka wrote: > Seeing this in OVS 2.1 encounter (but looks like the code is same now too) > >

[ovs-discuss] Make ovs locks no-op

2014-10-20 Thread Anup Khadka
I am interested to know if there is a simple way to make the OVS lock functions (ovs_mutex_lock, etc.) essentially no-ops. Thank you, Anup ___ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss

[ovs-discuss] group stats bit in capabilities inside OFPT_FEATURES_REPLY

2014-10-20 Thread Anup Khadka
Seeing this in OVS 2.1 encounter (but looks like the code is same now too) The group stats bit is set to false in capabilities inside OFPT_FEATURES_REPLY. Is there a reason why that's done, despite the fact that there is already support for group stats? Looking at the git source right now (funct

Re: [ovs-discuss] unixctl module question

2014-10-09 Thread Anup Khadka
Thank you. That's helpful. -Anup On Wed, Oct 8, 2014 at 5:24 PM, Justin Pettit wrote: > The "ovs-appctl" command can execute them. When you run "ovs-appctl > help", you should see the names that you register. > > --Justin > > > On Octo

[ovs-discuss] unixctl module question

2014-10-08 Thread Anup Khadka
I am trying to understand the unixctl module. More specifically how/when can an ofproto class make use of some of its functions. I was wondering if I can get some pointers or direction. Assuming that I register a command with a name and provide a callback during registration, who and when will thi

Re: [ovs-discuss] Possible double-free on ofproto.c:delete_flows_loose

2014-09-17 Thread Anup Khadka
essage, the bug could not cause a real problem > in practice. Do you see a way that it could? > > On Wed, Sep 17, 2014 at 04:50:04PM -0400, Anup Khadka wrote: > > Looks like this code was added in July: > > https://github.com/openvswitch/ovs/commit/bfd3dbf6a0c978ceb20faf292bca

Re: [ovs-discuss] Possible double-free on ofproto.c:delete_flows_loose

2014-09-17 Thread Anup Khadka
Looks like this code was added in July: https://github.com/openvswitch/ovs/commit/bfd3dbf6a0c978ceb20faf292bca51 3a63e2b68c I was using an older code-base. Thanks, Anup On Wed, Sep 17, 2014 at 4:37 PM, Ben Pfaff wrote: > On Wed, Sep 17, 2014 at 02:58:50PM -0400, Anup Khadka wrote: > &g

Re: [ovs-discuss] Possible double-free on ofproto.c:delete_flows_loose

2014-09-17 Thread Anup Khadka
On Tue, Sep 16, 2014 at 3:30 PM, Anup Khadka wrote: > It looks like OVS tries to double-free in delete_flows_loose if the > rules->rules (inside struct rule_collection *rules is not equal to > rules->stub). > > A little more detail: > In the function delete_flows_loose,

[ovs-discuss] Support for handling table features stats request

2014-08-04 Thread Anup Khadka
Hello, Is there any plan to support handling table features stats request message in near future? Thank you, Anup ___ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss

Re: [ovs-discuss] Hello version 0

2014-07-24 Thread Anup Khadka
rote: > On Wed, Jul 23, 2014 at 07:59:10PM -0400, Anup Khadka wrote: > > If OVS receives a Hello packet with version set to 0, it logs an error > > "received message while expecting hello" and change's vconn's state > without > > sending any message back

Re: [ovs-discuss] Hello version 0

2014-07-23 Thread Anup Khadka
at 7:59 PM, Anup Khadka wrote: > If OVS receives a Hello packet with version set to 0, it logs an error > "received message while expecting hello" and change's vconn's state without > sending any message back to the controller. > > Is this a desired behavi

[ovs-discuss] Hello version 0

2014-07-23 Thread Anup Khadka
If OVS receives a Hello packet with version set to 0, it logs an error "received message while expecting hello" and change's vconn's state without sending any message back to the controller. Is this a desired behavior? The standard isn't really clear on how to process a Hello packet with version =

[ovs-discuss] Possible bug in OVS during controller role change

2014-07-22 Thread Anup Khadka
According to OpenFlow spec v.1.3.3 - "When a controller changes its role to OFPCR_ROLE_MASTER, the switch changes all other controllers with the role OFPCR_ROLE_MASTER to have the role OFPCR_ROLE_SLAVE, but does not affect controllers with role OFPCR_ROLE_EQUAL. When the switch performs such role c