[ovs-discuss] conntrack marks in ovs not showing up

2015-09-15 Thread Ben Warren
Hi, I’m working off Justin Pettit’s ‘conntrack’ tree @ https://github.com/justinpettit/ovs/tree/conntrack, and can’t seem to get marks to work. Here’s an example of a flow (FTP server) === ovs-ofctl add-flow br0 "table=3,cookie=0xb0b,priority=32000,ct_state=+new+trk,tcp,tp_dst=21 actions=ct(

Re: [ovs-discuss] tnl arp causes infinite reentrant stack death.

2015-09-15 Thread David Evans
Wow. - Thanks so much Jesse, I will try this with a fresh coffee in the morning @ the office in the morning. it's 11pm now. - can't think straight anymore.. :) On Tue, Sep 15, 2015 at 10:54 PM, Jesse Gross wrote: > On Tue, Sep 15, 2015 at 7:38 PM, David Evans > wrote: > > Thanks Jesse! > > I th

Re: [ovs-discuss] tnl arp causes infinite reentrant stack death.

2015-09-15 Thread Jesse Gross
On Tue, Sep 15, 2015 at 7:38 PM, David Evans wrote: > Thanks Jesse! > I think you may be close, but it is the ovs code that is re-entering it's > self, this isn't an arp storm from a circle of traffic path, as far as i can > tell. it is an attempt to transmit a single packet.. but never gets even

Re: [ovs-discuss] way to speak with OpenFlow module

2015-09-15 Thread Xiao Liang (xiaolia)
Hi Minh, Controller could query existing flows before adding. I’m not clear why you need to do this. Ovs-ofctl has no impact as long as you don’t use it. You can remove the mgmt socket (/var/run/openvswitch/.mgmt) if you really want. Thanks, Xiao From: Minh Nghiem Gia [mailto:nghiem.gia.m...@g

Re: [ovs-discuss] tnl arp causes infinite reentrant stack death.

2015-09-15 Thread David Evans
Thanks Jesse! I think you may be close, but it is the ovs code that is re-entering it's self, this isn't an arp storm from a circle of traffic path, as far as i can tell. it is an attempt to transmit a single packet.. but never gets even the arp out to the stack at all. you can see build_tunnel_sen

Re: [ovs-discuss] tnl arp causes infinite reentrant stack death.

2015-09-15 Thread Jesse Gross
On Mon, Sep 14, 2015 at 9:57 PM, David Evans wrote: > Hi OVS. > > i am using rev 2.3.2+29bae5412ea3c6a1e20d79afd25c11b968dffa05-r0 > > As you can see from my gdb backtrace 13K frames deep below we get an arp > request because build_tunnel_send (frame 13659 below) decided we're starting > to use a

Re: [ovs-discuss] Assignment is done from int->short

2015-09-15 Thread Ben Pfaff
On Wed, Sep 16, 2015 at 01:38:36AM +0530, neeraj mehta wrote: > I was looking a the code in multipath.c file. In function algorithm_hrw( ) > assignment is done from int->short (best_link = link). It might lead to > bit truncation. Following is the code snippet for your reference. > > uint32_t best

[ovs-discuss] Assignment is done from int->short

2015-09-15 Thread neeraj mehta
Hi Team, I was looking a the code in multipath.c file. In function algorithm_hrw( ) assignment is done from int->short (best_link = link). It might lead to bit truncation. Following is the code snippet for your reference. uint32_t best_weight; uint16_t best_link; unsigned int link; b

Re: [ovs-discuss] No check for memory allocation from malloc()

2015-09-15 Thread Neil McKee
In OVS a callback fn is given to the sFlow library for all allocation, but the callback (ofproto/ofproto-dpif-sflow.c:sflow_agent_alloc_cb()) just calls "calloc()" too. This should probably be changed to xcalloc() as defined in lib/util.c which does the right thing. Thanks for pointing this out

[ovs-discuss] No check for memory allocation from malloc()

2015-09-15 Thread neeraj mehta
Hi Team, I was looking a the code in sfow_agent.c file in sflAlloc( ) function. This funtion allocates memory via malloc but didn't check whether memory allocation is successful or not. I think there should be a check, in case malloc fails to allocate memory. Regards Neeraj __

[ovs-discuss] Input argument to atoi

2015-09-15 Thread neeraj mehta
Hi Team, I was looking a the code in learn.c file. As per my understanding atoi function take const char * as an input argument. but in the below snippet value is passed as argument which is char *. } else if (!strcmp(name, "priority")) { learn->priority = atoi(value); } else

Re: [ovs-discuss] Event or Action based on counter

2015-09-15 Thread Ben Pfaff
On Tue, Sep 15, 2015 at 05:55:29PM +0100, Pedro Maia wrote: > I’ve searched in the documentation but i was unable to find a way to > execute some action on a packet or generate a event based on the > counters of, by example, a number of matches of a flow entry, or sent > packets in a switch port.

[ovs-discuss] Event or Action based on counter

2015-09-15 Thread Pedro Maia
Hello, I’ve searched in the documentation but i was unable to find a way to execute some action on a packet or generate a event based on the counters of, by example, a number of matches of a flow entry, or sent packets in a switch port. I’ve seen that in Nicira extended match it is possible to m

Re: [ovs-discuss] way to speak with OpenFlow module

2015-09-15 Thread Minh Nghiem Gia
Hi Xiao, Thank you for your quick response. That means there are several ways to insert OF flows! Then, if I insert OF rules by using ovs-ofctl and by a controller, is there any way to ensure installed rules are not overlap or interfere with the others? Or is there any way to only allow one way to

Re: [ovs-discuss] way to speak with OpenFlow module

2015-09-15 Thread Xiao Liang (xiaolia)
Hi Minh, As far as I know, most controllers will include OpenFlow protocol implementation. They communicate with switches by OpenFlow message. In this way, ovs-ofctl makes no difference, it sends / receives messages via sockets (unix, tcp, etc.). Some controller might also have OVSDB southbound

[ovs-discuss] way to speak with OpenFlow module

2015-09-15 Thread Minh Nghiem Gia
Hello, It is easy to push OpenFlow rules to OVS by using the OVS utility such as ovs-ofctl. Thanks all OVS developers! However, I now want to try that function with a SDN controller and I wonder that does the SDN controller (i.e., pox, nox or floodlight) will call ovs-ofctl to install OF flows or