Re: GtkAction, Plugins and PyGtk

2006-05-14 Thread Robert Staudinger
On 5/14/06, Hans Breuer <[EMAIL PROTECTED]> wrote: [...] Some general remarks, more detailed patch review following. - Apparently you are using a tab width of 4 while 8 is commonly used If anyone could point me to a description of dia's coding style i'd happily adhere to that ("gtk", "gnome",

Re: GtkAction, Plugins and PyGtk

2006-05-14 Thread Hans Breuer
Hi Robert, it seems as if again I wont find the time this weekend to apply your patch to my local tree. So here is some feedback from reading your patch. On 07.05.2006 23:07, Robert Staudinger wrote: On 5/4/06, Robert Staudinger <[EMAIL PROTECTED]> wrote: On 5/3/06, Hans Breuer <[EMAIL PROTECTE

Re: GtkAction, Plugins and PyGtk

2006-05-07 Thread Robert Staudinger
On 5/4/06, Robert Staudinger <[EMAIL PROTECTED]> wrote: On 5/3/06, Hans Breuer <[EMAIL PROTECTED]> wrote: > On 03.05.2006 21:22, Robert Staudinger wrote: [...] > So IMO the way to go would be to change the filter_register_callback() to > something more appropriate to action based menus and chan

Re: GtkAction, Plugins and PyGtk

2006-05-04 Thread Robert Staudinger
On 5/3/06, Hans Breuer <[EMAIL PROTECTED]> wrote: On 03.05.2006 21:22, Robert Staudinger wrote: [...] > + dia to depend on PyGTK or This does not sound like an option. By definition the core must not depend on a plug-in (though there is one plug-in not optional : libstandard) Oh, that wouldn

Re: GtkAction, Plugins and PyGtk

2006-05-03 Thread Hans Breuer
On 03.05.2006 21:22, Robert Staudinger wrote: Hi, tracked in [1] i have been starting to move dia towards use of the GtkUIManager/GtkAction framework instead of the deprecated GtkItemFactory. A first patch for the toolbox is available, but API to add menu items is also exported to the python plu