Re: [PATCH] Highlight color for bright text.

2012-04-28 Thread Hans Breuer
At 27.04.2012 00:25, Paul Chavent wrote: Le 04/26/2012 10:35 PM, Hans Breuer a écrit : At least I am ambivalent if we should replace the one single hard-coded color with just two hard-coded colors. A better idea might be to derive both these colors from the theme as discussed in https://bugzilla

Re: [PATCH] Highlight color for bright text.

2012-04-26 Thread Paul Chavent
Le 04/26/2012 10:35 PM, Hans Breuer a écrit : At least I am ambivalent if we should replace the one single hard-coded color with just two hard-coded colors. A better idea might be to derive both these colors from the theme as discussed in https://bugzilla.gnome.org/show_bug.cgi?id=599447#c3 Do

Re: [PATCH] Highlight color for bright text.

2012-04-26 Thread Hans Breuer
At 25.04.2012 22:13, Paul Chavent wrote: Le 04/24/2012 10:32 PM, Hans Breuer a �crit : [...] If you want also feedback from the user perspective it might help to describe the desired effect rather than just giving an uncommented patch. If I understood your code right it will change the highlig

Re: [PATCH] Highlight color for bright text.

2012-04-25 Thread Paul Chavent
Le 04/24/2012 10:32 PM, Hans Breuer a écrit : At 16.04.2012 07:17, Paul Chavent wrote: Hi. I've posted a patch some weeks ago. I'm surprised to had no reactions. So, i would like to take a second chance. I sometimes draw coloured squares (eg blue) with bright text inside (eg white). When i se

Re: [PATCH] Highlight color for bright text.

2012-04-24 Thread Hans Breuer
At 16.04.2012 07:17, Paul Chavent wrote: Hi. I've posted a patch some weeks ago. I'm surprised to had no reactions. So, i would like to take a second chance. I sometimes draw coloured squares (eg blue) with bright text inside (eg white). When i select this text, i can't see it because the high

Re: [PATCH] Highlight color for bright text.

2012-04-16 Thread Steffen Macke
Hi, Am 04/16/2012 06:22 PM, schrieb Thomas Harding: http://live.gnome.org/Dia/HowToSubmitPatches Notably the "Bugzilla" link (after you has been done reading the guidelines). You can also mail to Steffen Macke (see credits in "about"). Hans is Dia's maintainer, sending patches to me is not a g

Re: [PATCH] Highlight color for bright text.

2012-04-16 Thread Thomas Harding
Le Mon, 16 Apr 2012 07:17:22 +0200, Paul Chavent a écrit : > I've posted a patch some weeks ago. I'm surprised to had no > reactions. So, i would like to take a second chance. Hi Paul, you should take a look at this page: http://live.gnome.org/Dia/HowToSubmitPatches Notably the "Bugzilla" link