Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Rafał Pietrak
Liang, As I said - I was just wondering if you guys ever considered implementation of virtual space for internal KiCAD "guts". But your questions call for explanation, so this is what I mean: 1. current 4m by 4m limitation of KiCAD, if emerging from 32 bit internal dimension representation, m

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Liang Jia
Hi Mark, Yes, you are right, I also found it yesterday. Actually, we tried to discuss two problems in this email. 1. Suitable dxf file but with big coordination, It's already fixed in the latest branch. 2. Let Kicad support a larger board size as other software did. On Tue, 26 Nov 2024 at 22:52,

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Liang Jia
Hi Rafał, Thanks for your reply. I tried to understand what you meant. Is the below assumption correct? 1. Kicad use integer as index without unit, for example, current GUI unit it mm, so all objects in the pcb board with display as mm and saved in file as mm 2. If user change the GUI unit from m

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Mark Roszko
O derp. A fix was applied to deal with out of bounds dxf last week to 8.0 https://gitlab.com/kicad/code/kicad/-/issues/18523 On Tue, Nov 26, 2024, 6:32 AM Rafał Pietrak wrote: > Moja, > > Just explaining: > > there are two sides to this case. The one that you've noticed, when one > uses such f

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Rafał Pietrak
Moja, Just explaining: there are two sides to this case. The one that you've noticed, when one uses such feature to scale up/down the design, which is obviously not the case for PCB artworks. But the other case is the control of the design resolution, which in fact I had in mind. In short: wh

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Mark Roszko
>I think we're missing the point of "what are we trying to fix by fixing dxf importer overflows". >Current implementation just convert them immediately as the library parses the DXF file. This suggestion would result in a complete rewrite of DXF importer but I believe would make DXF importer signi

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Mojca Miklavec
On Tue, 26 Nov 2024 at 06:06, Rafał Pietrak wrote: > > Guys, have you ever considered going to "virtual dimensions"? > > What I mean here is that the entire design (that is the PCB of course, > not the SCH) is based on an integer grid like "natural numbers indices > to locations", while the grid s

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread RigoLigo RLC
Hi all, I think we're missing the point of "what are we trying to fix by fixing dxf importer overflows". The DXF file provided in #12392 has a board that measures 2 meters long so it's still in our representation limits. Issue is that people draw their graphics in whatever CAD program may place t

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Rafał Pietrak
Hi Liang I truly fail to see if those points could be of any problem. You just go from virtual to "physical" (and back again) whenever necessary ... like while presenting "tings" to user (or vice verse when taking user input, or during export/import). The main issue here, is that if KiCAD *in

Re: [kicad] Import DXF cause int overflow

2024-11-26 Thread Liang Jia
Hi Rafał, Thanks for your reply. > Guys, have you ever considered going to "virtual dimensions"? I think it's not doable. Because you need to show the same thing with different units when using pcb editor. For example: 1. Users want to change the display unit from one to another. 2. Imported dxf