[Devel] Re: [PATCH] netns: Coexist with the sysfs limitations v2

2008-10-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 23 Oct 2008 08:56:08 -0700 > To make testing of the network namespace simpler allow > the network namespace code and the sysfs code to be > compiled and run at the same time. To do this only > virtual devices are allowed in the additional net

[Devel] Re: [PATCH] netns: Coexist with the sysfs limitations v2

2008-10-27 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Mon, 27 Oct 2008 13:19:27 -0700 > What I was thinking is that it goes into your tree for 2.6.29. Allowing > for better test coverage in the short term, and removing the pressure > to do a hack job on sysfs just to reduce the pain of testing. Fair

[Devel] Re: [PATCH 2/3] net: Guaranetee the proper ordering of the loopback device.

2008-11-05 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 05 Nov 2008 15:25:39 -0800 > > I was recently hunting a bug that occurred in network namespace > cleanup. In looking at the code it became apparrent that we have > and will continue to have cases where if we have anything going > on in a net

[Devel] Re: [PATCH 3/3] net: Don't leak packets when a netns is going down

2008-11-05 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 05 Nov 2008 15:27:34 -0800 > > I have been tracking for a while a case where when the > network namespace exits the cleanup gets stck in an > endless precessess of: > > unregister_netdevice: waiting for lo to become free. Usage count = 3 > u

[Devel] Re: [PATCH 1/3] netns: Delete virtual interfaces during namespace cleanup

2008-11-05 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 05 Nov 2008 15:22:26 -0800 > > When physical devices are inside of network namespace and that > network namespace terminates we can not make them go away. We > have to keep them and moving them to the initial network namespace > is the best

[Devel] Re: [PATCH 2/3] net: Guaranetee the proper ordering of the loopback device.

2008-11-07 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 06 Nov 2008 05:02:33 -0800 > Dave can you please drop this one for the moment. > > I cleaned up my patch after the basic testing was over and the > result is a kernel that won't boot. So if we can prevent this > patch from spreading and brea

[Devel] Re: [PATCH 1/2] net: fib_rules ordering fixes.

2008-11-07 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 06 Nov 2008 07:34:28 -0800 > > We need to setup the network namespace state before we register > the notifier. Otherwise if a network device is already registered > we get a nasty NULL pointer dereference. > > Signed-off-by: Eric W. Biederm

[Devel] Re: [PATCH 2/2] net: Guaranetee the proper ordering of the loopback device. v2

2008-11-07 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 06 Nov 2008 07:36:00 -0800 > I was recently hunting a bug that occurred in network namespace > cleanup. In looking at the code it became apparrent that we have > and will continue to have cases where if we have anything going > on in a networ

[Devel] Re: [patch 1/1] netns: filter out uevent not belonging to init_net

2008-11-25 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Tue, 25 Nov 2008 09:40:59 -0800 > Daniel Lezcano <[EMAIL PROTECTED]> writes: > > > This patch will filter out the uevent not related to the init_net. > > Without this patch if a network device is created in a network > > namespace with the same na

[Devel] Re: [PATCH 01/53] xfrm: initialise xfrm_policy_gc_work statically

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:33 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 02/53] netns xfrm: add netns boilerplate

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:34 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 03/53] netns xfrm: add struct xfrm_state::xs_net

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:35 +0300 > To avoid unnecessary complications with passing netns around. > > * set once, very early after allocating > * once set, never changes > > For a while create every xfrm_state in init_net. > > Signed-off-by: Alexey

[Devel] Re: [PATCH 04/53] netns xfrm: per-netns xfrm_state_all list

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:36 +0300 > This is done to get > a) simple "something leaked" check > b) cover possible DoSes when other netns puts many, many xfrm_states >onto a list. > c) not miss "alien xfrm_state" check in some of list iterators in fu

[Devel] Re: [PATCH 05/53] netns xfrm: per-netns xfrm_state_bydst hash

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:37 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 07/53] netns xfrm: per-netns xfrm_state_byspi hash

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:39 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 10/53] netns xfrm: per-netns xfrm_hash_work

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:42 +0300 > All of this is implicit passing which netns's hashes should be resized. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL

[Devel] Re: [PATCH 08/53] netns xfrm: per-netns xfrm_state_hmask

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:40 +0300 > Since hashtables are per-netns, they can be independently resized. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROT

[Devel] Re: [PATCH 06/53] netns xfrm: per-netns xfrm_state_bysrc hash

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:38 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 09/53] netns xfrm: per-netns xfrm_state counts

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:41 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 13/53] netns xfrm: per-netns km_waitq

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:45 +0300 > Dissalow spurious wakeups in __xfrm_lookup(). typo, which I fixed... > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. ___ Containers mail

[Devel] Re: [PATCH 11/53] netns xfrm: per-netns state GC list

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:43 +0300 > km_waitq is going to be made per-netns to disallow spurious wakeups > in __xfrm_lookup(). > > To not wakeup after every garbage-collected xfrm_state (which potentially > can be from different netns) make state GC li

[Devel] Re: [PATCH 14/53] netns xfrm: add struct xfrm_policy::xp_net

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:46 +0300 > Again, to avoid complications with passing netns when not necessary. > Again, ->xp_net is set-once field, once set it never changes. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. _

[Devel] Re: [PATCH 12/53] netns xfrm: per-netns state GC work

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:44 +0300 > State GC is per-netns, and this is part of it. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists

[Devel] Re: [PATCH 15/53] netns xfrm: per-netns policy list

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:47 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/conta

[Devel] Re: [PATCH 17/53] netns xfrm: per-netns xfrm_policy_byidx hashmask

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:49 +0300 > Per-netns hashes are independently resizeable. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists

[Devel] Re: [PATCH 19/53] netns xfrm: per-netns xfrm_policy_bydst hash

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:51 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 20/53] netns xfrm: per-netns policy counts

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:52 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 21/53] netns xfrm: per-netns policy hash resizing work

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:53 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 22/53] netns xfrm: propagate netns into bydst/bysrc/byspi hash functions

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:54 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 23/53] netns xfrm: trivial netns propagations

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:55 +0300 > Take netns from xfrm_state or xfrm_policy. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.lin

[Devel] Re: [PATCH 24/53] netns xfrm: state flush in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:56 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 18/53] netns xfrm: per-netns inexact policies

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:50 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 16/53] netns xfrm: per-netns xfrm_policy_byidx hash

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:48 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 25/53] netns xfrm: state lookup in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:57 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 26/53] netns xfrm: fixup xfrm_alloc_spi()

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:58 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 27/53] netns xfrm: finding states in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:26:59 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 28/53] netns xfrm: state walking in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:00 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 31/53] netns xfrm: policy flushing in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:03 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 29/53] netns xfrm: propagate netns into policy byidx hash

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:01 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 30/53] netns xfrm: policy insertion in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:02 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 33/53] netns xfrm: policy walking in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:05 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 34/53] netns xfrm: lookup in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:06 +0300 > Pass netns to xfrm_lookup()/__xfrm_lookup(). For that pass netns > to flow_cache_lookup() and resolver callback. > > Take it from socket or netdevice. Stub DECnet to init_net. > > Signed-off-by: Alexey Dobriyan <[E

[Devel] Re: [PATCH 32/53] netns xfrm: finding policy in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:04 +0300 > Add netns parameter to xfrm_policy_bysel_ctx(), xfrm_policy_byidx(). > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PR

[Devel] Re: [PATCH 36/53] netns xfrm: xfrm_route_forward() in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:08 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 35/53] netns xfrm: xfrm_policy_check in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:07 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 40/53] netns xfrm: per-netns NETLINK_XFRM socket

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:12 +0300 > Stub senders to init_net's one temporarily. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.li

[Devel] Re: [PATCH 39/53] netns xfrm: xfrm_input() fixup

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:11 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 37/53] netns xfrm: flushing/pruning bundles in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:09 +0300 > Allow netdevice notifier as result. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foun

[Devel] Re: [PATCH 38/53] netns xfrm: dst garbage-collecting in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:10 +0300 > Pass netns pointer to struct xfrm_policy_afinfo::garbage_collect() > > [This needs more thoughts on what to do with dst_ops] > [Currently stub to init_net] Yes, this dst_ops issue has been brought up a

[Devel] Re: [PATCH 41/53] netns xfrm: xfrm_user module in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:13 +0300 > Grab netns either from netlink socket, state or policy. > > SA and SPD flush are in init_net for now, this requires little > attention, see below. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. _

[Devel] Re: [PATCH 42/53] netns xfrm: pass netns with KM notifications

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:14 +0300 > SA and SPD flush are executed with NULL SA and SPD respectively, for > these cases pass netns explicitly from userspace socket. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. __

[Devel] Re: [PATCH 43/53] netns xfrm: KM reporting in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:15 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 44/53] netns xfrm: ->dst_lookup in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:16 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 45/53] netns xfrm: ->get_saddr in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:17 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 46/53] netns xfrm: flush SA/SPDs on netns stop

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:18 +0300 > SA/SPD doesn't pin netns (and it shouldn't), so get rid of them by hand. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAI

[Devel] Re: [PATCH 47/53] netns PF_KEY: part 1

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:19 +0300 > * netns boilerplate > * keep per-netns socket list > * keep per-netns number of sockets > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mai

[Devel] Re: [PATCH 49/53] netns PF_KEY: per-netns /proc/pfkey

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:21 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 48/53] netns PF_KEY: part 2

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:20 +0300 > * interaction with userspace -- take netns from userspace socket. > * in ->notify hook take netns either from SA or explicitly passed -- > we don't know if SA/SPD flush is coming. > * stub policy migration with

[Devel] Re: [PATCH 52/53] netns xfrm: /proc/net/xfrm_stat in netns

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:24 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 53/53] netns xfrm: per-netns sysctls

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:25 +0300 > Make > net.core.xfrm_aevent_etime > net.core.xfrm_acq_expires > net.core.xfrm_aevent_rseqth > net.core.xfrm_larval_drop > > sysctls per-netns. > > For that make net_core_path[] global, regis

[Devel] Re: [PATCH 51/53] netns xfrm: per-netns MIBs

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:23 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 50/53] netns xfrm: AH/ESP in netns!

2008-11-25 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Tue, 25 Nov 2008 20:27:22 +0300 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Yahoo! Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/conta

[Devel] Re: [RFC 3/4] net: pppol2tp - introduce net-namespace functionality

2009-01-11 Thread David Miller
From: Cyrill Gorcunov Date: Sat, 10 Jan 2009 15:54:44 +0300 > Maybe you have some other commits which are not propogated > to net-next-2.6 yet? net-next-2.6 is a throw away tree that is a clone of essentially 2.6.28 after Linus first took the net-next-2.6 It has not been updated for weeks, all

[Devel] Re: [RFC 4/4] net: ppp_generic - introduce net-namespace functionality

2009-01-11 Thread David Miller
From: Paul Mackerras Date: Sun, 11 Jan 2009 11:33:21 +1100 > Cyrill Gorcunov writes: > > > From: Cyrill Gorcunov > > Subecjt: [RFC] net: ppp_generic - introduce net-namespace functionality > > > > - Each namespace contain ppp channels and units separately > > with appropriate locks > > This

[Devel] Re: [PATCH 5/5] net: pppoe, pppol2tp - register channels with explicit net

2009-01-20 Thread David Miller
From: Divy Le Ray Date: Tue, 20 Jan 2009 16:09:00 -0800 > For some reason, I see your your mail' date pointing to 12/31/1969. Yes, he knows. It's a quilt hiccup. ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [PATCH 0/5] ppp,pppoe,pppol2tp -- introduce namespace functionality v2

2009-01-21 Thread David Miller
From: Cyrill Gorcunov Date: Tue, 20 Jan 2009 17:05:10 +0300 > Hi, here is a series of patches in hope to bring > net-namespace functionality for PPP, PPPoE, PPPoL2TP > protocols. All applied, thanks Cyrill. ___ Devel mailing list Devel@openvz.org http

[Devel] Re: [PATCH 2/3] tcp: Like icmp use register_pernet_subsys

2009-02-22 Thread David Miller
From: "Denis V. Lunev" Date: Fri, 20 Feb 2009 18:57:23 +0300 > Acked-by: Denis V. Lunev Applied. ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [PATCH 1/3] netns: Fix icmp shutdown.

2009-02-22 Thread David Miller
From: "Denis V. Lunev" Date: Fri, 20 Feb 2009 18:57:02 +0300 > Acked-by: Denis V. Lunev Applied. ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [PATCH 3/3] netns: Remove net_alive

2009-02-22 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 20 Feb 2009 08:02:57 -0800 > > It turns out that net_alive is unnecessary, and the original problem > that led to it being added was simply that the icmp code thought > it was a network device and wound up being unable to handle packets >

[Devel] Re: [PATCH 2/2] veth: Configurable nterface MTU

2009-02-27 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Wed, 25 Feb 2009 21:49:04 -0800 > @@ -249,6 +253,19 @@ static int veth_close(struct net_device *dev) > return 0; > } > > +static int is_valid_veth_mtu(int new_mtu) > +{ > + return (new_mtu >= MIN_MTU && new_mtu <= MAX_MTU); > +} >

[Devel] Re: [PATCH 2/2] veth: Configurable nterface MTU

2009-02-27 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 27 Feb 2009 04:41:48 -0800 > David Miller writes: > > > From: ebied...@xmission.com (Eric W. Biederman) > > Date: Wed, 25 Feb 2009 21:49:04 -0800 > > > >> @@ -249,6 +253,19 @@ static int veth_close(struc

[Devel] Re: [PATCH 1/2] veth: Fix carrier detect

2009-03-01 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Wed, 25 Feb 2009 21:47:29 -0800 > > The current implementation of carrier detect in veth is broken. > It reports the link is down until both sides of the veth pair > are administatively up and then forever after it reports link up. > > So fix

[Devel] Re: [PATCH 0/3] Fix Network namespace shutdown take 2

2009-03-03 Thread David Miller
From: Daniel Lezcano Date: Wed, 25 Feb 2009 13:43:29 +0100 > I don't see these patches in the net-2.6 tree. Shouldn't they be in > net-2.6 too ? Ok, I'll think about cherry picking them into net-2.6... ___ Containers mailing list contain...@lists.linux

[Devel] Re: [PATCH] veth: Allow setting the L3 MTU

2009-03-03 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Tue, 03 Mar 2009 20:14:18 -0800 > The limitation to only 1500 byte mtu's limits the utility of the veth > device for testing routing. So implement implement a configurable > MTU. > > For consistency I drop packets on the receive side when the

[Devel] Re: [PATCH 1/2] netns 1/2: don't get/put old netns on CLONE_NEWNET

2009-05-04 Thread David Miller
From: Alexey Dobriyan Date: Mon, 4 May 2009 03:28:25 +0400 > copy_net_ns() doesn't copy anything, it creates fresh netns, so get/put of old > netns isn't needed. > > Signed-off-by: Alexey Dobriyan > Acked-by: Serge Hallyn Applied to net-next-2.6 ___

[Devel] Re: [PATCH][INET]: Fix accidentally broken inet(6)_hash_connect's port offset calculations.

2008-02-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 04 Feb 2008 11:10:37 +0300 > The port offset calculations depend on the protocol family, but, > as Adrian noticed, I broke this logic with the commit > > 5ee31fc1ecdcbc234c8c56dcacef87c8e09909d8 > [INET]: Consolidate inet(6)_hash_co

[Devel] Re: [PATCH] [IPV4]: Formatting fix for /proc/net/fib_trie.

2008-02-05 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 5 Feb 2008 12:58:56 +0300 > The line in the /proc/net/fib_trie for route with TOS specified > - has extra \n at the end > - does not have a space after route scope > like below. >|-- 1.1.1.1 > /32 universe UNICASTtos

[Devel] Re: [PATCH 0/17] Finish IPv4 infrastructure namespacing

2008-02-06 Thread David Miller
What part of "no new features" did you not understand? ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [PATCH] [IGMP]: Optimize kfree_skb in igmp_rcv.

2008-02-09 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 8 Feb 2008 17:14:17 +0300 > Merge error paths inside igmp_rcv. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Applied, but this kind of cleanup is borderline during this time period. Please queue such things up for when I open up net

[Devel] Re: [PATCH] [IPV6]: dst_entry leak in ip4ip6_err. (resend)

2008-02-18 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Mon, 18 Feb 2008 11:59:38 +0300 > The result of the ip_route_output is not assigned to skb. This means that > - it is leaked > - possible OOPS below dereferrencing skb->dst > - no ICMP message for this case > > Signed-off-by: Denis V. Lunev <[EMAIL

[Devel] Re: [PATCH] [NETNS]: Namespace leak in pneigh_lookup.

2008-02-20 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 16:12:38 +0300 > release_net is missed on the error path in pneigh_lookup. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Applied, thanks a lot. ___ Devel mailing list Devel@open

[Devel] Re: [PATCH][NEIGH]: Fix race between neighbor lookup and table's hash_rnd update.

2008-02-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 22 Feb 2008 12:37:03 +0300 > The neigh_hash_grow() may update the tbl->hash_rnd value, which > is used in all tbl->hash callbacks to calculate the hashval. > > Two lookup routines may race with this, since they call the > ->hash callback with

[Devel] Re: [PATCH] Don't limit the number of tunnels with generic name explicitly.

2008-02-23 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 21 Feb 2008 15:38:16 +0300 > Changelog: > > Use the added dev_alloc_name() call to create tunnel device name, > rather than iterate in a hand-made loop with an artificial limit. > > Thanks Patrick for noticing this. > > Signed-off-by: Pavel E

[Devel] Re: [PATCH] Don't limit the number of tunnels with generic name explicitly.

2008-02-26 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 26 Feb 2008 10:47:44 +0300 > That's because you skipped the first patch titled "Don't create > tunnels with '%' in name.", which adds the dev_alloc_name() call > and tosses the error paths a bit. Without this first patch, these > four drivers

[Devel] Re: [PATCH (resend)] Don't create tunnels with '%' in name.

2008-02-26 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 27 Feb 2008 10:44:33 +0300 > Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can > receive a pre-defined name for a device from the userspace. > Since these drivers call the register_netdevice() (rtnl_lock, > is held), which does _not_ ge

[Devel] Re: [PATCH 0/17] Finish IPv4 infrastructure namespacing.

2008-02-28 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 10:28:36 +0300 > This set finally allows to manipulate with network devices inside a > namespace and allows to configure them [via netlink]. 'route' is not yet > supported (but prepared to) as it requires a socket. > > Additionally

[Devel] Re: [PATCH 9/12 net-2.6.26] [NETNS]: icmp(v6)_sk should not pin a namespace.

2008-02-29 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 29 Feb 2008 16:40:55 +0300 > So, change icmp(v6)_sk creation/disposal to the scheme used in the netlink > for rtnl, i.e. create a socket in the context of the init_net and > assign the namespace without getting a referrence later. > > Also use

[Devel] Re: [PATCH 12/12 net-2.6.26] [ICMP6]: Consolidate fail path icmpv6_sk_init with icmpv6_sk_exit.

2008-02-29 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 29 Feb 2008 16:40:58 +0300 > +static void __net_exit icmpv6_sk_exit(struct net *net) > +{ Since you call this from __new_init code, won't this create a section conflict when ipv6 is built statically into the kernel? ___

[Devel] Re: [PATCH 0/12 net-2.6.26] icmp_socket namespacing

2008-02-29 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 29 Feb 2008 16:39:20 +0300 > This set of patches is targeted to create separate icmp_socket inside > each namespace. Both IPv4 and IPv6 codepaths are affected. > > Though, in order to do this smoothly, a bit of optimisations are > performed. T

[Devel] Re: Purpose of __net_exit & friends

2008-02-29 Thread David Miller
From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Fri, 29 Feb 2008 21:12:47 +0100 > On Fri, Feb 29, 2008 at 11:23:42AM -0800, David Miller wrote: > > From: "Denis V. Lunev" <[EMAIL PROTECTED]> > > Date: Fri, 29 Feb 2008 16:40:58 +0300 > > > > > +s

[Devel] Re: [PATCH 12/12 net-2.6.26] [ICMP6]: Consolidate fail path icmpv6_sk_init with icmpv6_sk_exit.

2008-02-29 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Sat, 01 Mar 2008 01:05:41 +0300 > Though, I have made a similar mistake in the IPv4 code. Pls consider > the patch attached. Applied and pushed out to net-2.6.26, thanks. ___ Containers mailing list [EMAI

[Devel] Re: [PATCH 1/3] [IPV6]: Event type in addrconf_ifdown is mis-used.

2008-03-22 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 18 Mar 2008 17:35:23 +0300 > addrconf_ifdown is broken in respect to the usage of how parameter. This > function is called with (event != NETDEV_DOWN) and (2) on the IPv6 stop. > It the latter case inet6_dev from loopback device should be destr

[Devel] Re: [PATCH 1/3] [IPV6]: Event type in addrconf_ifdown is mis-used.

2008-03-23 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Sun, 23 Mar 2008 11:13:16 +0300 > First, this behaviour is broken for a namespace right now in the 2.6.26 > tree. inet6_dev pointer will be NULL for a loopback inside the > namespace. The case is simple. Just remove all INET6 addresses from a > loop

[Devel] Re: [PATCH 1/3] [IPV6]: Event type in addrconf_ifdown is mis-used.

2008-03-23 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Sun, 23 Mar 2008 17:34:59 +0300 > You are perfectly correct and the place in addrconf_cleanup is that > place when we believe that we should destroy all the staff. > > You see, it is pretty useless to call addrconf_ifdown(dev, 2) after > addrconf_d

[Devel] Re: [PATCH net-2.6.26 1/5][NETNS][UDP]: Register /proc/net/udp in a namespace.

2008-03-24 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 24 Mar 2008 13:46:58 +0300 > After the commit a91275eff43a527e1a25d6d034cbcd19ee323e64 ([NETNS][IPV6] > udp - make proc handle the network namespace) it is now possible to make > this file present in newly created namespaces. > > Signed-off-by:

[Devel] Re: [PATCH net-2.6.26 3/5][UDP-Lite]: Clean up proc creation a bit.

2008-03-24 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 24 Mar 2008 13:50:30 +0300 > Just introduce a helper to remove ifdefs from inside the > udplite4_register function. This will help to make the next > patch nicer. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. ___

[Devel] Re: [PATCH net-2.6.26 2/5][NETNS][TCP]: Register /proc/net/tcp in a namespace.

2008-03-24 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 24 Mar 2008 13:48:54 +0300 > After the commit f40c8174d3c21bf178283f3ef3aa8c7bf238fdec ([NETNS][IPV4] > tcp - make proc handle the network namespaces) it is now possible to make > this file present in newly created namespaces. > > Signed-off-b

[Devel] Re: [PATCH net-2.6.26 4/5][NETNS][UDP-Lite]: Register /proc/net/udplite(6) in a namespace.

2008-03-24 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 24 Mar 2008 13:53:01 +0300 > UDP-Lite sockets are displayed in another files, rather than > UDP ones, so make the present in namespaces as well. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. _

[Devel] Re: [PATCH net-2.6.26 5/5][NETNS]: Minor information leak via /proc/net/ptype file.

2008-03-24 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 24 Mar 2008 13:55:09 +0300 > This file displays the registered packet types, but some of them > (packet sockets creates such) can be bound to a net device and > showing them in a wrong namespace is not correct. > > Signed-off-by: Pavel Emelyano

[Devel] Re: [PATCH 0/11 net-2.6.26] UDP/ICMP/TCP for a namespace

2008-03-24 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Mon, 24 Mar 2008 17:33:05 +0300 > This patch set finally enables TCP/UDP and ICMP inside a namespace. > In order to do this we fix ARP processing, IP options processing and > allow packets to flow to namespace aware protocols. > > Finally, this mak

  1   2   3   4   5   6   >