Re: [Devel] [PATCH vz7 v2] net: neigh: decrement the family specific qlen

2024-01-16 Thread Alexander Atanasov
On 16.01.24 9:52, Pavel Tikhomirov wrote: On 16/01/2024 15:10, Alexander Atanasov wrote: On 16.01.24 5:12, Pavel Tikhomirov wrote: I'd prefer to have two separate clean patches ported instead of porting a merge of one into another (without a change explaining comment). commit 8207f253a097f

Re: [Devel] [PATCH VZ9 2/3] net: zerocopy over unix sockets

2024-01-16 Thread Alexey Kuznetsov
Hello! On Tue, Jan 16, 2024 at 1:13 PM Pavel Tikhomirov wrote: > > --- a/net/core/sock.c > > +++ b/net/core/sock.c > > @@ -1405,6 +1405,9 @@ int sk_setsockopt(struct sock *sk, int level, int > > optname, > > (sk->sk_type == SOCK_DGRAM && > >

[Devel] [PATCH vz7 v3 1/2] net, neigh: Fix null-ptr-deref in neigh_table_clear()

2024-01-16 Thread Alexander Atanasov
From: Chen Zhongjin When IPv6 module gets initialized but hits an error in the middle, kenel panic with: KASAN: null-ptr-deref in range [0x0598-0x059f] CPU: 1 PID: 361 Comm: insmod Hardware name: QEMU Standard PC (i440FX + PIIX, 1996) RIP: 0010:__neigh_ifdown.isra.0+0x24b

[Devel] [PATCH vz7 v3 2/2] net: neigh: decrement the family specific qlen

2024-01-16 Thread Alexander Atanasov
From: Thomas Zeitlhofer Commit 0ff4eb3d5ebb ("neighbour: make proxy_queue.qlen limit per-device") introduced the length counter qlen in struct neigh_parms. There are separate neigh_parms instances for IPv4/ARP and IPv6/ND, and while the family specific qlen is incremented in pneigh_enqueue(), the

Re: [Devel] [PATCH VZ9 2/3] net: zerocopy over unix sockets

2024-01-16 Thread Pavel Tikhomirov
On 16/01/2024 19:26, Alexey Kuznetsov wrote: Hello! On Tue, Jan 16, 2024 at 1:13 PM Pavel Tikhomirov wrote: --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1405,6 +1405,9 @@ int sk_setsockopt(struct sock *sk, int level, int optname, (sk->sk_type == SOCK_DGRAM &&

Re: [Devel] [PATCH vz7 v3 1/2] net, neigh: Fix null-ptr-deref in neigh_table_clear()

2024-01-16 Thread Pavel Tikhomirov
(for both patches) Reviewed-by: Pavel Tikhomirov On 17/01/2024 03:31, Alexander Atanasov wrote: From: Chen Zhongjin When IPv6 module gets initialized but hits an error in the middle, kenel panic with: KASAN: null-ptr-deref in range [0x0598-0x059f] CPU: 1 PID: 361 Comm