Re: [Devel] [PATCH vz9 1/2] ve/cgroups: fix use after free in ve_exit_ns

2023-02-01 Thread Pavel Tikhomirov
Nacked-by: Pavel Tikhomirov This is not last reference to ve. Last reference is removed when we remove cgroup directory with rmdir. One cant remove cgroup until there is a process in it. ve_exit_ns is called from task in this ve cgroup. On 30.01.2023 13:00, Alexander Atanasov wrote: Release

[Devel] [PATCH] blk-cbt: Enable interrupts when unlocking in blk_cbt_update_size

2023-02-01 Thread Nikolay Borisov
blk_cbt_update_size uses spin_lock_irq to lock the cbt while pages are being copied and the new cbt is published at q->cbt. This lock is used to synchronize against blk_cbt_release, which can be called within softirq context. This function requires unlocking be done with spin_unlock_irq so that int

Re: [Devel] [PATCH] blk-cbt: Enable interrupts when unlocking in blk_cbt_update_size

2023-02-01 Thread Pavel Tikhomirov
On 01.02.2023 21:22, Nikolay Borisov wrote: blk_cbt_update_size uses spin_lock_irq to lock the cbt while pages are being copied and the new cbt is published at q->cbt. This lock is used to synchronize against blk_cbt_release, which can be called within softirq context. This function requires u

Re: [Devel] [PATCH vz9 1/2] ve/cgroups: fix use after free in ve_exit_ns

2023-02-01 Thread Alexander Atanasov
On 1.02.23 15:06, Pavel Tikhomirov wrote: Nacked-by: Pavel Tikhomirov This is not last reference to ve. Last reference is removed when we remove cgroup directory with rmdir. One cant remove cgroup until there is a process in it. ve_exit_ns is called from task in this ve cgroup. Then should

Re: [Devel] [PATCH vz9 1/2] ve/cgroups: fix use after free in ve_exit_ns

2023-02-01 Thread Pavel Tikhomirov
On 02.02.2023 14:34, Alexander Atanasov wrote: On 1.02.23 15:06, Pavel Tikhomirov wrote: Nacked-by: Pavel Tikhomirov This is not last reference to ve. Last reference is removed when we remove cgroup directory with rmdir. One cant remove cgroup until there is a process in it. ve_exit_ns is

Re: [Devel] [PATCH vz9 1/2] ve/cgroups: fix use after free in ve_exit_ns

2023-02-01 Thread Alexander Atanasov
On 2.02.23 9:21, Pavel Tikhomirov wrote: On 02.02.2023 14:34, Alexander Atanasov wrote: On 1.02.23 15:06, Pavel Tikhomirov wrote: Nacked-by: Pavel Tikhomirov This is not last reference to ve. Last reference is removed when we remove cgroup directory with rmdir. One cant remove cgroup until