[Devel] [PATCH vz9] mm: per memory cgroup page cache limit

2023-01-19 Thread Alexander Atanasov
Forward port feature: mm: per memory cgroup page cache limit. The original implementation consisted of these commits: commit 758d52e33a67 ("configs: Enable CONFIG_PAGE_EXTENSION") commit 741beaa93c89 ("mm: introduce page vz extension (using page_ext)") commit d42d3c8b849d ("mm/memcg: limit page ca

Re: [Devel] [PATCH vz9] mm: per memory cgroup page cache limit

2023-01-19 Thread Konstantin Khorenko
Pasha, please, review the patch. -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team On 19.01.2023 11:51, Alexander Atanasov wrote: Forward port feature: mm: per memory cgroup page cache limit. The original implementation consisted of these commits: commit 758d52e33a67 ("configs

Re: [Devel] [vz7 PATCH 2/2] devcg: Allow wildcard exceptions in DENY child cgroups PSBM-144033

2023-01-19 Thread Pavel Tikhomirov
The patch does not apply please fix. [snorch@turmoil vzkernel-vz7]$ git am -3 ~/Downloads/patches/nborisov/devcg/* Applying: devcg: Move match_exception_partial before match_exception PSBM-144033 Applying: devcg: Allow wildcard exceptions in DENY child cgroups PSBM-144033 Using index info to r

Re: [Devel] [vz7 PATCH 2/2] devcg: Allow wildcard exceptions in DENY child cgroups PSBM-144033

2023-01-19 Thread Pavel Tikhomirov
On 16.12.2022 17:38, Nikolay Borisov wrote: In containerized environments there arise cases where we might want to allow wildcard exceptions when the parent cg doesn't have such. This for example arises when systemd services are being setup in containers. In order to allow systemd to function

Re: [Devel] [vz7 PATCH 1/2] devcg: Move match_exception_partial before match_exception PSBM-144033

2023-01-19 Thread Pavel Tikhomirov
-static bool match_exception(struct list_head *exceptions, short type, - u32 major, u32 minor, short access) +static bool match_exception(struct dev_cgroup *dev_cgroup, short type, + u32 major, u32 minor, short access) Does it compile after

[Devel] [vz7 v2 PATCH 1/2] devcg: Move match_exception_partial before match_exception PSBM-144033

2023-01-19 Thread Nikolay Borisov
This is required as the latter would call the former in upcoming patch. Signed-off-by: Nikolay Borisov --- v2: * Fix compilation breakage * Removed irrelevant changes security/device_cgroup.c | 85 +--- 1 file changed, 44 insertions(+), 41 deletions(-) dif

[Devel] [vz7 v2 PATCH 2/2] devcg: Allow wildcard exceptions in DENY child cgroups

2023-01-19 Thread Nikolay Borisov
In containerized environments there arise cases where we might want to allow wildcard exceptions when the parent cg doesn't have such. This for example arises when systemd services are being setup in containers. In order to allow systemd to function we must allow it to write wildcard (i.e b *:* rwm

Re: [Devel] [PATCH vz9] mm: per memory cgroup page cache limit

2023-01-19 Thread Pavel Tikhomirov
Author should be changed back to Andrey Ryabinin as on rebase we don't change author of the original patch. In general patch looks ok. I feel a bit suspicious about removing WARN_ON in mem_cgroup_migrate, if you can explain why we don't need it it would be nice. See other comments inline:

Re: [Devel] [vz7 v2 PATCH 1/2] devcg: Move match_exception_partial before match_exception PSBM-144033

2023-01-19 Thread Pavel Tikhomirov
Maybe just put a match_exception_partial declaration line above match_exception, to decrease next rebase work with it, also this one-liner could be logically merged to second patch. On 19.01.2023 15:52, Nikolay Borisov wrote: This is required as the latter would call the former in upcoming pat

Re: [Devel] [vz7 v2 PATCH 2/2] devcg: Allow wildcard exceptions in DENY child cgroups

2023-01-19 Thread Pavel Tikhomirov
I believe this is not covering all cases, for instance it would break adding rules to second level nested cgroup, if second level nested cgroup is in "default deny" and it's parent is in "default deny" and none of them have CGRP_VE_ROOT set. In parent there is allowing wildcard rule and adding

Re: [Devel] [vz7 v2 PATCH 2/2] devcg: Allow wildcard exceptions in DENY child cgroups

2023-01-19 Thread nb
On 19.01.23 г. 17:02 ч., Pavel Tikhomirov wrote: I believe this is not covering all cases, for instance it would break adding rules to second level nested cgroup, if second level nested cgroup is in "default deny" and it's parent is in "default deny" and none of them have CGRP_VE_ROOT set. In