[Devel] Re: [PATCH 2/4] Add a __GFP_SLABMEMCG flag

2012-06-09 Thread Glauber Costa
On 06/08/2012 11:31 PM, Christoph Lameter wrote: Please make this conditional on CONFIG_MEMCG or so. The bit can be useful in particular on 32 bit architectures. Looking at how __GFP_NOTRACK works - which is also ifdef'd, the bit it uses is skipped if that is not defined, which I believe is a sa

[Devel] Re: [PATCH 2/4] Add a __GFP_SLABMEMCG flag

2012-06-09 Thread Glauber Costa
On 06/09/2012 04:56 AM, James Bottomley wrote: On Fri, 2012-06-08 at 14:31 -0500, Christoph Lameter wrote: On Fri, 8 Jun 2012, Glauber Costa wrote: */ #define __GFP_NOTRACK_FALSE_POSITIVE (__GFP_NOTRACK) -#define __GFP_BITS_SHIFT 25/* Room for N __GFP_FOO bits */ +#define __GFP_BITS_

[Devel] Re: [PATCH] NFSd: simplify locking in nfsd_recall_delegations()

2012-06-09 Thread Benny Halevy
On 2012-05-22 13:28, Stanislav Kinsbursky wrote: > Holding of client_mutex looks redundant here - holding of recall_lock looks > enough. Looking at the code, agreed. Benny > > Signed-off-by: Stanislav Kinsbursky > --- > fs/nfsd/nfs4state.c |2 -- > 1 files changed, 0 insertions(+), 2 dele

[Devel] Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

2012-06-09 Thread Boaz Harrosh
On 11/29/2011 07:30 PM, Peng Tao wrote: > On Wed, Nov 30, 2011 at 1:19 AM, Trond Myklebust > wrote: >> On Tue, 2011-11-29 at 11:42 -0500, J. Bruce Fields wrote: >>> On Tue, Nov 29, 2011 at 11:40:30AM -0500, Trond Myklebust wrote: I mean that I'm perfectly entitled to do 'modprobe -

[Devel] Re: [PATCH 2/4] Add a __GFP_SLABMEMCG flag

2012-06-09 Thread James Bottomley
On Fri, 2012-06-08 at 14:31 -0500, Christoph Lameter wrote: > On Fri, 8 Jun 2012, Glauber Costa wrote: > > > */ > > #define __GFP_NOTRACK_FALSE_POSITIVE (__GFP_NOTRACK) > > > > -#define __GFP_BITS_SHIFT 25/* Room for N __GFP_FOO bits */ > > +#define __GFP_BITS_SHIFT 26/* Room fo