Re: [Devel] [RFC PATCH vz9 v6 56/62] dm-ploop: support REQ_FUA for data pios

2024-12-22 Thread Alexander Atanasov
On 20.12.24 14:51, Andrey Zhadchenko wrote: On 12/13/24 15:15, Alexander Atanasov wrote: On 13.12.24 15:22, Andrey Zhadchenko wrote: On 12/13/24 14:12, Alexander Atanasov wrote: On 13.12.24 14:58, Andrey Zhadchenko wrote: No, REQ_FUA does not oblige us to make sync. REQ_FUA is translated

Re: [Devel] [RFC PATCH vz9 v6 56/62] dm-ploop: support REQ_FUA for data pios

2024-12-22 Thread Andrey Zhadchenko
On 12/13/24 15:15, Alexander Atanasov wrote: On 13.12.24 15:22, Andrey Zhadchenko wrote: On 12/13/24 14:12, Alexander Atanasov wrote: On 13.12.24 14:58, Andrey Zhadchenko wrote: No, REQ_FUA does not oblige us to make sync. REQ_FUA is translated into IOCB_DSYNC. It is IOCB layer job to dat

Re: [Devel] [RFC PATCH vz9 v6 56/62] dm-ploop: support REQ_FUA for data pios

2024-12-13 Thread Alexander Atanasov
On 13.12.24 15:22, Andrey Zhadchenko wrote: On 12/13/24 14:12, Alexander Atanasov wrote: On 13.12.24 14:58, Andrey Zhadchenko wrote: No, REQ_FUA does not oblige us to make sync. REQ_FUA is translated into IOCB_DSYNC. It is IOCB layer job to datasync this exact request. Also REQ_FUA usually is

Re: [Devel] [RFC PATCH vz9 v6 56/62] dm-ploop: support REQ_FUA for data pios

2024-12-13 Thread Andrey Zhadchenko
On 12/13/24 14:12, Alexander Atanasov wrote: On 13.12.24 14:58, Andrey Zhadchenko wrote: No, REQ_FUA does not oblige us to make sync. REQ_FUA is translated into IOCB_DSYNC. It is IOCB layer job to datasync this exact request. Also REQ_FUA usually is coupled with REQ_PREFLUSH and we already h

Re: [Devel] [RFC PATCH vz9 v6 56/62] dm-ploop: support REQ_FUA for data pios

2024-12-13 Thread Alexander Atanasov
On 13.12.24 14:58, Andrey Zhadchenko wrote: No, REQ_FUA does not oblige us to make sync. REQ_FUA is translated into IOCB_DSYNC. It is IOCB layer job to datasync this exact request. Also REQ_FUA usually is coupled with REQ_PREFLUSH and we already handle that. We do this only for metadata in p

Re: [Devel] [RFC PATCH vz9 v6 56/62] dm-ploop: support REQ_FUA for data pios

2024-12-13 Thread Andrey Zhadchenko
No, REQ_FUA does not oblige us to make sync. REQ_FUA is translated into IOCB_DSYNC. It is IOCB layer job to datasync this exact request. Also REQ_FUA usually is coupled with REQ_PREFLUSH and we already handle that. On 12/5/24 22:56, Alexander Atanasov wrote: If we see a bio with REQ_FUA set we