Re: [Devel] [RFC PATCH vz9 v6 47/62] dm-ploop: disable metadata writeback delay

2025-01-13 Thread Alexander Atanasov
On 14.01.25 9:00, Pavel Tikhomirov wrote: Should not we bring back the ploop_cluster_is_in_top_delta hunk too? As this patch looks like a revert to "[RFC PATCH vz9 v6 23/62] dm-ploop: make new allocations immediately visible in BAT". Yes, it is kind of backing off the changes. ploop_cluster_is

Re: [Devel] [RFC PATCH vz9 v6 47/62] dm-ploop: disable metadata writeback delay

2025-01-13 Thread Pavel Tikhomirov
Should not we bring back the ploop_cluster_is_in_top_delta hunk too? As this patch looks like a revert to "[RFC PATCH vz9 v6 23/62] dm-ploop: make new allocations immediately visible in BAT". On 12/6/24 05:56, Alexander Atanasov wrote: diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-plo

Re: [Devel] [RFC PATCH vz9 v6 47/62] dm-ploop: disable metadata writeback delay

2024-12-23 Thread Alexander Atanasov
On 20.12.24 16:02, Andrey Zhadchenko wrote: Here you are also disabling immediate metadata publish. Then you should also call ploop_attach_end_action() for all requests in ploop_locate_new_cluster_and_attach_pio(). Otherwise there we may have completed write() syscall without metadata changes (

Re: [Devel] [RFC PATCH vz9 v6 47/62] dm-ploop: disable metadata writeback delay

2024-12-22 Thread Andrey Zhadchenko
Here you are also disabling immediate metadata publish. Then you should also call ploop_attach_end_action() for all requests in ploop_locate_new_cluster_and_attach_pio(). Otherwise there we may have completed write() syscall without metadata changes (they are not delayed now but still executed