Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-16 Thread Pavel Tikhomirov
On 1/14/25 16:39, Alexander Atanasov wrote: On 14.01.25 7:14, Pavel Tikhomirov wrote: On 1/14/25 12:03, Pavel Tikhomirov wrote: On 12/6/24 05:55, Alexander Atanasov wrote: @@ -411,7 +415,6 @@ static void ploop_apply_delta_mappings(struct ploop *ploop,   if (!is_raw)   d_md = p

Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-15 Thread Alexander Atanasov
On 13.01.25 13:22, Pavel Tikhomirov wrote: For the history - this is not a rule of thumb but how lock variants work. - lock with no prefix should be used in interrupt context, Interrupts are disabled for sure - lock with _irq prefix should be used in non-interrupt context, Lock and disabl

Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-14 Thread Alexander Atanasov
On 14.01.25 6:03, Pavel Tikhomirov wrote: On 12/6/24 05:55, Alexander Atanasov wrote: @@ -411,7 +415,6 @@ static void ploop_apply_delta_mappings(struct ploop *ploop,   if (!is_raw)   d_md = ploop_md_first_entry(md_root); -    write_lock_irq(&ploop->bat_rwlock);   ploop_for_each_

Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-14 Thread Alexander Atanasov
On 13.01.25 13:22, Pavel Tikhomirov wrote: On 12/6/24 05:55, Alexander Atanasov wrote: @@ -1045,10 +1054,12 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file)   /* Points to hdr since md_page[0] also contains hdr. */   d_md = ploop_md_first_entry(&md_roo

Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-14 Thread Alexander Atanasov
On 14.01.25 7:14, Pavel Tikhomirov wrote: On 1/14/25 12:03, Pavel Tikhomirov wrote: On 12/6/24 05:55, Alexander Atanasov wrote: @@ -411,7 +415,6 @@ static void ploop_apply_delta_mappings(struct ploop *ploop,   if (!is_raw)   d_md = ploop_md_first_entry(md_root); -    write_lock_i

Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-13 Thread Pavel Tikhomirov
On 1/14/25 12:03, Pavel Tikhomirov wrote: On 12/6/24 05:55, Alexander Atanasov wrote: @@ -411,7 +415,6 @@ static void ploop_apply_delta_mappings(struct ploop *ploop,   if (!is_raw)   d_md = ploop_md_first_entry(md_root); -    write_lock_irq(&ploop->bat_rwlock);   ploop_for_eac

Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-13 Thread Pavel Tikhomirov
On 12/6/24 05:55, Alexander Atanasov wrote: @@ -411,7 +415,6 @@ static void ploop_apply_delta_mappings(struct ploop *ploop, if (!is_raw) d_md = ploop_md_first_entry(md_root); - write_lock_irq(&ploop->bat_rwlock); ploop_for_each_md_page(ploop, md, node) {

Re: [Devel] [RFC PATCH vz9 v6 21/62] dm-ploop: introduce per-md page locking

2025-01-13 Thread Pavel Tikhomirov
On 12/6/24 05:55, Alexander Atanasov wrote: @@ -1045,10 +1054,12 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) /* Points to hdr since md_page[0] also contains hdr. */ d_md = ploop_md_first_entry(&md_root); - write_lock_irq(&ploop->bat_rwlo