Re: [Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-09 Thread Andrey Zhadchenko
On 10/9/24 14:45, Alexander Atanasov wrote: On 9.10.24 15:43, Andrey Zhadchenko wrote: On 10/8/24 13:46, Alexander Atanasov wrote: On 8.10.24 14:35, Andrey Zhadchenko wrote: Code from ploop_dispatch_pio():  if (pio->queue_list_id == PLOOP_LIST_FLUSH) *is_flush = true;  

Re: [Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-09 Thread Alexander Atanasov
On 9.10.24 15:43, Andrey Zhadchenko wrote: On 10/8/24 13:46, Alexander Atanasov wrote: On 8.10.24 14:35, Andrey Zhadchenko wrote: Code from ploop_dispatch_pio(): if (pio->queue_list_id == PLOOP_LIST_FLUSH)     *is_flush = true; else     *is_data = true; So I think

Re: [Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-09 Thread Andrey Zhadchenko
On 10/8/24 13:46, Alexander Atanasov wrote: On 8.10.24 14:35, Andrey Zhadchenko wrote: On 10/4/24 09:58, Alexander Atanasov wrote: Currently there are two workers one to handle pios, one to handle flush (via vfs_fsync). This workers are created unbound which means they are run whenever ther

Re: [Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-08 Thread Alexander Atanasov
Hello, On 8.10.24 18:42, Alexey Kuznetsov wrote: [Some people who received this message don't often get email from alexey.n.kuznet...@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello! if (is_data) queue_work(ploop->wq, &

Re: [Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-08 Thread Alexey Kuznetsov
Hello! if (is_data) queue_work(ploop->wq, &ploop->worker); - if (is_flush) + else if (is_flush) queue_work(ploop->wq, &ploop->fsync_worker); IMHO this looks scary. bio with FLUSH must execute flush first, and only after completion of flush data o

Re: [Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-08 Thread Alexander Atanasov
On 8.10.24 14:35, Andrey Zhadchenko wrote: On 10/4/24 09:58, Alexander Atanasov wrote: Currently there are two workers one to handle pios, one to handle flush (via vfs_fsync). This workers are created unbound which means they are run whenever there is a free CPU. When ploop sends pios (via plo

Re: [Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-08 Thread Andrey Zhadchenko
On 10/4/24 09:58, Alexander Atanasov wrote: Currently there are two workers one to handle pios, one to handle flush (via vfs_fsync). This workers are created unbound which means they are run whenever there is a free CPU. When ploop sends pios (via ploop_dispatch_pios) it checks if there are da

[Devel] [PATCH vz9] ploop: fsync after all pios are sent

2024-10-04 Thread Alexander Atanasov
Currently there are two workers one to handle pios, one to handle flush (via vfs_fsync). This workers are created unbound which means they are run whenever there is a free CPU. When ploop sends pios (via ploop_dispatch_pios) it checks if there are data and if there are flush pios. If both are prese