Re: [Devel] [PATCH VZ9] drivers/md/ploop: rework preallocation algorithm

2025-07-04 Thread Pavel Tikhomirov
Generally looks good, except maybe spliting "dropped unnused arguments" into separate patch as logically separate change and question about new condition in ploop_should_prealloc. Please see comments inline: On 7/2/25 22:43, Andrey Zhadchenko wrote: Recently we notices that fstrim does not w

[Devel] [PATCH VZ9] drivers/md/ploop: rework preallocation algorithm

2025-07-02 Thread Andrey Zhadchenko
Recently we notices that fstrim does not work properly on ploop images. The problem is actually worse: current code preallocates excessive space on the image and loses it later. Example: [root@vz9-demens-1 fstrim]# du -h . 4.0K . [root@vz9-demens-1 fstrim]# ploop init -s 10G image ... [