[Devel] Re: [PATCH] Wake up mandatory locks waiter on chmod

2007-09-16 Thread Pavel Emelyanov
J. Bruce Fields wrote: > On Thu, Sep 13, 2007 at 06:30:43PM +0400, Pavel Emelyanov wrote: >> When the process is blocked on mandatory lock and someone changes >> the inode's permissions, so that the lock is no longer mandatory, >> nobody wakes up the blocked process, but probably should. > > I sup

[Devel] Re: [PATCH 2/2] Fix user namespace exiting OOPs

2007-09-16 Thread Pavel Emelyanov
Andrew Morton wrote: > On Fri, 14 Sep 2007 13:23:55 -0500 "Serge E. Hallyn" <[EMAIL PROTECTED]> > wrote: > >>> run on kernel with CONFIG_USER_NS turned on will oops the >>> kernel immediately. >>> >>> This was spotted during OpenVZ kernel testing. >>> >>> Signed-off-by: Pavel Emelyanov <[EMAIL PR

[Devel] Re: [RFC][PATCH 0/3] Kernel memory accounting container (v2)

2007-09-16 Thread Pavel Emelyanov
Christoph Lameter wrote: > On Fri, 14 Sep 2007, Pavel Emelyanov wrote: > >>> H... Okay I have seen multiple people who want to control slab >>> allocations and track memory for various reasons. Would it be possible to >>> come up with some hook that would allow a subscription to certain SLUB

[Devel] Re: [NETNS45][PATCH 1/1] Fix network namespace unshare support.

2007-09-16 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: > Add CLONE_NEWNET flag in sys_unshare() test. > > This patch should be merged with commit: > "net: Add network namespace clone & unshare support." > > Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> Thanks you guys are really doing a good job catching when I slip up.

[Devel] Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-16 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sun, 16 Sep 2007 18:06:00 -0600 > I did that audit when I replied to Stephen the first time and I just > redid it to verify myself. We are calling functions that can fail > from the init function (kmalloc in the most common). So the > init functi

[Devel] Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-16 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Fri, 14 Sep 2007 22:07:14 +0200 > >> Could we just make it so dev->init is not allowed to fail? Then it >> can be a void function and the nasty unwind code can go? > > Someone (not me :-) need to do an a

[Devel] Re: Network Namespace status

2007-09-16 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > From: [EMAIL PROTECTED] (Eric W. Biederman) > Date: Thu, 13 Esp 2007 13:12:08 -0600 > >> The final blocker to having multiple useful instances of network >> namespaces is the loopback device. We recognize the network namespace >> of incoming packets by l

[Devel] Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net

2007-09-16 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 14 Sep 2007 22:07:14 +0200 > Could we just make it so dev->init is not allowed to fail? Then it > can be a void function and the nasty unwind code can go? Someone (not me :-) need to do an audit to find all current users of this function and

[Devel] Re: [PATCH] small cleanup for fib rules

2007-09-16 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 14 Sep 2007 15:06:47 +0400 > From: Denis V. Lunev <[EMAIL PROTECTED]> > > This patch slightly cleanups FIB rules framework. rules_list as a pointer > on struct fib_rules_ops is useless. It is always assigned with a static > per/subsystem list

[Devel] Re: [PATCH] Cleanup calling netdev notifiers

2007-09-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 14 Sep 2007 14:34:22 +0400 > The call_netdev_notifiers routine can successfully be used in > the net/core_dev.c itself. > > This will save 6 lines of code and 62 ;) bytes of .text section. > > 62 is rather small, but I have one more patch savi

[Devel] Re: [PATCH][NETNS] Consolidate hashes creation in netdev_init()

2007-09-16 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 14 Sep 2007 12:40:49 +0400 > The dev_name_hash and the dev_index_hash are now booth kmalloc-ed > (and each element is properly initialized as usually) so I think > it's worth consolidating this code making it look nicer (and > saving 28 bytes o

[Devel] Re: Network Namespace status

2007-09-16 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 13 Sep 2007 13:12:08 -0600 > The final blocker to having multiple useful instances of network > namespaces is the loopback device. We recognize the network namespace > of incoming packets by looking at dev->nd_net. Which means for > packets

[Devel] Re: [PATCH] net: Fix the prototype of call_netdevice_notifiers

2007-09-16 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Thu, 13 Sep 2007 09:59:05 -0600 > > This replaces the void * parameter with a struct net_device * which > is what is actually required. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Applied to net-2.6.24, thanks Eric.

[Devel] Re: [PATCH] Wake up mandatory locks waiter on chmod

2007-09-16 Thread J. Bruce Fields
On Thu, Sep 13, 2007 at 06:30:43PM +0400, Pavel Emelyanov wrote: > When the process is blocked on mandatory lock and someone changes > the inode's permissions, so that the lock is no longer mandatory, > nobody wakes up the blocked process, but probably should. I suppose so. Does anyone actually u