I think fixing the _GNU_SOURCE is going to take a lot of work, and we should
probably a change of that nature lots of time for extra testing. So I
implemented a local wrapper that uses a configure time test.
The code for mystrerror is in the bottom of libntp/msyslog.c
The waf code is in wafhe
On Mon, Aug 26, 2019 at 10:51:58PM -0700, Hal Murray via devel wrote:
> > A relatively quick search suggests mandatory=True as an argument.
>
> That makes waf fail if the code chunk doesn't work.
You want "mandatory=False" since this is a probe, not a requirement.
And you want to pass "-Werror"
Gary E. Miller via devel writes:
> _GNU_SOURCE should not always be defined, but it does need to be defined
> in certain cases. For example, on glibc < 2.10, you need to define
> it to get strnlen() and struct ifreq.
In that case, you need to be prepared for changed semantics in several
places an
matthew.sel...@twosigma.com said:
> And you want to pass "-Werror" (I'm not certain how off the top of my head)
> to the compiler so that warnings are fatal. waf sees the compiler exit zero
> with or without warnings, so they look the same.
I put it into ctx.env.CFLAGS, then restored CFLAGS bac
Yo Achim!
On Tue, 27 Aug 2019 19:42:30 +0200
Achim Gratz via devel wrote:
> Gary E. Miller via devel writes:
> > _GNU_SOURCE should not always be defined, but it does need to be
> > defined in certain cases. For example, on glibc < 2.10, you need
> > to define it to get strnlen() and struct ifr
Gary E. Miller via devel writes:
>> In that case, you need to be prepared for changed semantics in several
>> places and I don't think ntpsec is set up to deal with that.
>
> Changed semantics? No. Simple existence of the prototpe is at stake.
Go back to the original thread and/or read the manua
Yo Achim!
On Tue, 27 Aug 2019 22:54:43 +0200
Achim Gratz via devel wrote:
> Gary E. Miller via devel writes:
> >> In that case, you need to be prepared for changed semantics in
> >> several places and I don't think ntpsec is set up to deal with
> >> that.
> >
> > Changed semantics? No. Simpl
