Re: pool vs nopeer

2016-08-24 Thread Daniel Franke
Not straightforwardly, but the change you originally proposed months ago when you first observed this bug was correct AFAICT. On Aug 24, 2016 8:10 PM, "Eric S. Raymond" wrote: > Daniel Franke : > > On 8/24/16, Hal Murray wrote: > > > That's the easy part. First we have to understand the code a

Re: pool vs nopeer

2016-08-24 Thread Eric S. Raymond
Daniel Franke : > On 8/24/16, Hal Murray wrote: > > That's the easy part. First we have to understand the code and find the > > bug. > > It should already be fixed in my branch. If you wanted to unfix it, at > ntp_proto.c:415 change MDF_ACAST to (MDF_ACAST | MDF_POOL). OK, that's good news. Do

Re: pool vs nopeer

2016-08-24 Thread Eric S. Raymond
Hal Murray : > > e...@thyrsus.com said: > > Fixing the pool/nopeer bug will have to be done twice unless we land > > Daniel's protocol-machine refactoring. Might have to be done *three* times > > if his redesign of the access-control options requires it. > > That's the easy part. First we have

Re: pool vs nopeer

2016-08-24 Thread Daniel Franke
On 8/24/16, Hal Murray wrote: > That's the easy part. First we have to understand the code and find the > bug. It should already be fixed in my branch. If you wanted to unfix it, at ntp_proto.c:415 change MDF_ACAST to (MDF_ACAST | MDF_POOL). ___ devel

Re: pool vs nopeer

2016-08-24 Thread Hal Murray
e...@thyrsus.com said: > Fixing the pool/nopeer bug will have to be done twice unless we land > Daniel's protocol-machine refactoring. Might have to be done *three* times > if his redesign of the access-control options requires it. That's the easy part. First we have to understand the code and

Re: pool vs nopeer

2016-08-24 Thread Gary E. Miller
Yo Eric! On Wed, 24 Aug 2016 08:30:01 -0400 "Eric S. Raymond" wrote: > Conclusion: TESTFRAME just went from "we need it someday" to > critical-path. Well, we were preparing for another swing at it anyway. +1. And now that you are getting a gut feel for what ntpd does from the ntpviz and Pi pro

Re: pool vs nopeer

2016-08-24 Thread Eric S. Raymond
Copying Mark and devel, everyone should know about the task dependencies. Hal Murray : > I think [the fact that the pool keyword can't combine with nopeer is] a bug. > > It should be reasonable to find, but may take a while to learn that chunk of > code. You are in a maze of twisty little depen