Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-30 Thread Gary E. Miller via devel
Yo Hal! On Thu, 29 Nov 2018 22:08:12 -0800 Hal Murray wrote: > >> ./tests/option-tester.sh: 98: ./tests/option-tester.sh: PYTHONPATH: > >> parameter not set > > > Weird. Stupid shell. Just test that PYTHONPATH exists before > > trying to echo it. > > Actually, there is already a test.

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-29 Thread Hal Murray via devel
>> ./tests/option-tester.sh: 98: ./tests/option-tester.sh: PYTHONPATH: >> parameter not set > Weird. Stupid shell. Just test that PYTHONPATH exists before trying to echo > it. Actually, there is already a test. That's where it is dying. I assume we can unset whatever it is called. --

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-29 Thread Gary E. Miller via devel
Yo Hal! On Thu, 29 Nov 2018 18:23:16 -0800 Hal Murray wrote: > > > How about yoou just comment out line 12? > ... > > I know. I'm curious how much else will need fixing. If pipefail > > is the only problem then I may have a solution. > > It dies at the end, trying to test PYTHONPATH Goo

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-29 Thread Hal Murray via devel
> > How about yoou just comment out line 12? ... > I know. I'm curious how much else will need fixing. If pipefail is the only > problem then I may have a solution. It dies at the end, trying to test PYTHONPATH ./tests/option-tester.sh: 98: ./tests/option-tester.sh: PYTHONPATH: parameter no

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-29 Thread Gary E. Miller via devel
Yo Hal! On Thu, 29 Nov 2018 13:55:42 -0800 Hal Murray wrote: > > How about yoou just comment out line 12? > > It's necessary. I know. I'm curious how much else will need fixing. If pipefail is the only problem then I may have a solution. > You added that code when converting things from b

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-29 Thread Hal Murray via devel
> How about yoou just comment out line 12? It's necessary. --- You added that code when converting things from bash to sh The goal is to get the return status of the test. The problem is that it gets piped to tee so normal results see the return from tee rather than the test. -- The

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-29 Thread Gary E. Miller via devel
Yo Jason! On Thu, 29 Nov 2018 07:58:12 -0500 Jason Azze via devel wrote: > Now that I got my home CI system up and running again, I see this > fails for Ubuntu 14, too. What shell does Ubuntu use for /bin/sh? > [ubu14-test1] $ /bin/sh -xe /tmp/jenkins1012014110254104847.sh > + ./tests/option-t

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-11-29 Thread Jason Azze via devel
On Fri, Oct 12, 2018, at 11:53 PM, Hal Murray via devel wrote: > Context is de-bashing tests/option-tester.sh and tests/python3-tester.sh Now that I got my home CI system up and running again, I see this fails for Ubuntu 14, too. [ubu14-test1] $ /bin/sh -xe /tmp/jenkins1012014110254104847.sh +

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Gary E. Miller via devel
Yo Hal! On Sat, 13 Oct 2018 14:16:46 -0700 Hal Murray wrote: > > I see no 'export' in your example. > > sh-4.4$ export foo=3 > sh-4.4$ echo $foo > 3 > sh-4.4$ (foo=4; echo $foo) > 4 > sh-4.4$ echo $foo > 3 > sh-4.4$ Now I see export, but not the test I wanted: $ export foo=3 $ (export foo=

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Hal Murray via devel
> I see no 'export' in your example. sh-4.4$ export foo=3 sh-4.4$ echo $foo 3 sh-4.4$ (foo=4; echo $foo) 4 sh-4.4$ echo $foo 3 sh-4.4$ -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Gary E. Miller via devel
Yo Hal! On Sat, 13 Oct 2018 13:56:39 -0700 Hal Murray wrote: > > Maybe: export FOO=xx ?? > > I tried it. It goes in, but the old value gets restored after the ) > We need a shell wizard. > > sh-4.4$ foo=3 > sh-4.4$ (echo $foo) > 3 > sh-4.4$ (foo=4; echo $foo) > 4 > sh-4.4$ echo $foo > 3 > s

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Hal Murray via devel
> Maybe: export FOO=xx ?? I tried it. It goes in, but the old value gets restored after the ) We need a shell wizard. sh-4.4$ foo=3 sh-4.4$ (echo $foo) 3 sh-4.4$ (foo=4; echo $foo) 4 sh-4.4$ echo $foo 3 sh-4.4$ -- These are my opinions. I hate spam. __

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Gary E. Miller via devel
Yo Hal! On Sat, 13 Oct 2018 13:36:46 -0700 Hal Murray wrote: > >> Can we do what we need with ()s? > > > I have no idea. I have not used anything but bash for decades. But > > it looks promising. If you can test then you or I can change the > > code. > > I tried it. FOO=xx inside () ge

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Hal Murray via devel
>> Can we do what we need with ()s? > I have no idea. I have not used anything but bash for decades. But > it looks promising. If you can test then you or I can change the code. I tried it. FOO=xx inside () gets dropped after the ) Maybe we can make a function that returns what we want, but

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Gary E. Miller via devel
Yo Hal! On Sat, 13 Oct 2018 12:47:47 -0700 Hal Murray wrote: > > ./waf configure --out=$DIR $2 2>&1 | tee$DIR/test.log > > The scripts run something (./waf configure in this case), and put > > the output into a pipe to log it. > > > Then next, there is a need to see if any part of the p

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Hal Murray via devel
> ./waf configure --out=$DIR $2 2>&1 | tee$DIR/test.log > The scripts run something (./waf configure in this case), and put the output > into a pipe to log it. > Then next, there is a need to see if any part of the pipeling failed. But / > bin/sh on *BSD only reports if the last part of t

Re: pipefail doesn't work on NetBSD or FreeBSD

2018-10-13 Thread Gary E. Miller via devel
Yo Hal! On Fri, 12 Oct 2018 21:53:30 -0700 Hal Murray via devel wrote: > Context is de-bashing tests/option-tester.sh and > tests/python3-tester.sh Ouch. That is supposed to be the way to de-bash on *BSD. > FreeBSD 11.1-RELEASE-p4 (GENERIC) #0: Tue Nov 14 06:12:40 UTC 2017 > > /bin/sh > $ se

pipefail doesn't work on NetBSD or FreeBSD

2018-10-12 Thread Hal Murray via devel
Context is de-bashing tests/option-tester.sh and tests/python3-tester.sh FreeBSD 11.1-RELEASE-p4 (GENERIC) #0: Tue Nov 14 06:12:40 UTC 2017 /bin/sh $ set -o pipefail set: Illegal option -o pipefail $ NetBSD 8.0 (GENERIC) #0: Tue Jul 17 14:59:51 UTC 2018 /bin/sh $ set -o pipefail set: Illegal