Re: ntpsec | Converted stat_count struct to a module level global. (!1026)

2019-08-28 Thread Gary E. Miller via devel
Yo Hal! On Wed, 28 Aug 2019 12:56:33 -0700 Hal Murray via devel wrote: > ianbru...@gmail.com said: > > It is reducing unnecessary globals because globals are a good thing > > to reduce. > > In general, I agree that reducing globals is a good idea. It's not > globals that are evil, it's the c

Re: ntpsec | Converted stat_count struct to a module level global. (!1026)

2019-08-28 Thread Hal Murray via devel
Thanks. Ahh... Part of the problem is that I misread the diffs. I didn't notice that the additions were procedures. I thought it was restoring the individual counters. ianbru...@gmail.com said: > It is reducing unnecessary globals because globals are a good thing to > reduce. In general,

Re: ntpsec | Converted stat_count struct to a module level global. (!1026)

2019-08-28 Thread Ian Bruene via devel
On 8/28/19 1:26 PM, Hal Murray wrote: Merge Request !1026 was merged The Subject says "Converted stat_count struct to a module level global" The code looks like it is un-struct-ing things. Was that "a module level global" supposed to be "module level globals"? !1026 moves the variables fro

Re: ntpsec | Converted stat_count struct to a module level global. (!1026)

2019-08-28 Thread Hal Murray via devel
Merge Request !1026 was merged The Subject says "Converted stat_count struct to a module level global" The code looks like it is un-struct-ing things. Was that "a module level global" supposed to be "module level globals"? What's the policy on this area? I thought the general idea was to put t