Re: ntpkeygen patch

2017-01-16 Thread Gary E. Miller
Yo All! No better patches than Greg Rubin's have appeared, so I have marged his patch. The system call ntpkeygen uses will block in Python 3.6 when not enough entropy is available. RGDS GARY --- Gary E. Miller Rellim 109 NW

Re: ntpkeygen patch

2017-01-07 Thread Hal Murray
dfoxfra...@gmail.com said: > But that qualifier is important. I'm not thrilled that we're now relying on > Python's SystemRandom implementation in lieu of libsodium, as I suspect the > latter has a lot more expert eyeballs on it. ... Would it be worth switching to libsodium just so we don't have

Re: ntpkeygen patch

2017-01-06 Thread Sanjeev Gupta
On Sat, Jan 7, 2017 at 7:16 AM, Daniel Franke wrote: > In any case, please *don't* switch to reading from /dev/random, or > monitoring /proc/sys/kernel/random/entropy_avail, or any similar hack. > The notion that it's ever possible to "run out" of entropy once the > pool has been seeded with an a

Re: ntpkeygen patch

2017-01-06 Thread Eric S. Raymond
Daniel Franke : > But that qualifier is important. I'm not thrilled that we're now > relying on Python's SystemRandom implementation in lieu of libsodium, > as I suspect the latter has a lot more expert eyeballs on it. That could be fixed. I could add libsodium acess to the C extension that alrea

Re: ntpkeygen patch

2017-01-06 Thread Greg Rubin
Gary, On Fri, Jan 6, 2017 at 4:48 PM Gary E. Miller wrote: > ... > Unless you believe, as many do, that RDRAND is backdoored. > > FeeBSD refuses to use RDRAND: > > > http://arstechnica.com/security/2013/12/we-cannot-trust-intel-and-vias-chip-based-crypto-freebsd-developers-say/ > > OTOH, The Exa

Re: ntpkeygen patch

2017-01-06 Thread Gary E. Miller
Yo Greg! On Sat, 07 Jan 2017 00:30:46 + Greg Rubin wrote: > > I'll repeat that I added a warning to the ntpkeygen man page about > > not running the program in a script, or near startup, and to ensure > > that your host has sufficient entropy before running it. > > > > This sounds like an

Re: ntpkeygen patch

2017-01-06 Thread Greg Rubin
Gary, On Fri, Jan 6, 2017 at 12:34 PM Gary E. Miller wrote: > Yo Greg! > > On Fri, 06 Jan 2017 05:52:29 + > Greg Rubin wrote: > > > I'm still very interested in reading your longer response to my > > comments regarding entropy and key generation. This is something I > > commonly encounter i

Re: ntpkeygen patch

2017-01-06 Thread Gary E. Miller
Yo Daniel! On Fri, 6 Jan 2017 18:16:23 -0500 Daniel Franke wrote: > I wish somebody had mentioned to me that we wrote ntpkeygen in Python > last month so that I could have done a code review. Slap Eric with a fish! And thank you for the code review. > I just > looked at the Python 2.7 version

Re: ntpkeygen patch

2017-01-06 Thread Daniel Franke
I wish somebody had mentioned to me that we wrote ntpkeygen in Python last month so that I could have done a code review. I now have, and fortunately, it appears as correct as can be for a Python-based implementation. But that qualifier is important. I'm not thrilled that we're now relying on Pyth

Re: ntpkeygen patch

2017-01-06 Thread Gary E. Miller
Yo Greg! On Fri, 06 Jan 2017 05:52:29 + Greg Rubin wrote: > I'm still very interested in reading your longer response to my > comments regarding entropy and key generation. This is something I > commonly encounter in Python code and if there is a better way to > manage things, I'd like to kn

Re: ntpkeygen patch

2017-01-04 Thread Gary E. Miller
Yo Greg! On Wed, 04 Jan 2017 22:00:12 + Greg Rubin wrote: > Very weird. Especially as I don't actually make changes which should > cause the errors you provided. I'd rather go forward, than look backward. If you have a way that obviously includes the entropy that was intended then we'd lov

Re: ntpkeygen patch

2017-01-04 Thread Greg Rubin
Very weird. Especially as I don't actually make changes which should cause the errors you provided. $ pyflakes ntpkeygen $ pyflakes ntpkeygen.new $ diff -u ntpkeygen ntpkeygen.new --- ntpkeygen 2017-01-04 17:50:18.051264022 + +++ ntpkeygen.new 2017-01-04 17:50:08.367264001 + @@ -88