Re: libaes_siv release candidate

2019-02-18 Thread Hal Murray via devel
dfoxfra...@gmail.com said: > You can assume it's a verification failure because "failure in underlying > machinery" shouldn't be possible. The call doesn't allocate memory and > doesn't make any system calls. There's nothing that can fail. Thanks. It would be nice to have that in the man page.

Re: libaes_siv release candidate

2019-02-18 Thread Hal Murray via devel
dfoxfra...@gmail.com said: > Try the new HEAD (3562205). I changed ANSI to POSIX.1-2001 which should > hopefully make FreeBSD happy again while still suppressing the colliding > symbols on NetBSD. Works on both FreeBSD and NetBSD. Thanks. -- These are my opinions. I hate spam.

Re: libaes_siv release candidate

2019-02-18 Thread Daniel Franke via devel
Okay, not surprised that's where the breakage was introduced, since OpenSSL 1.1.0 rearchitected how it handles threading: https://www.openssl.org/blog/blog/2017/02/21/threads/ Did my commit switching _ANSI_SOURCE to _POSIX_SOURCE resolve the build failure? On Mon, Feb 18, 2019 at 11:53 PM Hal Mur

Re: libaes_siv release candidate

2019-02-18 Thread Hal Murray via devel
dfoxfra...@gmail.com said: > What version of OpenSSL are you building against on FreeBSD? I want to go > through sources to figure out exactly why it fails. Current release: 12.0-RELEASE /usr/include/openssl/opensslv.h:# define OPENSSL_VERSION_NUMBER 0x1010101fL Fails An older system: 11.2-RE

Re: libaes_siv release candidate

2019-02-18 Thread Daniel Franke via devel
You can assume it's a verification failure because "failure in underlying machinery" shouldn't be possible. The call doesn't allocate memory and doesn't make any system calls. There's nothing that can fail. On Mon, Feb 18, 2019 at 3:53 PM Hal Murray wrote: > > > There is a rough edge that I don't

Re: libaes_siv release candidate

2019-02-18 Thread Daniel Franke via devel
Try the new HEAD (3562205). I changed ANSI to POSIX.1-2001 which should hopefully make FreeBSD happy again while still suppressing the colliding symbols on NetBSD. What version of OpenSSL are you building against on FreeBSD? I want to go through sources to figure out exactly why it fails. On Mon,

Re: libaes_siv release candidate

2019-02-18 Thread Hal Murray via devel
There is a rough edge that I don't fully understand. The man page for AES_SIV_Decrypt says: These functions return 1 on success and 0 on failure. There are 2 types of errors: the CMAC check failed, or there was a problem in some underlying machinery. Is there any way to distinguish bet

Re: libaes_siv release candidate

2019-02-18 Thread Hal Murray via devel
Google/gmail has been rejecting some of my mail recently. Daniel said: > I'm also waiting on Hal to run it through his build farm again to let me know > if last-minute changes caused any breakage. The ANSI fix for NetBSD broke FreeBSD. -- Build files have been written to: /home/murray/ntpsec/lib

libaes_siv release candidate

2019-02-18 Thread Daniel Franke via devel
The current HEAD of libaes_siv is a release candidate. Whether or not it becomes the release depends on what I decide to do about the CentOS 6 issue, which in turn depends on the OpenSSL team getting back to me. I'm also waiting on Hal to run it through his build farm again to let me know if last-m