Re: USE_PACKET_TIMESTAMP

2017-06-09 Thread Eric S. Raymond via devel
Hal Murray via devel : > The recvmsg man page > SunOS 5.11 Last Revised 27 Feb 2006 > It has some info about SO_TIMESTAMP, but I don't see any hints about the CMSG > macros. They're a semi-separate issue. They're used to extract all kinds of out-of-band infirmation from the data block return

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Hal Murray via devel
Thanks for fixing this. Can you verify that it works as well as builds? > Newer versions of Solaris support SO_TIMESTAMP per: > https://docs.oracle.com/cd/E19957-01/820-0724/gcoqs/index.html That has a link to a setsockopt man page which says: SunOS 5.11 Last Revised 21 Jan 2007 It doesn't sa

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Gary E. Miller via devel
Yo Matthew! On Thu, 8 Jun 2017 20:47:51 -0400 Matthew Selsky via devel wrote: > Newer versions of Solaris support SO_TIMESTAMP per: So why does the compile failt on buildbot? Is buildbot on an old version? RGDS GARY --- G

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Matthew Selsky via devel
On Thu, Jun 08, 2017 at 12:26:21AM -0700, Hal Murray via devel wrote: > Can anybody confirm that Solaris really doesn't have time stamps? I thought > we decided that all modern OSes did. That's why we could rip out the SIGIO > stuff. > > I took a quick google and couldn't find any mention of a

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Eric S. Raymond via devel
Hal Murray : > > >> If Solaris doesn't support time stamps, I would expect > >> ntp_packetstamp to die on a #error. What happened with it? > > > I factored the code so that if waf configure doesn't find a way to get > > packet arrival times from the UDP layer it uses the arrival time collected >

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Hal Murray via devel
>> If Solaris doesn't support time stamps, I would expect >> ntp_packetstamp to die on a #error. What happened with it? > I factored the code so that if waf configure doesn't find a way to get > packet arrival times from the UDP layer it uses the arrival time collected > in userspace (ntp_packet

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Eric S. Raymond via devel
Hal Murray via devel : > Can anybody confirm that Solaris really doesn't have time stamps? I thought > we decided that all modern OSes did. That's why we could rip out the SIGIO > stuff. > > I took a quick google and couldn't find any mention of anything that looked > like a time stamp in a S

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Hal Murray via devel
Can anybody confirm that Solaris really doesn't have time stamps? I thought we decided that all modern OSes did. That's why we could rip out the SIGIO stuff. I took a quick google and couldn't find any mention of anything that looked like a time stamp in a Solaris man page for setsockopt. Bu

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-07 Thread Hal Murray via devel
devel@ntpsec.org said: > If you are going to always #undef SO_BINTIME, why a few lines later test for > it? Some left over test code? Because I didn't know if SO_BINTIME for IPv6 was really broken on FreeBSD or there was something simple I could do to make it work. The #undef kludge made thin

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-07 Thread Gary E. Miller via devel
Yo Hal! I'm confused by commit 7bb7a656cbabd4be451d35c6a6058fac9ca8a56d. This new code in ntp/ntp_timestamp.c line 38: - #ifdef SO_BINTIME /* SO_BINTIME doesn't work for IpV6, FreeBSD 11, 2017-Jan * fortunately, FreeBSD also supports SO_TI

✘USE_PACKET_TIMESTAMP

2017-06-07 Thread Gary E. Miller via devel
Yo Hal! commit a893edc7fa5fdf05b7558c46b2e83db9c7a0881b broke Solaris. Buildbot shows a build failure. New issue here: https://gitlab.com/NTPsec/ntpsec/issues/342 Solaris has no msg_flags, msg_control or msg_controllen in struct msghdr. The last two are key to what that function does. You'

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-07 Thread Hal Murray via devel
> That is worth filing a bug against BSD for. They have confirmed that they know about it. (rather than I was confused) -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/devel

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-06 Thread Mark Atwood via devel
That is worth filing a bug against BSD for. On Mon, Jun 5, 2017 at 9:41 PM Hal Murray via devel wrote: > > FreeBSD supports both SO_BINTIME and SO_TIMESTAMP > > SO_BINTIME provides 32 bits of fractions of a second. > SO_TIMESTAMP provides microseconds - timeval. > > So the code is setup to prefe

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-06 Thread Gary E. Miller via devel
Yo Hal! On Tue, 06 Jun 2017 16:24:42 -0700 Hal Murray via devel wrote: > I just pushed a big cleanup. Nice. > Please test and don't be too surprised > if something breaks. I can't test with Solaris or Apple. I just tested on an up to date macOS. Breif testing looks good. RGDS GARY

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-06 Thread Hal Murray via devel
I just pushed a big cleanup. Please test and don't be too surprised if something breaks. I can't test with Solaris or Apple. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-05 Thread Hal Murray via devel
FreeBSD supports both SO_BINTIME and SO_TIMESTAMP SO_BINTIME provides 32 bits of fractions of a second. SO_TIMESTAMP provides microseconds - timeval. So the code is setup to prefer SO_BINTIME. Unfortunately,SO_BINTIME doesn't seem to work for IPv6. ?? I've disabled SO_BINTIME so it will use S

Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-04 Thread Hal Murray via devel
USE_PACKET_TIMESTAMP There is code in ntp_io that tests it. But it gets set in a different module, so all the code in ntp_io to call the code in ntp_packetstamp never gets compiled in. (I assume it worked OK before it was split out.) It took me a while to figure out how it actually works today. The code that