Re: ntp_control.c was Re: The request side of NTS is working

2019-02-19 Thread Eric S. Raymond via devel
James Browning via devel : > I have a branch 'control-denum' which takes a significantly wrong > approach and replaces many of the #define directives and replaces > them with a trio of enums. completely untested of course. IMO a > slightly less wrong solution might be to extend the table to have >

ntp_control.c was Re: The request side of NTS is working

2019-02-19 Thread James Browning via devel
On 2/19/19, Eric S. Raymond via devel wrote: > Hal Murray : >> The thing that gripes me about ntp_control is that for each of the tables >> >> mentioned above, there are actually 3 parallel tables and they are a long >> way >> apart so a pain to update. Maybe if we just interlaces the #defines wi

Re: The request side of NTS is working

2019-02-19 Thread Eric S. Raymond via devel
Hal Murray : > The thing that gripes me about ntp_control is that for each of the tables > mentioned above, there are actually 3 parallel tables and they are a long way > apart so a pain to update. Maybe if we just interlaces the #defines with the > text lookup tables it would be less painful t

Re: The request side of NTS is working

2019-02-19 Thread Hal Murray via devel
e...@thyrsus.com said: > What I will do, unless you tell me there's something really important about > those three wired-in order tables in ntp_control.c, is move them to ntpq. I think the 3 tables are in 3 different spaces. There is the main table of global variables. There is the one for th

Re: The request side of NTS is working

2019-02-19 Thread Eric S. Raymond via devel
Hal Murray : > > I'll study authinfo and get back to you, probably tomorrow. > > authinfo is a bad example. ntpq has its own copy of that list. ntpq has its own copy of the lists for almost *all* the standard ntpq displays. There are only three exceptions; those lists are in ntp_control.c > I t

Re: The request side of NTS is working

2019-02-18 Thread Hal Murray via devel
> I'll study authinfo and get back to you, probably tomorrow. authinfo is a bad example. ntpq has its own copy of that list. I thought there was at least one command that didn't need it's own list, but I can't find an example. Beware, you may get sucked in. The swamp is pretty deep, but it's

Re: The request side of NTS is working

2019-02-18 Thread Eric S. Raymond via devel
Hal Murray via devel : > Eric: If you feel like hacking, the thing that I'm going to want real soon > is > something similar to ntpq's authinfo. I think the ntpq side just displays > whatever it gets back. That makes it easy to add more slots - server only, > no > changes to ntpq. If you g

The request side of NTS is working

2019-02-18 Thread Hal Murray via devel
The client adds the NTS extensions and the server decodes them. I'm going to stretch my legs and try to catch up on email before starting on the response side. Eric: If you feel like hacking, the thing that I'm going to want real soon is something similar to ntpq's authinfo. I think the ntpq