Re: State of the debugging flags.

2017-05-31 Thread Gary E. Miller via devel
Yo Ian! On Wed, 31 May 2017 14:21:03 -0500 Ian Bruene via devel wrote: > > As you gain more experience, you will find that this is *often* a > > good way to partition tasks. > > Should these passes be separate merges, or all the same merge? The advantage to more, but smaller, merges, is that

Re: State of the debugging flags.

2017-05-31 Thread Eric S. Raymond via devel
Ian Bruene : > > > On 05/30/2017 06:36 PM, Eric S. Raymond via devel wrote: > >Sometime there are couple of tiers of easy cases, so you'll loop back > >to step 2. The point, be lazy. Don't spend more attention on the easy > >cases than you have to, so you can avoid spending less than you should

Re: State of the debugging flags.

2017-05-31 Thread Ian Bruene via devel
On 05/30/2017 06:36 PM, Eric S. Raymond via devel wrote: Sometime there are couple of tiers of easy cases, so you'll loop back to step 2. The point, be lazy. Don't spend more attention on the easy cases than you have to, so you can avoid spending less than you should on the tricky ones. As yo

Re: State of the debugging flags.

2017-05-31 Thread Achim Gratz via devel
Eric S. Raymond via devel writes: > I wasn't actually planning to assign this job to Ian yet, but Gary's > plan is so good that I think we'll roll with it. > > Ian, this is about as painless and low-risk a way to start you on modifying > C code as I can imagine. From the point of view of advancing

Re: State of the debugging flags.

2017-05-30 Thread Hal Murray via devel
> Every instance I've seen has the logging code enclosed in an #ifdef block > for the debug compilation switch, whether directly where it is used, of > inside of a macro. It would appear that someone began to replace the > explicit if debugs with macros, but never completed it for unknown reason

Re: State of the debugging flags.

2017-05-30 Thread Eric S. Raymond via devel
Gary E. Miller via devel : > Yo Ian! > > On Tue, 30 May 2017 16:34:07 -0500 > Ian Bruene via devel wrote: > > > Every instance I've seen has the logging code enclosed in an #ifdef > > block for the debug compilation switch, whether directly where it is > > used, of inside of a macro. It would

Re: State of the debugging flags.

2017-05-30 Thread Gary E. Miller via devel
Yo Ian! On Tue, 30 May 2017 16:34:07 -0500 Ian Bruene via devel wrote: > Every instance I've seen has the logging code enclosed in an #ifdef > block for the debug compilation switch, whether directly where it is > used, of inside of a macro. It would appear that someone began to > replace the

State of the debugging flags.

2017-05-30 Thread Ian Bruene via devel
At ESRs request I've trawled through the C sources to see how debug logging is handled. First, by way of summary let me present you with a couple bits of code: # define DPRINTF(lvl, arg)\ do { \ if (debug >= (lvl))\ mpr