Re: ✘Python 2.7 broken

2020-12-13 Thread James Browning via devel
On Sun, Dec 13, 2020, at 12:33 PM Gary E. Miller via devel wrote: > Yo James! > > On Sun, 13 Dec 2020 11:25:40 -0800 > James Browning via devel wrote: > > > The latter changes the extended version format to list commits since > > the last tag (if not 0) and a dirty tree indicator. > > --dirty is

Re: ✘Python 2.7 broken

2020-12-13 Thread Gary E. Miller via devel
Yo James! On Sun, 13 Dec 2020 11:25:40 -0800 James Browning via devel wrote: > How about the attached patches then. The first tries to grab the time > of the last git commit, but only if neither the environment nor > command line contains a timestamp. Time is not good. Git branches can do ugly

Re: ✘Python 2.7 broken

2020-12-13 Thread James Browning via devel
On Sun, Dec 13, 2020, at 9:49 AM Gary E. Miller via devel wrote: > Yo James! > > On Sun, 13 Dec 2020 02:00:41 -0800 > James Browning via devel wrote: > > > IIRC the python ntpclients compare version includes the git commit > > (excluding releases?) And includes the build epoch. I remember that >

Re: ✘Python 2.7 broken

2020-12-13 Thread Gary E. Miller via devel
Yo James! On Sun, 13 Dec 2020 02:00:41 -0800 James Browning via devel wrote: > IIRC the python ntpclients compare version includes the git commit > (excluding releases?) And includes the build epoch. I remember that > the build epochs didn't match in a version of the Gentoo ebuild. You can't u

Re: Re: ✘Python 2.7 broken

2020-12-13 Thread James Browning via devel
On Sat, Dec 12, 2020, 10:56 PM Hal Murray via devel wrote: > > I think we also want minimal post-install testing to verify that the > libraries > got installed in the right place. It doesn't have to be the full test > package. I think there is some code that does version checking. > > It would

Re: Re: ✘Python 2.7 broken

2020-12-12 Thread Hal Murray via devel
devel@ntpsec.org said: > As Fred said, things need not work in DESTDIR. DESTDIR is for building > packages. It is reasonable to want "as installed" testing (which you and I > have discussed before) at some point. What we have right now is post-build/ > pre-install testing. But either way, neith

Re: ✘Python 2.7 broken

2020-12-12 Thread Richard Laager via devel
On 12/12/20 9:17 PM, Gary E. Miller via devel wrote: No, the tests are run before installing in DESTDIR. So that you can stop and not install broken things. You want to be using the built files before installing in DESTDIR. Agreed 100%. The tests run before install and need to work in the

Re: ✘Python 2.7 broken

2020-12-12 Thread Fred Wright via devel
On Sat, 12 Dec 2020, James Browning via devel wrote: On Sat, Dec 12, 2020, at 6:41 PM Gary E. Miller via devel wrote: Yo James! On Sat, 12 Dec 2020 18:35:13 -0800 James Browning via devel wrote: The following patch clears it up on the machine I bisected on. No, that uses the installed

Re: ✘Python 2.7 broken

2020-12-12 Thread Gary E. Miller via devel
Yo James! On Sat, 12 Dec 2020 18:53:35 -0800 James Browning via devel wrote: > > You do NOT want to use the module in destdir. > > > > I thought I wanted to use the module in DESTDIR. No, the tests are run before installing in DESTDIR. So that you can stop and not install broken things. >

Re: ✘Python 2.7 broken

2020-12-12 Thread James Browning via devel
On Sat, Dec 12, 2020, at 6:41 PM Gary E. Miller via devel wrote: > Yo James! > > On Sat, 12 Dec 2020 18:35:13 -0800 > James Browning via devel wrote: > > > The following patch clears it up on the machine I bisected on. > > No, that uses the installed ntp module, not the one being tested. > > >

Re: ✘Python 2.7 broken

2020-12-12 Thread Gary E. Miller via devel
Yo James! On Sat, 12 Dec 2020 18:35:13 -0800 James Browning via devel wrote: > The following patch clears it up on the machine I bisected on. No, that uses the installed ntp module, not the one being tested. > pypath = destdir + ctx.env.PYTHONARCHDIR # + os.sep + 'ntp' > -env

Re: ✘Python 2.7 broken

2020-12-12 Thread Gary E. Miller via devel
Yo James! Python always looks in the current directory, before looking in PYTHONPATH or system paths. So better to just run the tests where the test ntp module is. Less is more. On Sat, 12 Dec 2020 18:35:13 -0800 James Browning via devel wrote: > On Sat, Dec 12, 2020 at 6:16 PM Gary E. Mille

Re: ✘Python 2.7 broken

2020-12-12 Thread James Browning via devel
On Sat, Dec 12, 2020 at 6:16 PM Gary E. Miller via devel wrote: > Yo James! > > On Sat, 12 Dec 2020 18:04:57 -0800 > James Browning via devel wrote: > > > It looks like a4c2c7921f144674402c2a3dbfc13a87b1ea3d1f can you > > confirm? > > Confirmed. > The following patch clears it up on the machine

Re: ✘Python 2.7 broken

2020-12-12 Thread Gary E. Miller via devel
Yo James! On Sat, 12 Dec 2020 18:04:57 -0800 James Browning via devel wrote: > It looks like a4c2c7921f144674402c2a3dbfc13a87b1ea3d1f can you > confirm? Confirmed. RGDS GARY --- Gary E. Miller Rellim 109 NW Wilmington Ave.

Re: ✘Python 2.7 broken

2020-12-12 Thread Gary E. Miller via devel
Yo Richard! On Sat, 12 Dec 2020 19:46:22 -0600 Richard Laager via devel wrote: > On 12/12/20 7:07 PM, Gary E. Miller via devel wrote: > > NTPsec git head broke Python 2.7, badly. > Are you able to provide a commit where this works and preferably > bisect this? I wonder if it's the FFI change o

Re: ✘Python 2.7 broken

2020-12-12 Thread James Browning via devel
On Sat, Dec 12, 2020, at 5:53 PM Gary E. Miller via devel wrote: > Yo Richard! > > On Sat, 12 Dec 2020 19:46:22 -0600 > Richard Laager via devel wrote: > > > On 12/12/20 7:07 PM, Gary E. Miller via devel wrote: > > > NTPsec git head broke Python 2.7, badly. > > > > I believe James B is looking a

Re: ✘Python 2.7 broken

2020-12-12 Thread Richard Laager via devel
On 12/12/20 7:53 PM, Gary E. Miller via devel wrote: On Sat, 12 Dec 2020 19:46:22 -0600 Richard Laager via devel wrote: On 12/12/20 7:07 PM, Gary E. Miller via devel wrote: NTPsec git head broke Python 2.7, badly. I believe James B is looking at test failures under certain conditions, but I

Re: ✘Python 2.7 broken

2020-12-12 Thread Gary E. Miller via devel
Yo Richard! On Sat, 12 Dec 2020 19:46:22 -0600 Richard Laager via devel wrote: > On 12/12/20 7:07 PM, Gary E. Miller via devel wrote: > > NTPsec git head broke Python 2.7, badly. > > I believe James B is looking at test failures under certain > conditions, but I've never been able to reproduc

Re: ✘Python 2.7 broken

2020-12-12 Thread Richard Laager via devel
On 12/12/20 7:07 PM, Gary E. Miller via devel wrote: NTPsec git head broke Python 2.7, badly. I believe James B is looking at test failures under certain conditions, but I've never been able to reproduce them. I wonder if this is that issue. Do the installed binaries break in the same way whe