Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-07 Thread Hal Murray via devel
devel@ntpsec.org said: > If you are going to always #undef SO_BINTIME, why a few lines later test for > it? Some left over test code? Because I didn't know if SO_BINTIME for IPv6 was really broken on FreeBSD or there was something simple I could do to make it work. The #undef kludge made thin

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-07 Thread Gary E. Miller via devel
Yo Hal! I'm confused by commit 7bb7a656cbabd4be451d35c6a6058fac9ca8a56d. This new code in ntp/ntp_timestamp.c line 38: - #ifdef SO_BINTIME /* SO_BINTIME doesn't work for IpV6, FreeBSD 11, 2017-Jan * fortunately, FreeBSD also supports SO_TI

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-07 Thread Hal Murray via devel
> That is worth filing a bug against BSD for. They have confirmed that they know about it. (rather than I was confused) -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/devel

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-06 Thread Mark Atwood via devel
That is worth filing a bug against BSD for. On Mon, Jun 5, 2017 at 9:41 PM Hal Murray via devel wrote: > > FreeBSD supports both SO_BINTIME and SO_TIMESTAMP > > SO_BINTIME provides 32 bits of fractions of a second. > SO_TIMESTAMP provides microseconds - timeval. > > So the code is setup to prefe

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-06 Thread Gary E. Miller via devel
Yo Hal! On Tue, 06 Jun 2017 16:24:42 -0700 Hal Murray via devel wrote: > I just pushed a big cleanup. Nice. > Please test and don't be too surprised > if something breaks. I can't test with Solaris or Apple. I just tested on an up to date macOS. Breif testing looks good. RGDS GARY

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-06 Thread Hal Murray via devel
I just pushed a big cleanup. Please test and don't be too surprised if something breaks. I can't test with Solaris or Apple. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/

Re: Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-05 Thread Hal Murray via devel
FreeBSD supports both SO_BINTIME and SO_TIMESTAMP SO_BINTIME provides 32 bits of fractions of a second. SO_TIMESTAMP provides microseconds - timeval. So the code is setup to prefer SO_BINTIME. Unfortunately,SO_BINTIME doesn't seem to work for IPv6. ?? I've disabled SO_BINTIME so it will use S

Heads up: USE_PACKET_TIMESTAMP tangle

2017-06-04 Thread Hal Murray via devel
A long time ago, we decided that all modern systems support getting a recv time stamp via recvmsg and we got rid of the code that that used SIGIO to get a time stamp. 6 months ago, ntp_packetstamp.c was split off from ntp_io.c There is code in ntp_packetstamp that #defines USE_PACKET_TIMESTAMP