devel@ntpsec.org said:
> As Fred said, things need not work in DESTDIR. DESTDIR is for building
> packages. It is reasonable to want "as installed" testing (which you and I
> have discussed before) at some point. What we have right now is post-build/
> pre-install testing. But either way, neith
On 12/12/20 9:17 PM, Gary E. Miller via devel wrote:
No, the tests are run before installing in DESTDIR. So that you can stop
and not install broken things.
You want to be using the
built files before installing in DESTDIR.
Agreed 100%.
The tests run before install and need to work in the
> I thought I wanted to use the module in DESTDIR. To find install issues
> before the ground drops out under me. Given that you know better, I will not
> interfere with your rewrite.
I think you want to use DESTDIR if you are testing things after installing
them.
There is a layer of testing
On Sat, 12 Dec 2020, James Browning via devel wrote:
On Sat, Dec 12, 2020, at 6:41 PM Gary E. Miller via devel
wrote:
Yo James!
On Sat, 12 Dec 2020 18:35:13 -0800
James Browning via devel wrote:
The following patch clears it up on the machine I bisected on.
No, that uses the installed
Yo James!
On Sat, 12 Dec 2020 18:53:35 -0800
James Browning via devel wrote:
> > You do NOT want to use the module in destdir.
> >
>
> I thought I wanted to use the module in DESTDIR.
No, the tests are run before installing in DESTDIR. So that you can stop
and not install broken things.
>
On Sat, Dec 12, 2020, at 6:41 PM Gary E. Miller via devel
wrote:
> Yo James!
>
> On Sat, 12 Dec 2020 18:35:13 -0800
> James Browning via devel wrote:
>
> > The following patch clears it up on the machine I bisected on.
>
> No, that uses the installed ntp module, not the one being tested.
>
> >
Yo James!
On Sat, 12 Dec 2020 18:35:13 -0800
James Browning via devel wrote:
> The following patch clears it up on the machine I bisected on.
No, that uses the installed ntp module, not the one being tested.
> pypath = destdir + ctx.env.PYTHONARCHDIR # + os.sep + 'ntp'
> -env
Yo James!
Python always looks in the current directory, before looking in
PYTHONPATH or system paths. So better to just run the tests where the
test ntp module is.
Less is more.
On Sat, 12 Dec 2020 18:35:13 -0800
James Browning via devel wrote:
> On Sat, Dec 12, 2020 at 6:16 PM Gary E. Mille
On Sat, Dec 12, 2020 at 6:16 PM Gary E. Miller via devel
wrote:
> Yo James!
>
> On Sat, 12 Dec 2020 18:04:57 -0800
> James Browning via devel wrote:
>
> > It looks like a4c2c7921f144674402c2a3dbfc13a87b1ea3d1f can you
> > confirm?
>
> Confirmed.
>
The following patch clears it up on the machine
Yo James!
On Sat, 12 Dec 2020 18:04:57 -0800
James Browning via devel wrote:
> It looks like a4c2c7921f144674402c2a3dbfc13a87b1ea3d1f can you
> confirm?
Confirmed.
RGDS
GARY
---
Gary E. Miller Rellim 109 NW Wilmington Ave.
Yo Richard!
On Sat, 12 Dec 2020 19:46:22 -0600
Richard Laager via devel wrote:
> On 12/12/20 7:07 PM, Gary E. Miller via devel wrote:
> > NTPsec git head broke Python 2.7, badly.
> Are you able to provide a commit where this works and preferably
> bisect this? I wonder if it's the FFI change o
On Sat, Dec 12, 2020, at 5:53 PM Gary E. Miller via devel
wrote:
> Yo Richard!
>
> On Sat, 12 Dec 2020 19:46:22 -0600
> Richard Laager via devel wrote:
>
> > On 12/12/20 7:07 PM, Gary E. Miller via devel wrote:
> > > NTPsec git head broke Python 2.7, badly.
> >
> > I believe James B is looking a
On 12/12/20 7:53 PM, Gary E. Miller via devel wrote:
On Sat, 12 Dec 2020 19:46:22 -0600
Richard Laager via devel wrote:
On 12/12/20 7:07 PM, Gary E. Miller via devel wrote:
NTPsec git head broke Python 2.7, badly.
I believe James B is looking at test failures under certain
conditions, but I
Yo Richard!
On Sat, 12 Dec 2020 19:46:22 -0600
Richard Laager via devel wrote:
> On 12/12/20 7:07 PM, Gary E. Miller via devel wrote:
> > NTPsec git head broke Python 2.7, badly.
>
> I believe James B is looking at test failures under certain
> conditions, but I've never been able to reproduc
On 12/12/20 7:07 PM, Gary E. Miller via devel wrote:
NTPsec git head broke Python 2.7, badly.
I believe James B is looking at test failures under certain conditions,
but I've never been able to reproduce them. I wonder if this is that
issue. Do the installed binaries break in the same way whe
On 12/12/20 10:00 AM, James Browning via devel wrote:
On 2020 December 19, I intend to merge > !1196
Merged. Thanks! Closed #680.
(the first patch of) !1167
I left some comments and questions there.
!1189
LGTM. Approved. I'll leave it to you to merge. It'd be nice to have a
"Fixes #558
On 2020 December 19, I intend to merge !1196, (the first patch of) !1167,
!1189, and !1137.
If there is a reason not to merge any of those feel compelled to comment
now. This should also close #680, !957, and !1147.
___
devel mailing list
devel@ntpsec.or
17 matches
Mail list logo
