Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 02-08-19 07:12, Matthew Selsky wrote: > You can likely remove python-devel and python-devel. Did so. > Are your RPM packages published anywhere? Not currently. On one machine I see something weird: # ntpq -pn remote refid st t when poll reach delay offset jitter ===

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Fri, Aug 02, 2019 at 06:31:34AM +0200, Udo van den Heuvel wrote: > Builds successfully after adapting the directories in the %files section. Excellent! > URL: http://www.ntpsec.org > Requires(post): systemd-units > Requires(preun): systemd-units > Requires(postun): systemd-units > BuildRequir

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 20:33, Matthew Selsky wrote: > To: > %{__python3} ./waf configure \ > %{__python3} ./waf build > DESTDIR=$RPM_BUILD_ROOT %{__python3} ./waf install > > Let's see if that helps. Builds successfully after adapting the directories in the %files section. > Is there a git repo for your

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 07:19:02PM +0200, Udo van den Heuvel wrote: > On 01-08-19 19:00, Matthew Selsky wrote: > > You may need to specifically use %{__python3} when you call "waf" in the 2 > > places in the %build section. > > So maybe not use --python=%{__python3} for waf? "--python" should no

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 19:00, Matthew Selsky wrote: > You may need to specifically use %{__python3} when you call "waf" in the 2 > places in the %build section. When I do these things I get: Waf: Leaving directory `/usr/src/redhat/BUILD/ntpsec-1.1.6/build/main' Traceback (most recent call last): File "/u

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 05:02:58PM +0200, Udo van den Heuvel wrote: > On 01-08-19 16:39, Udo van den Heuvel via devel wrote: > > The 1.1.6 code does not. > > The workaround now works when I use the pathfix.py line with this > addition: %{buildroot}%{_sbindir}/* > > The whole SPEC then looks like

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 16:39, Udo van den Heuvel via devel wrote: > The 1.1.6 code does not. The workaround now works when I use the pathfix.py line with this addition: %{buildroot}%{_sbindir}/* The whole SPEC then looks like the stuff below. How can we explain the existing shebangs? Kind regards, Udo

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 16:27, Matthew Selsky wrote: > See > https://gitlab.com/NTPsec/ntpsec/commit/3ee8e4c3c3cf4b2d6f010874e7f447a23a1710cf > for the change that we made to our CI targets. Sure. 1.1.3 that is on my system has the correct shebangs. The 1.1.6 code does not. (...) + /usr/lib/rpm/redhat/brp-

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 04:31:52PM +0200, Udo van den Heuvel wrote: > On 01-08-19 16:27, Matthew Selsky wrote: > > On Thu, Aug 01, 2019 at 04:18:30PM +0200, Udo van den Heuvel wrote: > > > > See > > https://gitlab.com/NTPsec/ntpsec/commit/3ee8e4c3c3cf4b2d6f010874e7f447a23a1710cf > > for the chan

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 16:27, Matthew Selsky wrote: > On Thu, Aug 01, 2019 at 04:18:30PM +0200, Udo van den Heuvel wrote: > >> The build shows otherwise, else there would not be an error. >> Or did I miss a step in the build process? > > See > https://gitlab.com/NTPsec/ntpsec/commit/3ee8e4c3c3cf4b2d6f01087

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 04:18:30PM +0200, Udo van den Heuvel wrote: > The build shows otherwise, else there would not be an error. > Or did I miss a step in the build process? See https://gitlab.com/NTPsec/ntpsec/commit/3ee8e4c3c3cf4b2d6f010874e7f447a23a1710cf for the change that we made to our

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 16:15, Matthew Selsky wrote: >> Can someone please fix the /usr/sbin/ntpdig error? it makes the >> workround fail... > > Our code works on both Python2 and Python3. Given F30's recent changes, we > switched our CI targets to explicitly point at python3. The build shows otherwise, el

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 03:32:40PM +0200, Udo van den Heuvel via devel wrote: > On 01-08-19 15:24, Udo van den Heuvel via devel wrote: > > The script will exit with nonzero exit code, rendering the build failed. > > When trying to work around this in my spec file, I use: > pathfix.py -pni "%{__pyt

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 15:24, Udo van den Heuvel via devel wrote: > The script will exit with nonzero exit code, rendering the build failed. When trying to work around this in my spec file, I use: pathfix.py -pni "%{__python2} %{py2_shbang_opts}" %{buildroot}%{python2_sitearch} %{buildroot}%{_bindir}/* Res

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
On 01-08-19 15:09, Udo van den Heuvel via devel wrote: > Hello, > > The compile on Fedora 30 fails at the very end: > > (...) > + /usr/lib/rpm/brp-python-hardlink > + /usr/lib/rpm/redhat/brp-mangle-shebangs > *** ERROR: ambiguous python shebang in /usr/bin/ntpwait: #!/usr/bin/env > python. Change

1.1.6 build fails on FC30

2019-08-01 Thread Udo van den Heuvel via devel
Hello, The compile on Fedora 30 fails at the very end: (...) + pushd /root/rpmbuild/BUILDROOT/ntpsec-1.1.6-0.fc30.x86_64 ~/rpmbuild/BUILDROOT/ntpsec-1.1.6-0.fc30.x86_64 ~/rpmbuild/BUILD/ntpsec-1.1.6 + mkdir -p ./etc/ntp/crypto ./etc/sysconfig ./etc/dhcp/dhclient.d ./usr/libexec + mkdir -p ./etc/n