Re: Odds and ends

2018-06-06 Thread Hal Murray via devel
[if (0) on debugging msyslog] > What I do is delete them unless I think they might have continuing value, in > which case I put them under DPRINTF. I agree on the "continuing value" part. For what I'm after, msyslog is more convenient that DPRINTF. I'm willing to do an edit/build/restart cycl

Cleanup opportunity - mode6 processing

2018-06-06 Thread Hal Murray via devel
ctl_putsys in ntpd/ntp_control.c is full of things like: case CS_MRU_MAXDEPTH: ctl_putuint(sys_var[varid].text, mon_data.mru_maxdepth); break; CS_MRU_MAXDEPTH comes from a big line of things like: #define CS_MRU_MAXDEPTH 30 It is also used in a big

Re: Odds and ends

2018-06-06 Thread Mark Atwood via devel
>> The code for freeing up key strings zeros them out first. How do we do that in python or go? > Same way you would in C, iterate over them writing zeros. Am I missing something? I may be not understanding something. I thought that strings were non-mutatable in Python, and every time one is wri

Re: Odds and ends

2018-06-06 Thread Eric S. Raymond via devel
Hal Murray via devel : > I occasionally add msyslog lines when debugging. The DPRINTF stuff isn't > interesting - too much junk I don't want. When I'm cleaning up, should I > disable them with "if (0)", or delete them? Is there a better way? ... What I do is delete them unless I think they m

Odds and ends

2018-06-06 Thread Hal Murray via devel
I occasionally add msyslog lines when debugging. The DPRINTF stuff isn't interesting - too much junk I don't want. When I'm cleaning up, should I disable them with "if (0)", or delete them? Is there a better way? ... Some/many of the prototypes in our header files are not very useful. I th