What am I supposed to do about an Internal server error from GitLab?

2017-12-04 Thread Hal Murray via devel
Subject: ntpsec | Pipeline #14729097 has failed for master | 3c1cc3c8 From: GitLab Commit: 3c1cc3c8 ( https://gitlab.com/NTPsec/ntpsec/commit/3c1cc3c8317faa48ce8 e5b8ef7909c16cb04deab ) Commit Message: Fix ntpq -c direct -c mrulist to output seconds... Commit Author: Hal Murray Removing build/

Re: tests/option-tester.sh

2017-12-04 Thread Hal Murray via devel
> I get exactly the same results. ??? > Then my build fails: Just to make sure... Any chance you have local edits doing something strange? Can you try it on a fresh git clone? Does gcc look in any environment variables? Another possibility is something like: grep "#define" . -r | grep DEBUG

Re: tests/option-tester.sh

2017-12-04 Thread Gary E. Miller via devel
Yo Hal! On Mon, 04 Dec 2017 19:38:00 -0800 Hal Murray wrote: > > I can confirm that debug is being set. > > This is pretty weird. I wonder where it is being set, and why it > isn't also set in the other modules. > > > I don not see anything in there to turn on DEBUG. > > Is there a verbose

Re: tests/option-tester.sh

2017-12-04 Thread Hal Murray via devel
> I can confirm that debug is being set. This is pretty weird. I wonder where it is being set, and why it isn't also set in the other modules. > I don not see anything in there to turn on DEBUG. > Is there a verbose option for waf to show the gcc commands it is running? waf -v is verbose mode.

Re: Need help from a python wizard

2017-12-04 Thread Hal Murray via devel
> There is a change in the way this is handled by Python between 2 and 3. > You can force integer arithmetic with "//" like 3 // 2 which > will result in 1. Thanks. That's what I was looking for. And here is the corresponding commit at the right time: commit 9765c7ce597f0933f8b45fa627d195262be

Re: tests/option-tester.sh

2017-12-04 Thread Hal Murray via devel
g...@rellim.com said: > Since I do not have NTP_DEBUG_LISTS defined, the extern is never pulled in. > Not the first time thee DBUG stuff caused issues for me. Look in include/ntp_lists.h if DEBUG exists, it defines NTP_DEBUG_LISTS and sets up a couple of list macros to call check_gen_fifo_consi

Re: tests/option-tester.sh

2017-12-04 Thread Gary E. Miller via devel
Yo Hal! On Mon, 04 Dec 2017 13:31:43 -0800 Hal Murray wrote: > devel@ntpsec.org said: > >> I'd like to encourage everybody to use it when making > > "interesting" changes. > > Mostly failed for me. See attached. > > [93/93] Linking test-default/main/ntptime/ntptime > ntpd/ntp_config.c.3.o

Re: Need help from a python wizard

2017-12-04 Thread Clark B. Wierda via devel
On Mon, Dec 4, 2017 at 5:51 PM, Hal Murray via devel wrote: > > days = int(last) / 86400 > seconds = last - days*86400 > > I've kludged some printing. > days is a float, for example: 17504.9482755 > > is int/int supposed to result in an int or a float? > > I expected it to

Re: Need help from a python wizard

2017-12-04 Thread Hal Murray via devel
days = int(last) / 86400 seconds = last - days*86400 I've kludged some printing. days is a float, for example: 17504.9482755 is int/int supposed to result in an int or a float? I expected it to be an int. This code used to work. Trying by hand, I get an int... -- T

Re: Need help from a python wizard

2017-12-04 Thread Eric S. Raymond via devel
Hal Murray via devel : > Any hints? If not, I'll try bisecting. Sorry, no idea. I haven't been near that code in many months. -- http://www.catb.org/~esr/";>Eric S. Raymond My work is funded by the Internet Civil Engineering Institute: https://icei.org Please visit their site an

Need help from a python wizard

2017-12-04 Thread Hal Murray via devel
The direct mode of ntpq mrulist is broken. The direct mode is a hack to print out the info as it is collected rather than collecting everything then sorting the list and printing it out. The idea is to avoid using lots of memory. It's supposed to print out the MJD and seconds this day for the

Re: tests/option-tester.sh

2017-12-04 Thread Hal Murray via devel
devel@ntpsec.org said: >> I'd like to encourage everybody to use it when making > "interesting" changes. > Mostly failed for me. See attached. [93/93] Linking test-default/main/ntptime/ntptime ntpd/ntp_config.c.3.o: In function `destroy_attr_val_fifo': ntp_config.c:(.text+0x33): undefined refer

Re: tests/option-tester.sh

2017-12-04 Thread Gary E. Miller via devel
Yo Hal! On Mon, 04 Dec 2017 03:20:35 -0800 Hal Murray via devel wrote: > I'd like to encourage everybody to use it when making "interesting" > changes. Mostly failed for me. See attached. RGDS GARY --- Gary E. Miller Rell

Re: Should the HAVE_KERNEL_PLL conditional be abolished?

2017-12-04 Thread Hal Murray via devel
>> >> First: capture pulse timing info. >> >> Second: adjust "drift" on system clock >> >> Third: in kernel PLL to adjust drift from PPS pulses > You need drift correction implemented in the kernel to get decent >> timekeeping. ntp_adjtime is just the API. > For the drift correction, yes. Am

Re: Should the HAVE_KERNEL_PLL conditional be abolished?

2017-12-04 Thread Eric S. Raymond via devel
Hal Murray : > >> First: capture pulse timing info. > >> Second: adjust "drift" on system clock > >> Third: in kernel PLL to adjust drift from PPS pulses > > > It *is* clear enough that ntp_adjtime() is a prerequisite for any of the > > above three things to go on. > > You need drift correction

Re: Should the HAVE_KERNEL_PLL conditional be abolished?

2017-12-04 Thread Eric S. Raymond via devel
John D. Bell : >     A thought from out of left field here - > >     Would it be possible to simplify the code by using a tool to > partially pre-process the code (e.g. CPPP > (http://www.muppetlabs.com/~breadbox/software/cppp.html)), defining in > turn HAVE_KERNEL_PPS and HAVE_PPSAPI, and then co

tests/option-tester.sh

2017-12-04 Thread Hal Murray via devel
I'd like to encourage everybody to use it when making "interesting" changes. The idea is to at least try all the configuration options. It will catch simple quirks before you do the push. (Better is to try it before you do the commit so we avoid broken landing spots when doing a bisect.) The

STA_NANO

2017-12-04 Thread Hal Murray via devel
>From 693dd71a42fe037c4b3efda0b2876ed9bd91c8e2 Experimental removal of HAVE_KERNEL_PLL. There might also be a subsidiary problem with STA_NANO as well. STA_NANO is available on NetBSD and FreeBSD. It's not available on OpenBSD. -- These are my opinions. I hate spam.