Re: lfpinit() signed or unsigned?

2017-03-08 Thread Hal Murray
g...@rellim.com said: > Does lfpinit() need to return a signed? Or should the parameters to > lfpinit() annd be unsigned? I'm guessing the later, but I'm new to that > part of the code... Good catch. I think both parameters should be unsigned. If you want a negative answer, you need to think

✘lfpinit() signed or unsigned?

2017-03-08 Thread Gary E. Miller
Yo All! I was playing with the clang option -Weverything and ran into a weird one. well, many weird ones, but this stuck out first: In include/ntp_fp.h: l_fp is unsigned: typedef uint64_t l_fp; But strangely lfpinit() takes a signed first paramter and returns an l_fp, which is unsigned: stati