Achim Gratz writes:
> Eric S. Raymond writes:
>> Fortunately, we have good regression tests for those macros. So if you want
>> to submit a simplification MR, feel free.
>
> Here's that patch. Tests are still clean of course. I have not removed
> the distinction between signed and unsigned where
> I've opted to fix the comments.
> * compare previously-normalised a and b
> - * return 1 / 0 / -1 if a < / == / > b
> + * return -1 / 0 / 1 if a < / == / > b
Thanks for making it match what other cmp type routines do.
--
These are my opinions. I hate spam.
___
Eric S. Raymond writes:
> Fortunately, we have good regression tests for those macros. So if you want
> to submit a simplification MR, feel free.
Here's that patch. Tests are still clean of course. I have not removed
the distinction between signed and unsigned where it makes no difference
to th
Achim Gratz writes:
> The better patch is probably to fix either the comments or the inline
> functions in timespecops.h that have their logic reversed (apparently
> since the beginning) and possibly fix the current uses in systime.c and
> add tests that actually test for something else than equali
