Re: [csw-devel] [PATCH] Fix SPKG_DESC duplicate checking

2011-08-03 Thread Ben Walton
Excerpts from Maciej Bliziński's message of Wed Aug 03 04:36:31 -0400 2011: > I like the early detection of the issue. You could consider it a > build recipe check, as opposed to a binary package check. Fail fast is good, but doing the check in GAR removes the opportunity to intentionally have t

Re: [csw-devel] [PATCH] Fix SPKG_DESC duplicate checking

2011-08-03 Thread Maciej Bliziński
2011/8/3 Ben Walton : > I wonder if checkpkg isn't a better place for this check though? > Separating package building from package verification makes sense to > me. I like the early detection of the issue. You could consider it a build recipe check, as opposed to a binary package check. Neverth

Re: [csw-devel] [PATCH] Fix SPKG_DESC duplicate checking

2011-08-02 Thread Ben Walton
Excerpts from Maciej Blizinski's message of Mon Aug 01 12:15:57 -0400 2011: > Works around ticket #56. > > http://sourceforge.net/apps/trac/gar/ticket/56 > > Previous attempt at fixing it: > http://sourceforge.net/apps/trac/gar/changeset/11424 If we're shelling out, why not offload the whole thi

[csw-devel] [PATCH] Fix SPKG_DESC duplicate checking

2011-08-01 Thread Maciej Blizinski
Works around ticket #56. http://sourceforge.net/apps/trac/gar/ticket/56 Previous attempt at fixing it: http://sourceforge.net/apps/trac/gar/changeset/11424 --- gar/v2/gar.pkg.mk |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/gar/v2/gar.pkg.mk b/gar/v2/gar.pkg.mk