Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote: > Before this patch users might be confused with the error when no daemon > nor systemd socket unit is running due to the error message being a bit > vague when running as root with no URI: > > # virsh list > error: failed to c

Re: [PATCH 1/2] Report first tried socket from remoteProbeSystemDriverFromSocket

ote_sockets.h > index 00e654d46c2a..6505639c92a3 100644 > --- a/src/remote/remote_sockets.h > +++ b/src/remote/remote_sockets.h > @@ -65,7 +65,7 @@ remoteSplitURIScheme(virURI *uri, > int > remoteProbeSessionDriverFromBinary(char **driver); > int > -remoteProbeSystemDriver

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Wed, Nov 29, 2023 at 10:33:34AM +0100, Martin Kletzander wrote: > On Tue, Nov 28, 2023 at 02:29:20PM +0100, Peter Krempa wrote: > >On Tue, Nov 28, 2023 at 13:22:47 +, Daniel P. Berrangé wrote: > >>On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote: > >>> Before this patch user

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Wed, Nov 29, 2023 at 09:49:47AM +, Richard W.M. Jones wrote: > I'd like to try writing a wiki page that we can link in this message, > since I have to explain this problem over and over again to people and > it'd be good to have one place that explains it. It's a st

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Wed, Nov 29, 2023 at 05:44:59AM -0500, Andrea Bolognani wrote: > On Wed, Nov 29, 2023 at 10:09:36AM +0000, Richard W.M. Jones wrote: > > On Wed, Nov 29, 2023 at 09:49:47AM +, Richard W.M. Jones wrote: > > > I'd like to try writing a wiki page that we can link in this

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

Can we have the error message include a link to this page? https://wiki.libvirt.org/Failed_to_connect_to_the_hypervisor.html Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Fle

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Thu, Nov 30, 2023 at 10:06:38AM +0100, Peter Krempa wrote: > On Thu, Nov 30, 2023 at 09:49:56 +0100, Martin Kletzander wrote: > > On Wed, Nov 29, 2023 at 06:33:54PM +, Richard W.M. Jones wrote: > > > > > > Can we have the error message include a lin

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

On Fri, Dec 01, 2023 at 01:22:14PM +0100, Martin Kletzander wrote: > On Thu, Nov 30, 2023 at 09:48:10AM +0000, Richard W.M. Jones wrote: > >On Thu, Nov 30, 2023 at 10:06:38AM +0100, Peter Krempa wrote: > >>On Thu, Nov 30, 2023 at 09:49:56 +0100, Martin Kletzander wrote: > >

Re: [PATCH v2] Improve error message in remoteGetUNIXSocket

if (!direct_sock_name) { > virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", > - _("Cannot use direct socket mode if no URI is > set")); > + _("Cannot use direct socket mode if no URI is

Question/comment on nbdkit support in libvirt.spec

In this section (under %package libvirt-daemon-driver-qemu): %if %{with_nbdkit} Recommends: nbdkit Recommends: nbdkit-curl-plugin Recommends: nbdkit-ssh-plugin %endif You could save a bit of space by removing "Recommends: nbdkit" and replacing it with: Recommends: nbdkit-

Another comment on nbdkit support

Few more things ... (1) Looking at the parameters to nbdkit in qemuNbdkitProcessBuildCommand, it might make sense to consider --exit-with-parent. What this does on Linux is it causes nbdkit to call: prctl(PR_SET_PDEATHSIG, SIGTERM); which causes the kernel to send SIGTERM to nbdkit if the par

Re: Another comment on nbdkit support

On Fri, Jan 19, 2024 at 01:11:19PM +0100, Peter Krempa wrote: > On Fri, Jan 19, 2024 at 12:01:55 +0000, Richard W.M. Jones wrote: > > (2) I'm fairly sure you'll find you need to use --selinux-label at > > some point. This does some SELinux/sVirt voodoo on the socket. W

Re: [PATCH] vmx: Check serialX.vspc before serialX.fileName

On Thu, Apr 25, 2024 at 02:12:54PM +0200, Martin Kletzander wrote: > When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual > address for it is saved in serialX.vspc in which case the > serialX.fileName is most probably something we can't get any useful > information from and we a

Re: [PATCH] docs: Fix broken links

On Tue, May 21, 2024 at 05:12:00PM +0800, Han Han wrote: > @Richard Jones Hi Richard, > I cannot find the valid link for Nagios-virt. However, I saw your ID in the > broken link for Nagios-virt. > Could you help provide the new link for Nagios-virt? > > -`Nagios-virt

Re: [PATCH] vmx: Accept more serial variations

:20.6.2|0A" > guestOS = "other-64" > diff --git a/tests/vmx2xmldata/esx-in-the-wild-13.xml > b/tests/vmx2xmldata/esx-in-the-wild-13.xml > index 552c9a2a1a26..e6ef947d501f 100644 > --- a/tests/vmx2xmldata/esx-in-the-wild-13.xml > +++ b/tests/vmx2xmldata/esx-in-the-wild-13.xml > @@ -43,6

Re: [PATCH] util: open XML files before calling libxml2

ml = xmlCtxtReadDoc(pctxt, BAD_CAST xmlStr, url, NULL, parseFlags); > +if (virFileReadAll(filename, 1024*1024*10, &xmlStrPtr) < 0) > +return NULL; > +xmlStr = xmlStrPtr; > } > + xml = xmlCtxtReadDoc(pctxt, BAD_CAST xmlStr, url, NULL, parseFlag

[PATCH] vmx: Allow '*' to appear in VMX file keys

owed in keys so this failed to parse with the error: VIR_ERR_CONF_SYNTAX: VIR_FROM_CONF: configuration file syntax error: memory conf:74: expecting an assignment Resolves: https://issues.redhat.com/browse/RHEL-58446 Thanks: Daniel Berrange Signed-off-by: Richard W.M. Jones --- src/util/virconf

Re: [PATCH] docs: Document watchdog action=dump slightly more

y dump the guest, beware that after the > + dump the guest will be resumed :since:`Since 0.8.7` > - 'inject-nmi' - inject a non-maskable interrupt into the guest >:since:`Since 1.2.17` Acked-by: Richard W.M. Jones -- Richard Jones, Virtualization Group, Red Hat htt

[libvirt ci] Why no artifacts for macOS & FreeBSD?

[I couldn't find out where to send questions / bugs related to libvirt CI, so here I am ...] https://gitlab.com/nbdkit/libnbd/-/pipelines/1493147187 It would be much easier to fix the above pipeline (which doesn't reproduce locally) if I could download artifacts for the failing builds. However w

Re: [PATCH v2 3/3] util/xml: open XML files before calling libxml2

xmlconfdata/nonexistent-file.xml' > +Failed to open file 'ABS_SRCDIR/qemuxmlconfdata/nonexistent-file.xml': No > such file or directory I know it doesn't matter as the file is literally not there, but isn't that supposed to be @ABS_SRCDIR@ or similar? Anyway the series lo

Re: [libvirt ci] Why no artifacts for macOS & FreeBSD?

On Mon, Oct 14, 2024 at 06:26:23PM +0100, Richard W.M. Jones wrote: > On Mon, Oct 14, 2024 at 06:21:32PM +0100, Richard W.M. Jones wrote: > > On Mon, Oct 14, 2024 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > > > On Sat, Oct 12, 2024 at 11:57:57AM +0100, Richard W.M. Jones

Re: [libvirt ci] Why no artifacts for macOS & FreeBSD?

On Mon, Oct 14, 2024 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > On Sat, Oct 12, 2024 at 11:57:57AM +0100, Richard W.M. Jones wrote: > > [I couldn't find out where to send questions / bugs related > > to libvirt CI, so here I am ...] > > > > https://gitl

Re: [libvirt ci] Why no artifacts for macOS & FreeBSD?

On Mon, Oct 14, 2024 at 06:21:32PM +0100, Richard W.M. Jones wrote: > On Mon, Oct 14, 2024 at 09:48:51AM +0100, Daniel P. Berrangé wrote: > > On Sat, Oct 12, 2024 at 11:57:57AM +0100, Richard W.M. Jones wrote: > > > [I couldn't find out where to send questions / bugs rela

Re: [libvirt PATCH] json: do not call json_tokener_free with NULL

tok = json_tokener_new(); > +if (!tok) { > +ERROR("failed to create JSON tokener"); > +goto cleanup; > +} > json_tokener_set_flags(tok, jsonflags); > > do { > @@ -162,7 +166,8 @@ findMACs(const char *file, > >

[PATCH] docs: Document how to enable coredumps for session qemu

Thanks: Daniel P. Berrangé Signed-off-by: Richard W.M. Jones --- docs/kbase/qemu-core-dump.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/kbase/qemu-core-dump.rst b/docs/kbase/qemu-core-dump.rst index 5c3781cf90..4bd3ff0b9d 100644 --- a/docs/kbase/qemu-core-dump.rst +++ b

Re: [PATCH] qemu: enable QEMU core dump by default on Linux

faults to permit core dumps. > > Signed-off-by: Daniel P. Berrangé Yes yes yes! Reviewed-by: Richard W.M. Jones > --- > src/qemu/qemu.conf.in | 8 +--- > src/qemu/qemu_conf.c | 10 +++--- > 2 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a

[PATCH] vmx: Get the VMware boolean uefi.secureBoot.enabled

Some VMware guests have a boolean uefi.secureBoot.enabled. If found, and it's set to "TRUE", and if it's a UEFI guest, then add this clause into the domain XML: This approximates the meaning of this VMware flag. Signed-off-by: Richard W.M.

Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: > == > > I'm sending this as an RFC just because what it's doing feels kind of > dirty - directly examining XDG_RUNTIME_DIR seems like an "end run" > around the Glib API. If anyone has a better idea of what to do, please > give detai

Re: [PATCH 3/3] remote: expand some debug messages for socket detection

For the series: Reviewed-by: Richard W.M. Jones -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com nbdkit - Flexible, fast NBD server with plugins https://gitlab.com/nbdkit/nbdkit

Re: [PATCH 1/3] remote: improve error message when no URI is set

On Thu, Apr 17, 2025 at 06:11:56PM +0100, Daniel P. Berrangé wrote: > From: Daniel P. Berrangé > > When no URI is set we try to guess what daemon to connect to by looking > for any listening sockets. If there are no listening sockets, however, > we don't even know what daemon the user expected to

Re: Support cloning of VMs - part 2

On Mon, Jul 07, 2025 at 02:19:10PM +0100, Mark Cave-Ayland wrote: > Hi all, > > I'm currently looking at how libvirt can be used to clone a saved > VM, and have been focusing on the previous thread on this topic at > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/YXN2L2PYL