From: Chun Feng Wu
Implement new throttle cmds
* Add new virsh cmds: domthrottlegroupset, domthrottlegrouplist,
domthrottlegroupinfo, domthrottlegroupdel
* Add doc for new cmds at docs/manpages/virsh.rst
* Add cmd helper "virshDomainThrottleGroupCompleter", which is used by
domthrottlegroups
From: Chun Feng Wu
Introduce throttle filter along with corresponding operations.
* Define new struct 'virDomainThrottleFilterDef' and corresponding destructor
* Update _virDomainDiskDef to include virDomainThrottleFilterDef
* Support throttle filter "Parse" and "Format" for operations between D
From: Chun Feng Wu
ThrottleGroup lifecycle implementation, note, in QOM, throttlegroup name is
prefixed with
"throttle-" to clearly separate throttle group objects into their own namespace.
* "qemuDomainSetThrottleGroup", this method is to add("object-add") or
update("qom-set")
throttlegroup
On Thu, Mar 20, 2025 at 14:57:48 +, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Signed-off-by: Daniel P. Berrangé
> ---
> NEWS.rst | 17 +
> 1 file changed, 17 insertions(+)
Reviewed-by: Peter Krempa
On Thu, Mar 20, 2025 at 17:36:27 +0100, Ján Tomko wrote:
> On a Thursday in 2025, Peter Krempa via Devel wrote:
> > From: Peter Krempa
> >
> > Signed-off-by: Peter Krempa
> > ---
> > NEWS.rst | 10 ++
> > 1 file changed, 10 insertions(+)
&g
On Fri, Mar 21, 2025 at 11:35:36 +, Daniel P. Berrangé wrote:
> On Fri, Mar 21, 2025 at 12:15:19PM +0100, Peter Krempa via Devel wrote:
> > On Thu, Mar 20, 2025 at 17:36:27 +0100, Ján Tomko wrote:
> > > On a Thursday in 2025, Peter Krempa via Devel wrote:
> >
On Tue, Mar 25, 2025 at 11:10:08 +0530, Harikumar Rajkumar wrote:
Missing developer certificate of origin certification:
https://libvirt.org/hacking.html#developer-certificate-of-origin
> ---
> NEWS.rst | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index
From: Chun Feng Wu
extract common methods from "qemuDomainSetBlockIoTune" to be reused
by throttle handling later, common methods include:
* "qemuDomainValidateBlockIoTune", which is to validate that PARAMS
contains only recognized parameter names with correct types
* "qemuDomainSetBlockIoTuneF
From: Chun Feng Wu
Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup"
* Test qemuMonitorJSONGetThrottleGroup
* Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through
"qom-set"
Signed-off-by: Chun Feng Wu
* fix test
Signed-off-by: Harikumar Rajkumar
* Deleted gett
From: Chun Feng Wu
Define macro for iotune options, this macro is used by opts_blkdeviotune and
later throttle group opts
Signed-off-by: Chun Feng Wu
Reviewed-by: Peter Krempa
Signed-off-by: Peter Krempa
---
tools/virsh-domain.c | 308 ++-
1 file chang
From: Chun Feng Wu
Introduce schema for defining '' element which
configures throttling groups which can be configured for multiple
disks.
* Refactor "diskIoTune" to extract common schema "iotune"
* Add new elements ''
* contains defintion, which references
"iotune"
Signed-off-by: Chun Feng
From: Chun Feng Wu
Refactor iotune verification, and verify some rules
* Disk iotune validation can be reused for throttle group validation,
refactor it into common method "virDomainDiskIoTuneValidate"
* Add "virDomainDefValidateThrottleGroups" to validate throttle groups,
which in turn call
From: Chun Feng Wu
Update "attach_disk" to support new option: throttle-groups to
form filter chain in QEMU for specific disk
Signed-off-by: Chun Feng Wu
* apply suggested coding style changes.
Signed-off-by: Harikumar Rajkumar
* Fixed alignment of child elements in the XML
* Fixed placemen
From: Chun Feng Wu
Introduce schema for defining '' element which
references throttling groups to form filter chain in qemu for specific
disk
* Add new elements ''
* can include multiple throttlegroup references to
form filter chain in qemu
* Chained throttle filters feature in qemu is descri
v9 of the throttle filtering series with my reviews and R-b tags
applied.
Requires
[PATCH 0/5] qemu: Two block job fixes
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/TX2YAFHOFO46GR7WVQSPURWHL6O2KCDZ/
to be applied to work properly.
Posting for tracking and possibly fi
From: Chun Feng Wu
* Add tests for throttlegroup domain xml processing, including
groups referenced and not referenced by filters
* Add tests for throttlefilter domain xml processing, including
throttle group referenced by different disks
* Add negative test case to report error when iotune is co
From: Chun Feng Wu
For hot attaching/detaching
* Leverage qemuBlockThrottleFiltersData to prepare attaching/detaching
throttle filter data for qemuMonitorBlockdevAdd and qemuMonitorBlockdevDel
* For hot attaching, within qemuDomainAttachDiskGeneric,prepare throttle
filters json data, and crea
From: Harikumar Rajkumar
* Add tests for throttlefilter nodename parse and format for statusxml
(disk/privateData/nodenames/nodename with type='throttle-filter')
* Add iotune limited disk tests to make sure iotune refactory works
Signed-off-by: Chun Feng Wu
* Isolate status xml test
Signed-of
From: Chun Feng Wu
Introduce throttlegroup into domain and provide corresponding methods
* Define new struct 'virDomainThrottleGroupDef' and corresponding destructor
* Add operations(Add, Update, Del, ByName, Copy, Free) for
'virDomainThrottleGroupDef'
* Update _virDomainDef to include virDomai
On Sun, Mar 16, 2025 at 12:18:21 +0400, marcandre.lureau--- via Devel wrote:
> From: Marc-André Lureau
> Marc-André Lureau (20):
> build-sys: drop -Winline when optimization=g
> build: fix -Werror=maybe-uninitialized
> qemu-slirp: drop unneeded check for OOM
> util: annotate non-null argum
From: Chun Feng Wu
Defined new public APIs:
* virDomainSetThrottleGroup to add or update throttlegroup within specific
domain,
it will be referenced by throttlefilter later in disk to do limits
* virDomainGetThrottleGroup to get throttlegroup info, old-style is discarded
(APIs to query first
From: Chun Feng Wu
It contains throttle filter nodename processing(new nodename,
topnodename, parse and format nodename), throttle filter
attaching/detaching preparation and implementation.
* Updated "qemuDomainDiskGetTopNodename", so if throttlefilter is used
together with copyOnRead, top nod
On Tue, Mar 18, 2025 at 18:13:57 +0100, Ján Tomko via Devel wrote:
> On a Thursday in 2025, Collin Walling wrote:
> > From: David Judkovics
> >
> > Add new virsh command 'hypervisor-cpu-models'. Command pulls from the
> > existing domcapabilities XML and uses xpath to parse CPU model strings.
>
From: Peter Krempa
When the agent disappears after geting a proper command we ought to
report the same error code as if we timed out as it's uncertain whether
the guest agent did anything.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
From: Peter Krempa
As the guest agent code uses timeouts it is possible that we stop
waiting before the guest agent replies. If this happens while syncing
everything is okay because we didn't send any state-changing command.
In case when the timeout happens after a real command was transmitted
i
This series introduces two new error codes aimed to help management
applications to better in deciding when corner cases of guest agent
interaction are encountered.
Peter Krempa (8):
lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT'
qemu: agent: Differentiate timeouts when syncing from com
From: Peter Krempa
The 'ret' variable is set to 0 before a call which can theoretically
fail. Not in practice really as the failure scenarion includes only
object initialization.
Since the code already has another variable for checking monitor returns
use that one properly so that the code makes
From: Peter Krempa
In the two cases when we know that the command returned failure switch
to the new error code so that management applications can
programatically detect failure of the guest agent command.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 4 ++--
1 file changed, 2 inser
From: Chun Feng Wu
This change contains QMP requests for ThrottleGroup
* ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup"
* ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup"
* ThrottleGroup is deleted by reusing "qemuMonitorDelObject"
* ThrottleGroup is ad
On Thu, Mar 20, 2025 at 08:56:04 +0100, Maximilian Immanuel Brandtner wrote:
> I've been working on an RFC patch-set to implement resizing for
> consoles in QEMU. Now that the patch-set is in review I've turned my
> attention to bringing this feature to libvirt.
>
> With the QEMU patch-set there a
On Fri, Mar 21, 2025 at 11:53:50 +, Daniel P. Berrangé wrote:
> On Fri, Mar 21, 2025 at 12:40:39PM +0100, Peter Krempa wrote:
> > On Fri, Mar 21, 2025 at 11:35:36 +, Daniel P. Berrangé wrote:
> > > On Fri, Mar 21, 2025 at 12:15:19PM +0100, Peter Krempa via Devel wrote:
&
On Wed, Mar 26, 2025 at 15:07:37 +0100, Ján Tomko wrote:
> On a Wednesday in 2025, Peter Krempa via Devel wrote:
> > From: Peter Krempa
> >
> > In esxConnectListAllDomains if the lookup of the VM name and UUID fails
> > for a single VM (possible e.g. with broken s
On Wed, Mar 26, 2025 at 13:39:55 +0100, Peter Krempa via Devel wrote:
> From: Peter Krempa
>
> In esxConnectListAllDomains if the lookup of the VM name and UUID fails
> for a single VM (possible e.g. with broken storage) the whole API would
> return failure even when there
From: Peter Krempa
Disambiguate the case from other types of error.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index d4eb4897a4..ee0921eca6 100644
--- a/src/qemu/qemu_ag
From: Peter Krempa
Signed-off-by: Peter Krempa
---
NEWS.rst | 20
1 file changed, 20 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 18d45656b8..2855ec77e4 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -15,6 +15,11 @@ v11.2.0 (unreleased)
* **Removed features**
+ * Remo
From: Peter Krempa
In esxConnectListAllDomains if the lookup of the VM name and UUID fails
for a single VM (possible e.g. with broken storage) the whole API would
return failure even when there are working VMs.
Rework the lookup so that if a subset fails we ignore the failure on
those. We report
From: Peter Krempa
While exploring an idea that modified the setup of the mirror I've
noticed that the code setting up the 'discard' field in the block copy
job happens after setup of the stroage source, while normally e.g. in
qemuDomainPrepareStorageSource() it happens before.
Reorder it despit
From: Peter Krempa
The function is referenced only from within qemu_domain.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c3ca
From: Peter Krempa
If the copy job fails to start up when calling the 'blockdev-mirror'
command the code would call qemuDomainStorageSourceChainAccessRevoke()
twice; once right after the monitor call and the second time in the
'endjob' section.
Remove the one directly after the monitor call and
From: Peter Krempa
The code is no longer used.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 17 -
src/qemu/qemu_monitor.h | 5 -
src/qemu/qemu_monitor_json.c | 28
src/qemu/qemu_monitor_json.h | 6 --
tests/qemumonit
From: Peter Krempa
The capability wasn't used since it's inception. It now refers to a
deprecated QMP command. Drop it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemuc
From: Peter Krempa
The 'block-export-add' command was added in qemu-5.2 so we now use it
unconditionally.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdat
From: Peter Krempa
Commit 8824af826d3 (and also commit 073bf167843 before it) which bumped
minimu, qemu version forgot to update the qemu driver documentation page
Fixes: 8824af826d3
Signed-off-by: Peter Krempa
---
docs/drvqemu.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Three patches fixing various bits in block copy job setup.
Peter Krempa (3):
qemu: domain: Unexport
'qemuDomainPrepareStorageSourceBlockdevNodename'
qemuDomainBlockCopyCommon: Reorder setup of 'mirror' data
qemuDomainBlockCopyCommon: Don't revoke access to file twice on
failure
src
From: Peter Krempa
As the cleanup section is empty; the code can now return directly on
errors.
Signed-off-by: Peter Krempa
---
src/util/virhostcpu.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/src/util/virhostcpu.c b/src/util/virhostcp
On Fri, Feb 21, 2025 at 14:36:50 +0100, Michal Prívozník wrote:
> On 2/20/25 23:26, Ján Tomko wrote:
> > Similarly to `desc` and `net-desc`, return an empty string if
> > there is no metadata to be returned.
> >
> > https://issues.redhat.com/browse/RHEL-27172
> >
> > Signed-off-by: Ján Tomko
> >
From: Peter Krempa
There are no other callers.
Signed-off-by: Peter Krempa
---
src/conf/storage_source_conf.c | 19 +--
src/conf/storage_source_conf.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/src/conf/stora
From: Peter Krempa
Use a 'switch' statement instead of a bunch of if statements to do
validation and selection what to parse.
Remove the pre-clearing of the struct as we always alocate cleared
memory for it and we can reorder assignments to avoid the need for
cleanup.
Signed-off-by: Peter Kremp
From: Peter Krempa
In deployments where libvirt is containerized together with the VM it
may be hard for the management application to access listening sockets
inside the container from the outside.
This patch implements "transport='fd'" for the NBD server definition for
backups which allows to
From: Peter Krempa
Upcoming patches will extend the FD passing infrastructure to the backup
job so that users can pass an opened socket instead of qemu opening it
themself to bypass difficulities caused by containerizing libvirt.
Signed-off-by: Peter Krempa
---
src/conf/storage_source_conf.c |
From: Peter Krempa
Signed-off-by: Peter Krempa
---
.../domainbackupxml2xmlin/backup-pull-fd.xml | 22 ++
.../domainbackupxml2xmlout/backup-pull-fd.xml | 23 +++
tests/genericxml2xmltest.c| 1 +
3 files changed, 46 insertions(+)
create mode
From: Peter Krempa
The macro checking monitor object state also logs information such as
the monitor object pointer and the number of the monitor FD.
Name the field 'monfd' instead of 'fd' as it's confusing when debugging
FD pasing via monitor.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_mo
See 6/8 for justification.
Peter Krempa (8):
virDomainStorageNetworkParseHost: Remove unpopulated 'transport'
variable
virDomainStorageNetworkParseHost: Refactor cleanup
conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD
virStorageNetHostDefClear: Move into virStorageNetHostDefFree
qemu:
From: Peter Krempa
Since the refactor to use proper enum type for the network transport the
'transport' variable is no longer filled. Remove it and fix the error
message which references it without using NULLSTR.
Fixes: 452695926dc
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 3 +--
On Tue, Apr 01, 2025 at 18:57:30 +0300, Vladimir Sementsov-Ogievskiy wrote:
> For change, pause, resume, complete, dismiss and finalize actions
> corresponding job- and block-job commands are almost equal. The
> difference is in find_block_job_locked() vs find_job_locked()
> functions. What's diffe
On Wed, Apr 02, 2025 at 06:56:17 +, Duan, Zhenzhong wrote:
> Hi,
>
> When -Dlibnl=disabled, build failed as below:
>
> ../src/util/virnetdevbridge.c: In function 'virNetDevBridgeSetupVlans':
> ../src/util/virnetdevbridge.c:326:9: error: implicit declaration of function
> 'virNetlinkBridgeVla
RIP HMP use in libvirt:
2007-02-14 [1] - 2025-04-02
[1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948
Peter Krempa (6):
qemu: domain: Don't check return value of 'virCPUDefCopy'
qemuSnapshotCreateActiveInternal: Fix error logic
qemu: snapshot: Always assume support for
QEMU_CAPS_SNAPSHOT_I
From: Peter Krempa
As 'virCPUDefCopy' can't fail any more (without aborting) remove the
last two return value checks.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.
From: Peter Krempa
Now that we've replaced the final two HMP commands used by libvirt we
can fully drop the 'text' monitor support.
The only thing we keep is the HMP passtrhough with
'virsh qemu-monitor-command'.
Signed-off-by: Peter Krempa
---
po/POTFILES | 1 -
src/qemu/me
From: Peter Krempa
The code now always assumes support for the QMP internal snapshot
commands so the capability is no longer needed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
On Wed, Apr 02, 2025 at 15:58:28 +0800, Zhenzhong Duan wrote:
> Currently libvirt favors /run instead of /var/run, but for local build
> run test, a prefix path is still needed to avoid interoperating with OS
> vendor provided binaries.
Could you please elaborate?
>
> Signed-off-by: Zhenzhong Du
From: Peter Krempa
The block copy operation is supposed to just move the disk to a new
destination. While in certain scenarios it'd make sense to drop the
copy-on-read layer, the definition would not correspond to it.
This was caused by a fix to the behaviour of the block job after
conversion to
Peter Krempa (5):
qemu: monitor: Wire up 'replaces' attribute for 'blockdev-mirror'
qemu: Do not replace filter nodes with virDomainBlockCopy
qemu: Remove return value from 'qemuHotplugRemoveManagedPR'
qemuDomainChangeEjectableMedia: Separate rollback and success code
paths
qemuHotplu
From: Peter Krempa
The 'replaces' field controls which node will be replaced by the job.
This can be used to e.g. keep filter nodes in place after the copy
finishes.
This will be used to keep the 'copy-on-read' and 'throttle' layers in
place after a copy.
This patch wires up the monitor and tes
On Wed, Feb 19, 2025 at 22:27:04 +0530, Harikumar Rajkumar wrote:
> *** Support block disk along with throttle filters ***
>
> Chun Feng Wu (17):
> schema: Add new domain elements to support multiple throttle groups
> schema: Add new domain elements to support multiple throttle filters
> con
From: Peter Krempa
The only place which actually checked the return value would skip code
e.g. to delete unused files or stop no longer used services. The rest of
the callers ignored the value.
As this is expected to be used on cleanup code paths which have no
possibility to report errors we sho
From: Peter Krempa
Calls to 'qemuHotplugRemoveManagedPR' needed to be guarded by a check if
the removed elements actually caused us to add the manager in the first
place.
The two new calls added in commit 1697323bfe6000c2f5a2519c06f0ba81 were
not guarded by such check and thus would spam the deb
From: Peter Krempa
Do not use the rollback code path on success just to avoid extra call to
qemuHotplugRemoveManagedPR.
Rename the label and use it only when rolling back.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 37 +++--
1 file changed, 15 in
t is not checked
that happens regularly.
> On Mon, Apr 7, 2025 at 3:11 PM Peter Krempa wrote:
>
> > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote:
> > > On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel
> > wrote:
> > > &
On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote:
> On 4/7/25 15:11, Peter Krempa via Devel wrote:
> > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote:
> >> On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote:
[...]
&g
From: Peter Krempa
The 'virNodeInfo' field for CPU frequency is named 'mhz'. The docs were
mentioning 'mHZ', which is neither the field name nor proper spelling of
the unit.
Reword the paragraph to mention "CPU frequency" instead and explicitly
name the field in virNodeInfo struct.
Signed-off-b
Peter Krempa (4):
qemu: block: Always assume support for 'block-export-add'
qemu: monitor: Drop wrappers for 'nbd-server-add'
qemu: capabilities: Retire QEMU_CAPS_BLOCK_EXPORT_ADD
qemu: capabilities: Retire QEMU_CAPS_NBD_BITMAP
src/qemu/qemu_block.c | 7 -
src
From: Peter Krempa
'block-export-add' QMP command which replaces 'nbd-server-add' was
introduced in qemu-5.2. We can thus drop the old code now.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu
From: Peter Krempa
When connecting to "esx://" URI there's code which prints a warning that
the path is not "empty". The check validates that "uri->path" is "/".
In case when the user uses URI such as:
esx://hostname
the warning is printed as well. Since there is no effective difference
betwe
From: Peter Krempa
Add the news entry stating that it's safe to ignore the error.
Signed-off-by: Peter Krempa
---
NEWS.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 2608086717..18b873abe9 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -34,6 +34,16 @@ v1
On Tue, Apr 08, 2025 at 20:21:13 +0200, Kirill Shchetiniuk wrote:
> On Mon, Apr 07, 2025 at 03:59:25PM +0200, Peter Krempa wrote:
> > On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote:
> > > On 4/7/25 15:11, Peter Krempa via Devel wrote:
> > > > On Mon,
On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote:
> Hi Steve, I apologize for the slow response.
>
> Steve Sistare writes:
>
> > Using qom-list and qom-get to get all the nodes and property values in a
> > QOM tree can take multiple seconds because it requires 1000's of
From: Peter Krempa
'qemuBlockThrottleFiltersDetach' crashes if @data is NULL. That can
happen in 'qemuDomainAttachDiskGeneric' as it's used as a rollback path
in cases when we didn't yet initialize the filter struct.
Fix it by tolerating NULL @data.
Closes: https://gitlab.com/libvirt/libvirt/-/
From: Peter Krempa
'qemuBuildThrottleFiltersAttachPrepareBlockdev' can fail when
constructing JSON props, but otherwise always retruns a pointer even if
there's nothing to do.
The code in 'qemuDomainAttachDiskGeneric' didn't handle this properly as
it considered NULL as "nothing to do". Return t
From: Peter Krempa
Signed-off-by: Peter Krempa
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 4f1e8ecbdf..7b4dbd795b 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -50,6 +50,11 @@ v11.3.0 (unreleased)
to be logged in the system log. It is safe to i
Peter Krempa (3):
qemu: block: Don't crash if qemuBlockThrottleFiltersDetach gets NULL
@data
qemuDomainAttachDiskGeneric: Report errors from
'qemuBuildThrottleFiltersAttachPrepareBlockdev'
NEWS: Mention fix of crash on disk hotplug failure
NEWS.rst| 5 +
src/qemu
On Sun, Mar 16, 2025 at 12:18:39 +0400, marcandre.lureau--- via Devel wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Martin Kletzander
> ---
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index ca99e61896..2c137bb663 100644
>
On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote:
> When the new storage was created using virsh with --validate option
> following errors occurred:
>
> # virsh vol-create default --file vol-def.xml --validate
> error: Failed to create vol from vol-def.xml
> error: unsupp
Patches 1,2 cleanup the code the rest deals with docs.
Peter Krempa (5):
virHostCPUGetInfoPopulateLinux: Use automatic memory freeing
virHostCPUGetInfoPopulateLinux: Remove 'cleanup'
libvirt-host: Clarify/fix description of the CPU frequency field
virNodeGetInfo: Improve description of the
From: Peter Krempa
Use 'g_autfree' for the two temporary strings.
'sysfs_cpudir' was used in two places, one of which is in a loop. Add
another helper variable for it and declare the other one in the loop.
Signed-off-by: Peter Krempa
---
src/util/virhostcpu.c | 16 ++--
1 file cha
From: Peter Krempa
virNodeGetInfo due to the rigid desing of the filled struct can't
faithfully represent all topologies. Improve the description when that
happens and outline the fallback topology.
The function docs already state that users ought to use
virConnectGetCapabilities() instead.
Sig
From: Peter Krempa
Adapt the disclarimer about the data not being accurate in many cases
from the API docs to the virsh command using the aforementioned API.
Signed-off-by: Peter Krempa
---
docs/manpages/virsh.rst | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote:
> On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote:
> > When the new storage was created using virsh with --validate option
> > following errors occurred:
> >
> > # virsh vo
On Tue, Apr 08, 2025 at 00:55:04 +0800, yong.hu...@smartx.com wrote:
> From: Hyman Huang
>
> If EAGAIN or EINTR are returned from the gnutls_record_recv,
> GNU TLS suggests calling the gnutls_record_recv once again to
Since the guidance is about 'gnutls_record_recv' ...
> get the data. Refer to
Peter Krempa (2):
qemucapabilitiestest: Final update for qemu-10.0 release on x86_64
qemucapabilitiestest: Final update for qemu-10.0 release on x86_64 of
the 'amdsev' variant
.../caps_10.0.0_x86_64+amdsev.replies | 199 ++
.../caps_10.0.0_x86_64+amdsev.xml
From: Peter Krempa
Signed-off-by: Peter Krempa
---
.../caps_10.0.0_x86_64+amdsev.replies | 199 ++
.../caps_10.0.0_x86_64+amdsev.xml | 9 +-
2 files changed, 113 insertions(+), 95 deletions(-)
diff --git a/tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amds
On Tue, Jan 21, 2025 at 16:33:03 +0100, Shalini Chellathurai Saroja wrote:
> Let us introduce the xml and reply files for QEMU 10.0.0 on s390x.
>
> Notable changes:
> - new s390-ccw-virtio-10.0 machine type
> - old machine types (2.4 - 2.8) dropped
> - new CPU models
> - New device
From: Peter Krempa
Update the data after the release.
Notable changes:
- the 7.0 machine types became deprecated
Signed-off-by: Peter Krempa
---
.../caps_10.0.0_x86_64.replies | 16
.../qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 12 ++--
2 files
On Sun, Apr 27, 2025 at 19:48:03 +0800, honglei.w...@smartx.com wrote:
> From: ray
>
> This patch extends the disk bus support by introducing a new nvme-ns bus type.
>
> The nvme-ns bus disk needs to be attached to nvme controller. A controller
> can contain multiple nvme-ns disk devices.
>
> S
On Sun, Apr 27, 2025 at 19:48:04 +0800, honglei.w...@smartx.com wrote:
> From: ray
>
> Signed-off-by: ray
> ---
Generally patches adding a capability flag should only add the
capability flag. Thus you'll need to split this patch.
1) capability addition
- move it ahead to the beginning of t
On Fri, Apr 25, 2025 at 17:38:44 +0200, Markus Armbruster via Devel wrote:
> Pierrick Bouvier writes:
[...]
> To be precise: conditionals that use macros restricted to
> target-specific code, i.e. the ones poisoned by exec/poison.h. Let's
> call them target-specific QAPI conditionals.
>
> The
From: Peter Krempa
This is purely a devel-time problem in the test suite.
'qemuxmlactivetest' invokes the whole test worker twice, once for
inactive output and second time for active.
Now 'testQemuInfoInitArgs' returns a failure if the XML is invalid and
the test is skipped. On another invocati
On Sat, Mar 08, 2025 at 14:57:41 +0900, Akihiko Odaki wrote:
> usb-storage is a compound device that automatically creates a USB mass
> storage device and a SCSI device as its backend. Unfortunately it lacks
> some configuration options that are usually present with a SCSI device,
> and cannot repr
From: Peter Krempa
qemuRdpAvailable() is called from the capability filing code, thus:
- it must not report spurious errors
- it should not call any extra processes
We can solve the above by just checking existance of 'qemu-rdp' in the
path as:
- at the time of adding of qemuRdpAvailable() there
On Mon, Apr 14, 2025 at 15:06:09 +0300, Alexander Kuznetsov wrote:
> path is allocated by asprintf() and must be freed later if realloc() fails or
> at
> the end of each while() iteration
>
> Move the free() call out of LIBVIRT_NSS_GUEST macro and add another one if
> realloc() fails
>
> Found b
1 - 100 of 481 matches
Mail list logo
