. Berrangé
even though this patch does not apply for me for some reason, no idea why, it is
valid and our CI fails without it, hence
Reviewed-by: Martin Kletzander
---
ci/gitlab/builds.yml | 2 ++
ci/manifest.yml | 2 ++
2 files changed, 4 insertions(+)
diff --git a/ci/gitlab/builds.yml b
On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote:
On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote:
Temporarily disable '-Wmissing-include-dirs' becuase the
libtirpc pkg-confog file has a bogus include dir. The
headers can fortunately still be found
ndrea Bolognani (5):
rpm: Shuffle BuildRequires around
rpm: Split call to mingw_debug_package
rpm: Introduce with_mingw32/with_mingw64
rpm: Introduce with_native
ci: Build RPMs on MinGW
Reviewed-by: Martin Kletzander
.gitlab-ci.yml | 11 +-
ci/jobs.sh | 23 ++-
libvirt.spec.in
s unstable. Use g_qsort_with_data from glib instead
+sc_prohibit_qsort:
+ @prohibit='\
Shouldn't we also prohibit qsort_r ?
With that added, this series is
Reviewed-by: Martin Kletzander
+ $(_sc_search_regexp)
+
# Insist on correct types for [pug]id.
sc_correct_id_type
This will improve an error message later on.
Signed-off-by: Martin Kletzander
---
src/remote/remote_daemon_dispatch.c | 2 +-
src/remote/remote_sockets.c | 11 +--
src/remote/remote_sockets.h | 2 +-
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/src
When opening a libvirt connection with no URI set and no daemon running the
error message might be confusing at times, so these patches are trying to
mitigate such confusion.
Martin Kletzander (2):
Report first tried socket from remoteProbeSystemDriverFromSocket
Report better error message in
27; and no URI is set, is any virt
daemon or systemd socket unit started?
Resolves: https://issues.redhat.com/browse/RHEL-700
Signed-off-by: Martin Kletzander
---
src/remote/remote_sockets.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/remote/remote_socke
On Tue, Nov 28, 2023 at 02:04:12PM +0100, Peter Krempa wrote:
On Tue, Nov 28, 2023 at 13:02:39 +0100, Martin Kletzander wrote:
This will improve an error message later on.
Signed-off-by: Martin Kletzander
---
src/remote/remote_daemon_dispatch.c | 2 +-
src/remote/remote_sockets.c
On Tue, Nov 28, 2023 at 02:15:59PM +0100, Peter Krempa wrote:
On Tue, Nov 28, 2023 at 14:04:12 +0100, Peter Krempa wrote:
On Tue, Nov 28, 2023 at 13:02:39 +0100, Martin Kletzander wrote:
> This will improve an error message later on.
>
> Signed-off-by: Martin Kletzander
> ---
&
On Tue, Nov 28, 2023 at 01:00:53PM +, Richard W.M. Jones wrote:
On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote:
Before this patch users might be confused with the error when no daemon
nor systemd socket unit is running due to the error message being a bit
vague when
On Tue, Nov 28, 2023 at 02:29:20PM +0100, Peter Krempa wrote:
On Tue, Nov 28, 2023 at 13:22:47 +, Daniel P. Berrangé wrote:
On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote:
> Before this patch users might be confused with the error when no daemon
> nor systemd socke
On Wed, Nov 29, 2023 at 12:30:19PM -0600, Andrea Bolognani wrote:
On Wed, Nov 29, 2023 at 10:49:23AM +, Richard W.M. Jones wrote:
On Wed, Nov 29, 2023 at 05:44:59AM -0500, Andrea Bolognani wrote:
> On Wed, Nov 29, 2023 at 10:09:36AM +, Richard W.M. Jones wrote:
> > Why is it exactly that
On Wed, Nov 29, 2023 at 06:33:54PM +, Richard W.M. Jones wrote:
Can we have the error message include a link to this page?
https://wiki.libvirt.org/Failed_to_connect_to_the_hypervisor.html
I think we could, although I'd be a bit afraid of the precedence which,
by itself is not that bad, b
On Thu, Nov 30, 2023 at 09:48:10AM +, Richard W.M. Jones wrote:
On Thu, Nov 30, 2023 at 10:06:38AM +0100, Peter Krempa wrote:
On Thu, Nov 30, 2023 at 09:49:56 +0100, Martin Kletzander wrote:
> On Wed, Nov 29, 2023 at 06:33:54PM +, Richard W.M. Jones wrote:
> >
> > Can we
On Mon, Dec 04, 2023 at 12:15:11PM +0100, Andrea Bolognani wrote:
Andrea Bolognani (2):
docs: Use DuckDuckGo for website/wiki search
docs: Mention use of DuckDuckGo
Reviewed-by: Martin Kletzander
docs/css/libvirt.css | 2 +-
docs/js/main.js | 16 +++-
docs/page.xsl
master
to = devel@lists.libvirt.org
-prefix = libvirt PATCH
+prefix = PATCH
You can remove it as that's the default ;)
Reviewed-by: Martin Kletzander
suppresscc = misc-by
--
2.43.0
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe s
On Tue, Dec 05, 2023 at 10:57:50AM +0100, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (2):
qemu: Move memory device coldplug into a separate function
qemu: Relax check for memory device coldplug
Reviewed-by: Martin Kletzander
src/qemu/qemu_driver.c | 45
ned-off-by: Anastasia Belova
Reviewed-by: Martin Kletzander
---
src/security/security_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/security/security_util.c b/src/security/security_util.c
index a4e6687561..b96b4ccb1f 100644
--- a/src/security/security_util.c
here, but I can fix that before pushing.
Reviewed-by: Martin Kletzander
and thanks for the patch.
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
int virFileRelLinkPointsTo(const char *directory,
--
2.30.2
___
Devel mailing list -- devel@lists.libvirt
By adding a link to an explanation in the kbase.
Signed-off-by: Martin Kletzander
---
v2:
- Do not print first socket path
- Add a kbase article explaining the details and solutions
- Add a link to said article
v1:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread
void
and remove return value checks.
I changed the commit message a bit and pushed it. Thanks for the patch.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Alexandra Diupina
Reviewed-by: Martin Kletzander
which I forgot to add to the commit O
ling 'virNetServerSetClientAuthenticated' as the lock
is not needed any more.
Resolves: https://issues.redhat.com/browse/RHEL-20337
Signed-off-by: Peter Krempa
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
___
mples: Introduce domtop")
Signed-off-by: Egor Makrushin
Reviewed-by: Martin Kletzander
Thanks for the patch.
---
examples/c/domain/domtop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/c/domain/domtop.c b/examples/c/domain/domtop.c
index dd35ec8661..65663a1c39 10
On Fri, Feb 02, 2024 at 01:57:37PM +0100, Ján Tomko wrote:
On a Thursday in 2024, Jiri Denemark wrote:
To reduce code duplication both function now use a common
virSystemdHasService helper.
Signed-off-by: Jiri Denemark
---
src/util/virsystemd.c | 76 ---
ow to do that somewhat elegantly, I'll post it soon.
This is fine the way it is.
Reviewed-by: Martin Kletzander
Andrea Bolognani (3):
all: Don't use 'grep -q'
syntax-check: Sync with gnulib
syntax-check: Drop 'syntax-check' tar
To be used in the following commit.
Signed-off-by: Martin Kletzander
---
meson.build | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index dbd9cad6df5a..2f3d73b93085 100644
--- a/meson.build
+++ b/meson.build
@@ -795,12 +795,17
Inspired by:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/TSKYLWDTNPIJQ4PWVAWXHHQIQQI7NG2O/
Martin Kletzander (2):
build: Split optional programs into test and rest
build: Let users know not all tests might run
meson.build | 21 -
1
We warned users before the meson times, so do like an S Club 7 and bring
it all back.
Add the information into the 'Miscellaneous' section of the summary,
because even though using `warning()` looks better, it scrolls on by
once the summary is printed.
Signed-off-by: Martin
On Mon, Feb 19, 2024 at 04:47:52AM -0800, Andrea Bolognani wrote:
On Mon, Feb 19, 2024 at 10:35:14AM +0100, Martin Kletzander wrote:
We warned users before the meson times, so do like an S Club 7 and bring
it all back.
Add the information into the 'Miscellaneous' section of t
On Tue, Feb 20, 2024 at 04:53:29PM +0100, Michal Privoznik wrote:
As of v9.8.0-rc1~7 we check whether two devices don't
overlap (since we allow setting where a device should
be mapped to). We do this pretty straightforward, by comparing
start and end address of each device combination.
But sin
On Wed, Feb 21, 2024 at 05:40:05PM +0100, Michal Prívozník wrote:
On 2/20/24 17:29, Martin Kletzander wrote:
On Tue, Feb 20, 2024 at 04:53:29PM +0100, Michal Privoznik wrote:
As of v9.8.0-rc1~7 we check whether two devices don't
overlap (since we allow setting where a device should
be m
the NVDIMM
part) and thus it is valid.
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le
Add debug print missing from BSD
Reviewed-by: Martin Kletzander
src/util/virprocess.c | 112 +-
1 file changed, 57 insertions(+), 55 deletions(-)
--
2.43.2
___
Devel mailing list -- devel@lists.libvirt.org
To unsu
On Mon, Dec 25, 2023 at 12:25:56AM +0300, Artem Chernyshev wrote:
virTimeMillisNowRaw() function are invariant now,
so, quite a few checks, dependent on it are become
irrelevant.
Fixes: f5e9bdb87f ("src: replace clock_gettime()/gettimeofday() with
g_get_real_time()")
Signed-off-by: Artem Cherny
#developer-certificate-of-origin
and git history.
With that added this is
Reviewed-by: Martin Kletzander
---
tools/libvirt-guests.sh.in | 37 ++---
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.s
On Mon, Jan 29, 2024 at 04:43:53PM -0500, mgal...@akamai.com wrote:
From: Michael Galaxy
We start by introducing a backwards-compatible, comma-separated
specification that will not break existing installations, such
as in the following example:
$ cat qemu.conf | grep memory_backing_dir
memory_
Ever since this function was introduced in 2012 it could've tried
filling in an extra interface name. That was made worse in 2019 when
the caller functions started accepting NULL arrays of size 0.
This is assigned CVE-2024-1441.
Signed-off-by: Martin Kletzander
Reported-by: Alexander Kuzn
On Mon, Mar 04, 2024 at 03:54:23PM -0600, Michael Galaxy wrote:
Hi Martin,
Answers inline. Thanks for helping with the review and all the tips!
On 3/1/24 04:00, Martin Kletzander wrote:
On Mon, Jan 29, 2024 at 04:43:53PM -0500, mgal...@akamai.com wrote:
From: Michael Galaxy
In our case
On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote:
On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote:
On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník wrote:
> On 3/18/24 12:45, Denis V. Lunev wrote:
> > On 3/18/24 11:42, Michal Prívozník wrote:
> >> On 3/17/24 16:0
On Mon, Mar 18, 2024 at 09:35:32PM +0100, Denis V. Lunev wrote:
On 3/18/24 15:25, Martin Kletzander wrote:
On Mon, Mar 18, 2024 at 02:25:53PM +0100, Pavel Hrdina wrote:
On Mon, Mar 18, 2024 at 01:31:27PM +0100, Peter Krempa wrote:
On Mon, Mar 18, 2024 at 13:14:54 +0100, Michal Prívozník wrote
On Mon, Apr 22, 2024 at 01:38:38PM +0200, Michal Privoznik wrote:
This is a helper that parses /sys/devices/system/cpu/isolated
into a virBitmap. It's going to be needed soon.
Signed-off-by: Michal Privoznik
---
src/libvirt_private.syms | 1 +
src/util/virhostcpu.c| 21 +
On Mon, Apr 22, 2024 at 02:02:28PM +0100, Daniel P. Berrangé wrote:
On Mon, Apr 22, 2024 at 02:29:32PM +0200, Martin Kletzander wrote:
On Mon, Apr 22, 2024 at 01:38:38PM +0200, Michal Privoznik wrote:
> This is a helper that parses /sys/devices/system/cpu/isolated
> into a virBitmap. It&#
sues.redhat.com/browse/RHEL-32182
Signed-off-by: Martin Kletzander
---
src/vmx/vmx.c| 12 +++
tests/vmx2xmldata/esx-in-the-wild-13.vmx | 97
tests/vmx2xmldata/esx-in-the-wild-13.xml | 55 ++
tests/vmx2xmltest.c
On Thu, Apr 25, 2024 at 05:30:24PM +0200, Peter Krempa wrote:
On Thu, Apr 25, 2024 at 14:12:54 +0200, Martin Kletzander wrote:
When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual
address for it is saved in serialX.vspc in which case the
serialX.fileName is most probably
On Fri, Apr 26, 2024 at 11:47:36AM +0100, Richard W.M. Jones wrote:
On Thu, Apr 25, 2024 at 02:12:54PM +0200, Martin Kletzander wrote:
When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual
address for it is saved in serialX.vspc in which case the
serialX.fileName is most
On Fri, Apr 26, 2024 at 10:34:46AM +0200, Martin Kletzander wrote:
On Thu, Apr 25, 2024 at 05:30:24PM +0200, Peter Krempa wrote:
On Thu, Apr 25, 2024 at 14:12:54 +0200, Martin Kletzander wrote:
When using vSPC (Virtual Serial Port Concentrator) in vSphere the actual
address for it is saved in
-by: Martin Kletzander
---
src/vmx/vmx.c| 2 +-
tests/vmx2xmldata/ethernet-vds-no-portid.vmx | 10
tests/vmx2xmldata/ethernet-vds-no-portid.xml | 24
3 files changed, 35 insertions(+), 1 deletion(-)
create mode 100644 tests/vmx2xmldata
On Sat, Mar 16, 2024 at 01:43:52AM +0530, Abhiram Tilak wrote:
The current way of updating a network configuration uses `virsh
net-update` to add, delete or modify entries. But with such a mechansim
one should know if an entry with current info already exists. Adding
modify-or-add option automati
On Wed, May 15, 2024 at 09:04:37AM +0200, Peter Krempa wrote:
Brown paper box was applied due to lack of paper bags.
Peter Krempa (3):
vsh: Fix '--help' option for virsh/virt-admin
virshtest: Add tests for '--help'
NEWS: Mention '--help' bug in virsh and vi
kflow. Update the message to
reflect this fact.
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
---
.github/workflows/lockdown.yml | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
index 74931
').
But fix is pretty simple: link mocks that rely on symbols from
the QEMU driver with the QEMU driver, well, its test suite
suitable version (libtest_qemu_driver.so).
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
---
This obsoletes some patches I've sent earlier:
Commit 23c47944882b added parsing of serial ports connected to vspc, but
the VM can also have a network serial port with an empty filename or no
filename at all. Parse these the same way, as a .
Resolves: https://issues.redhat.com/browse/RHEL-32182
Signed-off-by: Martin Kletzander
---
src/vmx
Distrubuted Switch configuration is a best-effort.
Resolves: https://issues.redhat.com/browse/RHEL-46099
Signed-off-by: Martin Kletzander
---
src/conf/domain_conf.c| 11 -
src/conf/schemas/domaincommon.rng | 24 ---
src/vmx/vmx.c
reset, but since that is a
rare case on its own and on top of that does not happen in any of our
long-running daemons with a logfile that might get monitored it should
be fine to leave it there.
Resolves: https://issues.redhat.com/browse/RHEL-32182
Signed-off-by: Martin Kletzander
---
src/vmx/
On Wed, May 29, 2024 at 06:49:06AM -0400, Abhiram Tilak wrote:
Provides completers for auth-type and source-format commands for
virsh pool-create-as and pool-define-as commands. Use Empty completers
for options where completions are not required.
Related Issue: https://gitlab.com/libvirt/libvirt
: f432114d9cf507a4047aa9dc1344b1c13356db08
Signed-off-by: Peter Krempa
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
t_unref)` instead even though it
does the same thing.
Reviewed-by: Martin Kletzander
if (!!g_atomic_int_dec_and_test(&driver->nactive) &&
driver->inhibitCallback)
driver->inhibitCallback(false, driver->inhibitOpaque);
--
2.44.2
signature.asc
Description: PGP signature
On Thu, Jul 25, 2024 at 12:57:58PM +0200, Michal Privoznik wrote:
The aim is to move parts of vir_event_thread_finalize() that MAY
block into a separate function, so that unrefing the a
s/ a//
"unrefing" vs. "unreffing" vs. "unref'ing", is that eve
On Thu, Jul 25, 2024 at 02:46:01PM +0100, Daniel P. Berrangé wrote:
On Thu, Jul 25, 2024 at 03:02:33PM +0200, Michal Prívozník wrote:
On 7/25/24 14:18, Daniel P. Berrangé wrote:
> On Thu, Jul 25, 2024 at 12:57:59PM +0200, Michal Privoznik wrote:
>> Currently, qemuProcessStop() unlocks given doma
On Wed, Jul 10, 2024 at 10:30:31AM +0200, Michal Prívozník wrote:
On 7/9/24 17:23, Adam Julis wrote:
The "modify" command allows to replace an existing Srv record
(some of its elements respectively: port, priority and weight).
The primary key used to choose the modify record is the remaining
par
On Mon, Aug 05, 2024 at 10:50:43AM +0200, Adam Julis wrote:
This reverts commit cf934c87cca32149675020ea595712aad25978e6.
The matching logic is flawed and it would complicate support of
this command.
Signed-off-by: Adam Julis
Thanks.
Reviewed-by: Martin Kletzander
signature.asc
On Wed, Jun 05, 2024 at 04:37:35PM -0400, mgal...@akamai.com wrote:
From: Michael Galaxy
Hi,
sorry for such a late reply and thank you for the patches. There are
few things that need tweaking and the series does not apply cleanly,
but fortunately there is only one conflict. Once needed adj
On Wed, Jun 05, 2024 at 04:37:36PM -0400, mgal...@akamai.com wrote:
From: Michael Galaxy
In our environment, we need to convert VMs into a live-update-comptabile
configuration "on-the-fly" (via live migration). More specifically: We
need to convert between anonymous memory-backed VMs and file-b
On Wed, Jun 05, 2024 at 04:37:37PM -0400, mgal...@akamai.com wrote:
From: Michael Galaxy
Update the associated test case.
This definitely needs to be part of the patch that changes this in qemu
driver code as otherwise the compilation would fail between these
patches and we require that the
On Wed, Jun 05, 2024 at 04:37:38PM -0400, mgal...@akamai.com wrote:
From: Michael Galaxy
Update the documentation and changelog accordingly to reflect
that the syntax of the memory_backing_dir setting has changed.
Signed-off-by: Michael Galaxy
---
NEWS.rst| 7 +++
docs/kbas
On Thu, Jun 13, 2024 at 04:43:14PM -0600, Jim Fehlig via Devel wrote:
This series is a RFC for support of QEMU's mapped-ram migration
capability [1] for saving and restoring VMs. It implements the first
part of the design approach we discussed for supporting parallel
save/restore [2]. In summary,
On Thu, Jun 13, 2024 at 04:43:20PM -0600, Jim Fehlig via Devel wrote:
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 2 +-
src/qemu/qemu_migration.c | 79
src/qemu/qemu_migration.h | 7 +++
src/qemu/qemu_monitor.c | 32
src/qemu/qemu_monit
On Thu, Jun 13, 2024 at 04:43:21PM -0600, Jim Fehlig via Devel wrote:
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration.c | 19 +++
src/qemu/qemu_migration.h | 3 ++-
src/qemu/qemu_process.c | 49 ---
src/qemu/qemu_process.h | 13 +++
On Tue, Aug 06, 2024 at 03:45:54PM -0500, Michael Galaxy wrote:
Thank you so much for the detailed comments. I'll work on those.
I believe you had a couple questions below on this one..inlined .
On 8/6/24 07:35, Martin Kletzander wrote:
On Wed, Jun 05, 2024 at 04:37:35PM -0400,
On Tue, Aug 06, 2024 at 03:50:45PM -0500, Michael Galaxy wrote:
Hi,
On 8/6/24 07:38, Martin Kletzander wrote:
On Wed, Jun 05, 2024 at 04:37:36PM -0400, mgal...@akamai.com wrote:
From: Michael Galaxy
if (src->mem.source != dst->mem.source) {
- virRepor
On Wed, Aug 07, 2024 at 10:20:49AM -0500, Michael Galaxy wrote:
Hi,
Answers below.
On 8/7/24 08:26, Martin Kletzander wrote:
On Tue, Aug 06, 2024 at 03:50:45PM -0500, Michael Galaxy wrote:
Hi,
On 8/6/24 07:38, Martin Kletzander wrote:
On Wed, Jun 05, 2024 at 04:37:36PM -0400, mgal
On Fri, Jul 26, 2024 at 10:52:18AM +0200, Adam Julis wrote:
GSList of iothreads is not allowed to be changed while the
virtual machine is running.
Resolves: https://issues.redhat.com/browse/RHEL-23607
Signed-off-by: Adam Julis
---
While the qemuDomainDiskChangeSupported() design primarily uses
On Fri, Jul 26, 2024 at 02:39:46PM +0200, Adam Julis wrote:
Disk targets are generated in virVMXParseConfig() with
virVMXGenerateDiskTarget(). It works on combination of
controller, fix offset, unit and prefix. While SCSI and SATA have
same prefix "sd", function virVMXGenerateDiskTarget() could
r
wrong nlmsg len". So I set out on
a quest to tame the netlink beast and though fierceful debugging and... Oh, I
forgot, nobody reads cover letters. Never mind.
Martin Kletzander (3):
virarptable: Properly calculate rtattr length
virarptable: Fix check for message length
virarptable: En
Use convenience macro from libnl3 which does almost the same thing we
were doing, but also aligns the payload length.
Signed-off-by: Martin Kletzander
---
src/util/virarptable.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virarptable.c b/src/util/virarptable.c
sending NLMSG_DONE and probably relied on the fact
that the parsing just stops after all the messages are walked through,
which the NLMSG_OK macro successfully did.
Resolves: https://issues.redhat.com/browse/RHEL-52449
Signed-off-by: Martin Kletzander
---
So technically this still has some issues
, struct rtattr in particular, which we are parsing later,
however the RTA_OK macro would've caught that anyway.
Signed-off-by: Martin Kletzander
---
src/util/virarptable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virarptable.c b/src/util/virarptable.c
On Fri, Aug 16, 2024 at 11:52:09PM -0400, Laine Stump wrote:
On 8/16/24 8:45 AM, Martin Kletzander wrote:
Somehow it happened that some kernels (I noticed this with 6.10.0 and 6.10.2 on
various machines) started sending NLMSG_DONE message (as they probably should've
even before),
This co
On Sat, Aug 17, 2024 at 01:07:45AM -0400, Laine Stump wrote:
On 8/16/24 8:45 AM, Martin Kletzander wrote:
Check for the last multipart message right as the first thing. The
presumption probably was that the last message might still contain a
payload we want to parse. However that cannot be
On Wed, Aug 14, 2024 at 11:29:44PM +0200, Ján Tomko wrote:
Fedora has decided to separate dtrace out of the systemtap-sdt-devel
package: https://fedoraproject.org/wiki/Changes/Separate_dtrace_package
Similarly, these are split in OpenSUSE Tumbleweed, however in a
backward-compatbile way:
https:/
_EMSR_BITMAP:
+if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON)
+virBufferAsprintf(&buf, ",%s=on", "hv-emsr-bitmap");
+ break;
+
What is the reason for us to only include the "on" state? Is it because
qem
On Fri, Aug 16, 2024 at 04:42:33PM +0200, Peter Krempa wrote:
Attempting to start qemu with or hotplug an empty 'usb-storage' based
disk results in the following error:
qemu-system-x86_64: -device
{"driver":"usb-storage","bus":"usb.0","port":"2","id":"usb-disk1","removable":true}:
drive proper
mmit linked from there).
Make 'qemuBlockStorageSourceChainDetach' tolerate NULL @data by simply
returning early.
Fixes: 894c6c5c1686cfbc1742493ed512a4795098b763
Resolves: https://issues.redhat.com/browse/RHEL-54550
Signed-off-by: Peter Krempa
Reviewed-by: Martin Kletzander
---
src/qemu/qemu_block.c | 3 +++
1 fil
On Wed, Aug 21, 2024 at 02:20:22PM +0200, Peter Krempa wrote:
On Wed, Aug 21, 2024 at 14:02:50 +0200, Martin Kletzander wrote:
On Fri, Aug 16, 2024 at 04:42:33PM +0200, Peter Krempa wrote:
> Attempting to start qemu with or hotplug an empty 'usb-storage' based
> disk results
On Tue, Aug 20, 2024 at 03:03:47PM +0100, Daniel P. Berrangé wrote:
On Mon, Aug 19, 2024 at 09:39:38PM +0530, Rayhan Faizel wrote:
This series introduces multiple fuzzers developed as part of Google Summer
of Code 2024. We adopt a structure-aware fuzzing approach to fuzz libvirt
XML formats. The
more nicer for someone with just a few lines.
Reviewed-by: Martin Kletzander
Any attempt to start the domain again would fail with "domain is already
being started" message which is misleading in this situation as it
doesn't reflect what's really happening.
Add a check for
On Tue, Aug 27, 2024 at 12:08:27PM +0300, Rayhan Faizel wrote:
On Tue, Aug 27, 2024 at 11:07 AM Martin Kletzander wrote:
That was unfortunate, but since Rayhan had the first implementation done
in a very short time we rather spent the rest of the time enhancing the
fuzzing and it definitely
On Tue, Aug 27, 2024 at 02:15:10PM +0300, Rayhan Faizel wrote:
On Tue, Aug 27, 2024 at 1:51 PM Martin Kletzander wrote:
On Tue, Aug 27, 2024 at 12:08:27PM +0300, Rayhan Faizel wrote:
>
>All the existing code is indeed still compiled as C. Only the fuzzing
>executables (under tests/f
Signed-off-by: Martin Kletzander
---
Pushed under the 'trivial' rule.
src/qemu/qemu_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3801ad623a40..609263d0263e 100644
--- a/src/qemu/qemu_driver.c
bunch of weird stuff I forgot to remove before posting.
I hope I did not miss any, but one can never be sure ;)
Martin Kletzander (8):
network: Do not update network ports for inactive networks
network: Do not call virNetworkObjUnsetDefTransient on start cleanup
network: Move port deletion into
It skips the cleanup from networkStartNetwork and the only other path
already checks if the network is active or not.
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
The semantic does not change since inside networkUpdatePort() (well,
networkNotifyPort, for which the former is a wrapper) exits for inactive
networks, but with an error we can easily avoid with this patch.
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 3 ++-
1 file changed
It will be more useful in there when calling from new places.
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index b16d524aa181..d27a7e9b88c4
The function networkShutdownNetwork already does that.
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 5b510a222cd2..b16d524aa181 100644
--- a/src/network
Just in case one needs a clean up.
Resolves: https://issues.redhat.com/browse/RHEL-50968
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index
Once networkUpdateState() identifies a dead network it should clean up
after it as well.
Resolves: https://issues.redhat.com/browse/RHEL-50968
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/network/bridge_driver.c b
If a network disappeared the daemon should not only remove it from the
list of networks, but also do a proper cleanup.
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/network/bridge_driver.c b/src
The new function (networkCleanupInactive) can be called from an iterator
over the list of networks without the risk of deadlock.
Signed-off-by: Martin Kletzander
---
src/network/bridge_driver.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/src/network
See PATCH 2/2 (duh!).
Martin Kletzander (2):
virnetdevtap: Do (not) use NULLSTR consistently
virnetdevtap: Add better error message for a possible common user
error
src/util/virnetdevtap.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
--
2.46.0
The function generates *ifname from the get go and most functions do not
wrap the string in a NULLSTR as it is not necessary. The few leftovers
are outliers that are changed to fit the theme better.
Signed-off-by: Martin Kletzander
---
src/util/virnetdevtap.c | 4 ++--
1 file changed, 2
1 - 100 of 355 matches
Mail list logo
