Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-05 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > On 04.04.25 17:13, Markus Armbruster wrote: [...] >> So, auto-finalize=true is silently ignored when another job in the same >> transaction has auto-finalize=false? > > Yes, at least, it looks like so: > > static void job_completed_txn_success_locked(Job *

Re: [PATCH v2 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-08 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > Actualize documentation and synchronize it for commands which actually > call the same functions internally. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 59 +--- > qapi/job.json

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 10:44 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >>> On 4/9/2025 9:34 AM, Markus Armbruster wrote: Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: [...] Anyway, asking you to fix design mistakes all over

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 9:34 AM, Markus Armbruster wrote: >> Steven Sistare writes: >>> On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes and pro

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: >> Hi Steve, I apologize for the slow response. >> >> Steve Sistare writes: >> >>> Using qom-list and qom-get to get all the nodes and property values in a >>> QOM tree can take multiple seconds because it requires 1000's o

Re: [PATCH v3 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-09 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > Actualize documentation and synchronize it for commands which actually > call the same functions internally. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster

Re: [PATCH V1 0/6] fast qom tree get

2025-04-09 Thread Markus Armbruster via Devel
Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes and property values in a > QOM tree can take multiple seconds because it requires 1000's of individual > QOM requests. Some managers fetch the entire tree or a large subset > of

Management applications and CPU feature flags (was: [PATCH V1 0/6] fast qom tree get)

2025-04-11 Thread Markus Armbruster via Devel
Daniel P. Berrangé writes: > On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: >> On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: >> > Hi Steve, I apologize for the slow response. >> > >> > Steve Sistare wri

Re: Management applications and CPU feature flags

2025-04-11 Thread Markus Armbruster via Devel
Daniel P. Berrangé writes: > On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: >> >> On Wed, Apr 09, 2025 at 09:39:02 +020

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-25 Thread Markus Armbruster via Devel
Pierrick Bouvier writes: > On 4/25/25 08:38, Markus Armbruster wrote: >> Pierrick Bouvier writes: >> >>> Note: This RFC was posted to trigger a discussion around this topic, and >>> it's >>> not expected to merge it as it is. >>> >>> Context >>> === >>> >>> Linaro is working towards hetero

Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

2025-04-10 Thread Markus Armbruster via Devel
Typo in subject, make it "deprecate". Vladimir Sementsov-Ogievskiy writes: > For change, pause, resume, complete, dismiss and finalize actions > corresponding job- and block-job commands are almost equal. The > difference is in find_block_job_locked() vs find_job_locked() > functions. What's dif

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-25 Thread Markus Armbruster via Devel
Pierrick Bouvier writes: > Note: This RFC was posted to trigger a discussion around this topic, and it's > not expected to merge it as it is. > > Context > === > > Linaro is working towards heterogeneous emulation, mixing several > architectures > in a single QEMU process. The first prerequi

Re: [PATCH V1 0/6] fast qom tree get

2025-04-28 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/9/2025 3:39 AM, Markus Armbruster wrote: >> Hi Steve, I apologize for the slow response. >> >> Steve Sistare writes: >> >>> Using qom-list and qom-get to get all the nodes and property values in a >>> QOM tree can take multiple seconds because it requires 1000's of

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-28 Thread Markus Armbruster via Devel
Peter Krempa writes: > On Fri, Apr 25, 2025 at 17:38:44 +0200, Markus Armbruster via Devel wrote: >> Pierrick Bouvier writes: > > [...] > >> To be precise: conditionals that use macros restricted to >> target-specific code, i.e. the ones poisoned by exec/poison

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-29 Thread Markus Armbruster via Devel
Pierrick Bouvier writes: > On 4/28/25 4:07 AM, Markus Armbruster wrote: >> Peter Krempa writes: >> >>> So what should libvirt do once multiple targets are supported? >>> >>> How do we query CPUs for each of the supported targets? >>> > > It's kind of a similar question we have to solve now with

Re: [PATCH V1 0/6] fast qom tree get

2025-04-28 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 4/28/2025 4:04 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >>> On 4/9/2025 3:39 AM, Markus Armbruster wrote: Hi Steve, I apologize for the slow response. Steve Sistare writes: > Using qom-list and qom-get to get all the nodes an

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-29 Thread Markus Armbruster via Devel
Pierrick Bouvier writes: > On 4/25/25 11:21 PM, Markus Armbruster wrote: >> Trouble is some uses of the second kind are in QAPI conditionals. I can >> see three options: >> >> (1) Drop these conditionals. >> >> (2) Replace them by run-time checks. >> >> (3) Have target-specific QAPI-generated

Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-03 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > For change, pause, resume, complete, dismiss and finalize actions > corresponding job- and block-job commands are almost equal. The > difference is in find_block_job_locked() vs find_job_locked() > functions. What's different? > > 1. find_block_job_locked()

Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-04 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > On 04.04.25 09:20, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: [...] >>> + >>> +``block-job-finalize`` (since 10.1) >>> +'' >>> + >>> +Use ``job-finalize`` instead. >>> + >> >> block-job-finalize's doc

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-05-07 Thread Markus Armbruster via Devel
Daniel P. Berrangé writes: > On Tue, Apr 29, 2025 at 09:43:24AM +0200, Markus Armbruster wrote: >> Pierrick Bouvier writes: >> >> > After looking at the introspection code, I don't see any major blocker. >> > We need to keep some of existing "if", as they are based on config-host, >> > and sho

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-05-07 Thread Markus Armbruster via Devel
Pierrick Bouvier writes: [...] > I don't think we should think too much ahead for languages other than C, > for one, two, and even three reasons :) I agree that thinking ahead too much is a bad habit. So is thinking ahead too little :) > - First, it's already broken because we rely on ifdef

Re: [PATCH 2/4] qapi/migration: Deprecate migrate argument @detach

2025-05-21 Thread Markus Armbruster via Devel
Peter Krempa writes: > On Wed, May 21, 2025 at 09:46:10 +0200, Peter Krempa via Devel wrote: >> On Wed, May 21, 2025 at 08:37:09 +0200, Markus Armbruster via Devel wrote: >> > Argument @detach has always been ignored. Start the clock to get rid >> > of it. >&

[PATCH 4/4] docs/about/removed-features: Move removal notes to tidy up order

2025-05-20 Thread Markus Armbruster via Devel
The removal notes within a section are mostly in version order. Move the few that aren't so they are. Signed-off-by: Markus Armbruster --- docs/about/removed-features.rst | 60 - 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/docs/about/removed-f

[PATCH 1/4] docs/about: Belatedly document tightening of QMP device_add checking

2025-05-20 Thread Markus Armbruster via Devel
Commit 4d8b0f0a9536 (v6.2.0) deprecate incorrectly typed device_add arguments. Commit be93fd53723c (qdev-monitor: avoid QemuOpts in QMP device_add) fixed them for v9.2.0, but neglected to update documentation. Do that now. Cc: Stefan Hajnoczi Signed-off-by: Markus Armbruster --- docs/about/de

[PATCH 3/4] docs/about/deprecated: Move deprecation notes to tidy up order

2025-05-20 Thread Markus Armbruster via Devel
The deprecation notes within a section are mostly in version order. Move the few that aren't so they are. Signed-off-by: Markus Armbruster --- docs/about/deprecated.rst | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/docs/about/deprecated.rs

[PATCH 2/4] qapi/migration: Deprecate migrate argument @detach

2025-05-20 Thread Markus Armbruster via Devel
Argument @detach has always been ignored. Start the clock to get rid of it. Cc: Peter Xu Cc: Fabiano Rosas Signed-off-by: Markus Armbruster --- docs/about/deprecated.rst | 5 + qapi/migration.json | 18 +- 2 files changed, 14 insertions(+), 9 deletions(-) diff --gi

[PATCH 0/4] An overdue deprecation, a doc fix, a bit of cleanup

2025-05-20 Thread Markus Armbruster via Devel
Markus Armbruster (4): docs/about: Belatedly document tightening of QMP device_add checking qapi/migration: Deprecate migrate argument @detach docs/about/deprecated: Move deprecation notes to tidy up order docs/about/removed-features: Move removal notes to tidy up order docs/about/depreca

Re: [PATCH 0/4] An overdue deprecation, a doc fix, a bit of cleanup

2025-05-27 Thread Markus Armbruster via Devel
Queued.

Re: [PATCH 1/4] docs/about: Belatedly document tightening of QMP device_add checking

2025-05-27 Thread Markus Armbruster via Devel
Eric Blake writes: > On Wed, May 21, 2025 at 08:37:08AM +0200, Markus Armbruster via Devel wrote: >> Commit 4d8b0f0a9536 (v6.2.0) deprecate incorrectly typed device_add > > deprecated Yes. Thank you! >> arguments. Commit be93fd53723c (qdev-monitor: avoid QemuOpts in QMP

Re: [PATCH 2/4] qapi/migration: Deprecate migrate argument @detach

2025-05-21 Thread Markus Armbruster via Devel
Peter Xu writes: > On Wed, May 21, 2025 at 08:37:09AM +0200, Markus Armbruster wrote: >> Argument @detach has always been ignored. Start the clock to get rid >> of it. >> >> Cc: Peter Xu >> Cc: Fabiano Rosas >> Signed-off-by: Markus Armbruster >> --- >> docs/about/deprecated.rst | 5 +

Re: [PATCH v2 09/10] net: Add passt network backend

2025-06-24 Thread Markus Armbruster via Devel
Laurent Vivier writes: > On 24/06/2025 10:16, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> This commit introduces support for passt as a new network backend. >>> passt is an unprivileged, user-mode networking solution that provides >>> connectivity for virtual machines by launching

Re: [PATCH V2 1/5] qom: qom-tree-get

2025-07-07 Thread Markus Armbruster via Devel
Markus Armbruster writes: > Steven Sistare writes: > >> On 7/4/2025 8:22 AM, Markus Armbruster wrote: >>> Steve Sistare writes: >>> Define the qom-tree-get QAPI command, which fetches an entire tree of properties and values with a single QAPI call. This is much faster than usin

Re: [PATCH V2 4/5] qom: qom-list-getv

2025-07-07 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 7/4/2025 8:22 AM, Markus Armbruster wrote: >> Steve Sistare writes: >> >>> Define the qom-list-getv command, which fetches all the properties and >>> values for a list of paths. This is faster than qom-tree-get when >>> fetching a subset of the QOM tree. See qom.js

Re: [PATCH V2 1/5] qom: qom-tree-get

2025-07-07 Thread Markus Armbruster via Devel
Steven Sistare writes: > On 7/4/2025 8:22 AM, Markus Armbruster wrote: >> Steve Sistare writes: >> >>> Define the qom-tree-get QAPI command, which fetches an entire tree of >>> properties and values with a single QAPI call. This is much faster >>> than using qom-list plus qom-get for every nod

Re: [PATCH v2 09/10] net: Add passt network backend

2025-06-25 Thread Markus Armbruster via Devel
Laurent Vivier writes: > On 24/06/2025 14:03, Daniel P. Berrangé wrote: >> On Tue, Jun 24, 2025 at 01:55:20PM +0200, Markus Armbruster wrote: >>> Laurent Vivier writes: >>> On 24/06/2025 10:16, Markus Armbruster wrote: > Laurent Vivier writes: > >> This commit introduces suppor

Re: [PATCH V2 1/5] qom: qom-tree-get

2025-07-04 Thread Markus Armbruster via Devel
Steve Sistare writes: > Define the qom-tree-get QAPI command, which fetches an entire tree of > properties and values with a single QAPI call. This is much faster > than using qom-list plus qom-get for every node and property of the > tree. See qom.json for details. > > Signed-off-by: Steve Sis

Re: [PATCH V2 4/5] qom: qom-list-getv

2025-07-04 Thread Markus Armbruster via Devel
Steve Sistare writes: > Define the qom-list-getv command, which fetches all the properties and > values for a list of paths. This is faster than qom-tree-get when > fetching a subset of the QOM tree. See qom.json for details. > > Signed-off-by: Steve Sistare > --- > qapi/qom.json | 34 ++

Re: [PATCH V2 0/5] fast qom tree get

2025-07-04 Thread Markus Armbruster via Devel
Steve Sistare writes: > Using qom-list and qom-get to get all the nodes and property values in a > QOM tree can take multiple seconds because it requires 1000's of individual > QOM requests. Some managers fetch the entire tree or a large subset > of it when starting a new VM, and this cost is a

Re: [PATCH v2 18/24] qapi/migration: Deprecate capabilities commands

2025-07-01 Thread Markus Armbruster via Devel
Fabiano Rosas writes: > The concept of capabilities is being merged into the concept of > parameters. From now on, the commands that handle capabilities are > deprecated in favor of the commands that handle parameters. > > Affected commands: > > - migrate-set-capabilities > - query-migrate-capabi