[PATCHv2 0/2] ch: minor fixes - segfault and last meaningful error preservation

have led to unknown error message in virsh. Add error preservation at the begining of the function and restoring it at the end to keep consistent error output Kirill Shchetiniuk (2): ch: virCHProcessStop preserve last meaningful error ch: ref count fix in virCHEventHandlerLoop and

[PATCH 1/2] ch: virCHProcessStop preserve last meaningful error

-off-by: Kirill Shchetiniuk --- src/ch/ch_process.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index 9a85f7869e..9388d5bd83 100644 --- a/src/ch/ch_process.c +++ b/src/ch/ch_process.c @@ -995,11 +995,14 @@ virCHProcessStop(virCHDriver *driver

[PATCH 2/2] ch: ref count fix in virCHEventHandlerLoop and virCHStartEventHandler

virCHEventHandlerLoop while it was still being used by the debug print. To resolve this, the VM unreference has been moved to after the debug print. Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_events.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_events.c b

[PATCH 2/2] ch: preserve last error before stop fix

Add last meaningful error preservation to virCHProcessStop. Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_process.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index 9a85f7869e..38d466eaeb 100644 --- a/src/ch/ch_process.c +++ b/src/ch

[PATCH 0/2] ch: minor fixes - segfault fix and error preserving

*** BLURB HERE *** Kirill Shchetiniuk (2): ch: memory (segmentation fault) fix ch: preserve last error before stop fix src/ch/ch_events.c | 6 +++--- src/ch/ch_process.c | 6 ++ 2 files changed, 9 insertions(+), 3 deletions(-) -- 2.48.1

[PATCH 1/2] ch: memory (segmentation fault) fix

Move monitor object unreference from virCHStartEventHandler to virCHEventHandlerLoop. Put VM unreference after debug print in virCHEventHandlerLoop. Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_events.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ch

[PATCH 2/4] ch: add transient definition save and load

during the CH driver initialization. Transient definitions are also removed when domain stops. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/743 Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_domain.c | 15 +++ src/ch/ch_domain.h | 3 +++ src/ch/ch_driver.c | 8

[PATCH 3/3] ch: virCHProcessEvent() vm shutdown event handler fix

monitor stops along with the VM. Also updated the virCHEventStopProcess job type, as it only destroys the domain rather than modifying anything. Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_events.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/ch/ch_events.c b

[PATCH 1/3] ch: virCHMonitorNew() run new CH monitor daemonized

the libvirt. Make new monitor running daemonized to avoid VMs shutdown when driver dies. Also added a pidfile its preparetion to be able to aquire daemon's PID. Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_domain.c | 1 + src/ch/ch_domain.h | 1 + src/ch/ch_monitor.c

[PATCH 0/3] ch: monitor daemonization, sync after reboot, and shutdown fixes

n 'ch-test' is being shutdown virsh # list Id Name State -- 722117 ch-test shut off Ensured the CH monitor process terminates along with the VM shutdown (e.g., executed using virsh). Updated virCHEventStopProcess to have proper job type. Kir

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel > > >> wrote: > > [...] > > > >> Either way this hunk is incorrect as this flag should not get here and > > >> the caller needs to be fixed. > > > > > > If in fact

[PATCH v2 0/2] storage: vol-create bug fix

When new volume was created using 'vol-create' and '--validate' option an error occured due to invalid flags passed downward. Resolves: https://lists.libvirt.org/archives/list/us...@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJFN7H/ Kirill Shchet

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

n function do not validate anything. What do you think? On Mon, Apr 7, 2025 at 3:11 PM Peter Krempa wrote: > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: > > On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel > wrote: > > > When th

[PATCH v2 1/2] storage: virStorageVolDefParse and storageVolCreateXML flags fix

before backend->buildVol() (traces down to storageBackendCreateQemuImg) calls, as the XML schema validation is already complete within previous steps and there is no validation later. Signed-off-by: Kirill Shchetiniuk --- src/conf/storage_conf.c | 2 ++ src/storage/storage_driver.c

[PATCH v2 2/2] NEWS: mention vol-create bug fix

Signed-off-by: Kirill Shchetiniuk --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e2dc4e508b..dd345bad7b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -28,6 +28,11 @@ v11.3.0 (unreleased) * **Bug fixes** + * storage: Fix new volume creation

[PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

to storageBackendCreateQemuImg) calls, as the XML schema validation is already complete within previous steps and there is no validation later. Signed-off-by: Kirill Shchetiniuk --- NEWS.rst | 5 + src/conf/storage_conf.c | 2 ++ src/storage/storage_driver.c | 4 +++-

[PATCH] qemu: Add GTK display with OpenGL support

From: Kirill Shchetiniuk Introduce GTK display support with OpenGL for the QEMU driver. - Add new XML options for GTK display type. - Include capability flags for the QEMU driver. Note: The `QEMU_CAPS_GTK_GL` flag cannot yet be checked, so device definition validation is incomplete. A

Re: [PATCH] qemu: Add GTK display with OpenGL support

On Mon, Apr 28, 2025 at 12:33:19PM +0200, Peter Krempa wrote: > On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: > > From: Kirill Shchetiniuk > > > > Introduce GTK display support with OpenGL for the QEMU driver. > > > > - Add new

Re: [PATCH] qemu: Add GTK display with OpenGL support

On Mon, Apr 28, 2025 at 02:40:49PM +0200, Peter Krempa wrote: > On Mon, Apr 28, 2025 at 12:22:22 +0200, Kirill Shchetiniuk via Devel wrote: > > From: Kirill Shchetiniuk > > > > Introduce GTK display support with OpenGL for the QEMU driver. > > > > - Add new

[PATCH 3/4] ch: add reconnection to running domains

g the initialization step. This allows us to perform further actions on domains even if the CH driver was restarted. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/743 Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_driver.c | 2 + src/ch/ch_monitor.c | 65 + src/ch/ch_moni

[PATCH 4/4] ch: fix timeout while domain is still running

ssues/743 Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_conf.h| 4 src/ch/ch_driver.c | 15 +-- src/ch/ch_process.c | 6 ++ 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_conf.h b/src/ch/ch_conf.h index 8beeb69b95..ca9151e5d8 100644 --- a/s

[PATCH 1/4] ch: add persistent definition save and load

an be removed with undefine. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/743 Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_conf.c | 10 +++--- src/ch/ch_conf.h | 2 ++ src/ch/ch_driver.c | 24 +++- 3 files changed, 32 insertions(+), 4 deletions(-) diff --git

[PATCH 0/4] ch: timeout fix (GitLab issue #743)

zero. NOTE: This series patch series is depend on followin patch series: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/O3SKHT3IVSQ4IF5GH7NXG66UTAAR5YRC/ Kirill Shchetiniuk (4): ch: add persistent definition save and load ch: add transient definition save and load ch

[PATCH 2/3] ch: virCHProcessEvent() update domain info after reboot

event handling to update the information in transient domain definition after domain's reboot is completed to maintain it in consistent state. Signed-off-by: Kirill Shchetiniuk --- src/ch/ch_events.c | 6 +- src/ch/ch_process.c | 2 +- src/ch/ch_process.h | 2 ++ 3 files changed, 8 inser

Re: [PATCH 1/3] ch: virCHMonitorNew() run new CH monitor daemonized

Thanks Jan, Didn’t noticed the issue with the white symbols when submitted a patch, next time will keep it in mind and be careful. Btw, do we have some tools to check and warn such possible issues? Kirill > 2. 4. 2025 v 18:36, Ján Tomko : > > On a Tuesday in 2025, Kirill Shchet

[PATCH 2/2] schemas: path attributes type refactor

From: Kirill Shchetiniuk Previously, in some places where path attributes were defined, the '' type was used instead of one of the provided types for paths. Now, the '' type has been replaced with the 'relativePath' type to maintain consistency and ensure backward

[PATCH 1/2] schemas: path types unification / refactor

From: Kirill Shchetiniuk Previously, path types were defined separately for files and directories. The `absDirPath` type, in particular, did not accept Windows-style paths. Now, absolute paths for files and directories are united under the 'absolutePath' type. Relative paths were i

RFC: schemas: resolving path type inconsistency in XML schemas

Hello everyone, Sometime ago I sent a patch changing the XML schema to add GTK support for libvirt. As the type for one path argument, I used the type, simply copying the similar approach from another place in the XML schema definition. I was told that it's not the best way to use the type fo

[PATCH 2/4] conf: SDL fullscreen option type refactor

From: Kirill Shchetiniuk Previously, the fullscreen option were parsed as a tristate but stored as a bool type, changed the fullscreen option type to tristate bool to avoid unnecessary type convertions. Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 9 - src/conf

[PATCH 0/4] conf: graphics def and parse refactor

3. SDL graphics fullscreen option type changed from bool to tristate, to avoid unnecessary type convertions. 4. desktop fullscreen option is removed as it was never used. Kirill Shchetiniuk (4): conf: VNC graphics parse refactor conf: SDL fullscreen option refactor conf: RDP graphics

[PATCH 1/4] conf: VNC graphics parse refactor

From: Kirill Shchetiniuk Previously, the VNC graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLVNC function was refactored to use the appropriate virXMLProp* utility functions. Overall parsing logic was not changed and results the same output as

[PATCH 4/4] conf: desktop graphics remove unused option

From: Kirill Shchetiniuk Previously, the 'desktop' graphics configuration contained the 'fullscreen' option which was never used, removed the unused option. Signed-off-by: Kirill Shchetiniuk --- docs/formatdomain.rst | 5 ++--- src/conf/domain_co

[PATCH 3/4] conf: RDP graphics parse refactor

From: Kirill Shchetiniuk Previously, the RDP graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLRDP function was refactored to use the appropriate virXMLProp* utility functions. Overall parsing logic was not changed and results the same output as

[PATCH v2 0/4] conf: graphics def and parse refactor

ol to tristateBool, as parameters are determined only by the initial XML. 3. 'SDL' graphics fullscreen option type changed from bool to tristateBool, to avoid unnecessary type convertions. 4. 'desktop' graphics fullscreen option is removed as it was never used. Kirill Sh

[PATCH v2 2/4] conf: SDL fullscreen option refactor

From: Kirill Shchetiniuk Previously, the fullscreen option were parsed as a tristate but stored as a bool type, changed the fullscreen option type to tristate bool to avoid unnecessary type convertions. Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 9 - src/conf

[PATCH v2 3/4] conf: RDP graphics parse refactor

From: Kirill Shchetiniuk Previously, the RDP graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLRDP function is refactored to use the appropriate virXMLProp* utility functions. Overall parsing logic was not changed and results the same output as

[PATCH v2 4/4] conf: desktop graphics remove unused option

From: Kirill Shchetiniuk Previously, the 'desktop' graphics configuration contained the 'fullscreen' option which was never used, removed the unused option. Signed-off-by: Kirill Shchetiniuk --- docs/formatdomain.rst | 5 ++--- src/conf/domain_co

[PATCH v2 1/4] conf: VNC graphics parse refactor

From: Kirill Shchetiniuk Previously, the VNC graphics definition parsing were implemented by string parsing, the virDomainGraphicsDefParseXMLVNC was refactored to use the appropriate virXMLProp* utility functions. Overall parsing logic was not changed and results the same output as before

Re: [PATCH 0/4] conf: graphics def and parse refactor

On Tue, Jun 03, 2025 at 03:53:53PM +0200, Ján Tomko wrote: > On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: > > This series is supposed to refactor the existing parse logic by > > using the proper utility function and some parameters type change. > > > >

[PATCH 1/5] conf: virNetDevVPortProfileParse refactor

From: Kirill Shchetiniuk Refactored the virNetDevVPortProfileParse function to use the appropriate virXMLProp* functions to parse input configuration XML. Signed-off-by: Kirill Shchetiniuk --- src/conf/netdev_vport_profile_conf.c | 120 +++ 1 file changed, 48

[PATCH 2/5] conf: virDomainHostdevSubsysMediatedDevDefParseXML refactor

From: Kirill Shchetiniuk Refactored the virDomainHostdevSubsysMediatedDevDefParseXML function to use virXMLPropUUID fuction instead of getting a string and parsing it later. Due to parsing function change the missing uuid error reporter and message were changed and changed error message was

[PATCH 3/5] util: virSecretLookupParseSecret refactor

From: Kirill Shchetiniuk Refactored the virSecretLookupParseSecret fucntion to use the virXMLPropUUID fucntion, avoid getting the string and parsing it later. Previously two separate error states merged into one by using boolean NXOR operation. Signed-off-by: Kirill Shchetiniuk --- src/util

[PATCH 5/5] qemu: qemuDomainObjPrivateXMLParseVcpu refactor

From: Kirill Shchetiniuk Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the appropriate virXMLPropUInt function to parse unsigned integers, avoiding unccessery string parsing operations. Signed-off-by: Kirill Shchetiniuk --- src/qemu/qemu_domain.c | 16 +++- 1

[PATCH 4/5] conf: virDomainChrDefParseTargetXML refactor

From: Kirill Shchetiniuk Refactored the default case port option parsing logic to use the appropriate virXMLPropInt function. Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c

[PATCH 0/5] Some parsing functions refactor

reporter was changed along with the reported error message and this change was also reflected in exsiting test cases. Kirill Shchetiniuk (5): conf: virNetDevVPortProfileParse refactor conf: virDomainHostdevSubsysMediatedDevDefParseXML refactor util: virSecretLookupParseSecret refactor conf

Re: [PATCH 1/5] conf: virNetDevVPortProfileParse refactor

> 14. 7. 2025 v 19:22, Ján Tomko : > > On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: >> From: Kirill Shchetiniuk >> >> Refactored the virNetDevVPortProfileParse function to use the appropriate >> virXMLProp* functions to parse input configuration

Re: [PATCH 5/5] qemu: qemuDomainObjPrivateXMLParseVcpu refactor

> 14. 7. 2025 v 19:09, Ján Tomko : > > On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: >> From: Kirill Shchetiniuk >> >> Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the >> appropriate virXMLPropUInt function to parse unsigned

[PATCH v2 0/4] Some parsing functions refactor

7;ret' temp value is now 'rc' 2. code style fixes 3. 'id' param is now parsed as not mandatory Kirill Shchetiniuk (4): conf: virNetDevVPortProfileParse refactor util: virSecretLookupParseSecret refactor conf: virDomainChrDefParseTargetXML refactor qemu: qemuDomainO

[PATCH v2 1/4] conf: virNetDevVPortProfileParse refactor

From: Kirill Shchetiniuk Refactored the virNetDevVPortProfileParse function to use the appropriate virXMLProp* functions to parse input configuration XML. Signed-off-by: Kirill Shchetiniuk --- src/conf/netdev_vport_profile_conf.c | 112 +++ 1 file changed, 44

[PATCH v2 3/4] conf: virDomainChrDefParseTargetXML refactor

From: Kirill Shchetiniuk Refactored the default case port option parsing logic to use the appropriate virXMLPropInt function. Signed-off-by: Kirill Shchetiniuk --- src/conf/domain_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf

[PATCH v2 4/4] qemu: qemuDomainObjPrivateXMLParseVcpu refactor

From: Kirill Shchetiniuk Refactored the qemuDomainObjPrivateXMLParseVcpu function to use the appropriate virXMLPropUInt function to parse unsigned integers, avoiding unccessery string parsing operations. Signed-off-by: Kirill Shchetiniuk --- src/qemu/qemu_domain.c | 16 +++- 1

[PATCH v2 2/4] util: virSecretLookupParseSecret refactor

From: Kirill Shchetiniuk Refactored the virSecretLookupParseSecret fucntion to use the virXMLPropUUID fucntion, avoid getting the string and parsing it later. Previously two separate error states merged into one by using boolean NXOR operation. Signed-off-by: Kirill Shchetiniuk --- src/util