[PATCH 0/1] virsh: Add option '--no-pkttyagent'

2025-05-06 Thread Jens Schmidt via Devel
As discussed in https://gitlab.com/libvirt/libvirt/-/issues/757. I'm not quite sure about using a long-only-option, since that's a first in virsh. But OTOH this option seems too insignificant to also use one of the precious short option characters for it. Please check and let me know what you th

[PATCH 1/1] virsh: Add option '--no-pkttyagent'

2025-05-06 Thread Jens Schmidt via Devel
In scripts repeated execution of virsh can result in a lot of journal noise when pkttyagent gets registered with polkitd each time. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/757 --- NEWS.rst| 4 docs/manpages/virsh.rst | 8 tools/virsh.c | 13

Re: [PATCH 1/1] virsh: Add option '--no-pkttyagent'

2025-05-07 Thread Jens Schmidt via Devel
Thanks for your review and comments! On 2025-05-06 10:24, Peter Krempa wrote: > As witnessed by the fact that you needed to include assert.h we don't > use asserts in the code base. > > While this code path should not be possible to reach without doing > a programming error we still should repo

[PATCHv2 0/2] virsh: Add option '--no-pkttyagent'

2025-05-19 Thread Jens Schmidt via Devel
This patchset should address all of your comments. Where "you" means Peter Krempa, I hope that the "--in-reply-to" does its job as I would expect it would do. Just to be sure, this is in reply to thread [1], namely to the message with ID . Some minor nits I came across while implementing this, a

[PATCHv2 2/2] NEWS: Mention new option '--no-pkttyagent'

2025-05-19 Thread Jens Schmidt via Devel
From: Jens Schmidt Signed-off-by: Jens Schmidt Reviewed-by: Peter Krempa --- NEWS.rst | 4 1 file changed, 4 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0da3bf4d79..d12d473ceb 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,10 @@ v11.4.0 (unreleased) * **New features** +

[PATCHv2 1/2] virsh: Add option '--no-pkttyagent'

2025-05-19 Thread Jens Schmidt via Devel
From: Jens Schmidt In scripts repeated execution of virsh can result in a lot of journal noise when pkttyagent gets registered with polkitd each time. Closes: https://gitlab.com/libvirt/libvirt/-/issues/757 Signed-off-by: Jens Schmidt Reviewed-by: Peter Krempa --- docs/manpages/virsh.rst | 8